From patchwork Sun Jan 3 09:20:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benoit PAPILLAULT X-Patchwork-Id: 70499 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o039KXsO019647 for ; Sun, 3 Jan 2010 09:20:34 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751612Ab0ACJU0 (ORCPT ); Sun, 3 Jan 2010 04:20:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751596Ab0ACJU0 (ORCPT ); Sun, 3 Jan 2010 04:20:26 -0500 Received: from smtp1-g21.free.fr ([212.27.42.1]:45527 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014Ab0ACJUZ (ORCPT ); Sun, 3 Jan 2010 04:20:25 -0500 Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id 3A2039400AD; Sun, 3 Jan 2010 10:20:17 +0100 (CET) Received: from benoit-laptop (ns.popipo.fr [88.163.232.53]) by smtp1-g21.free.fr (Postfix) with ESMTP id 299009400B5; Sun, 3 Jan 2010 10:20:15 +0100 (CET) Received: by benoit-laptop (Postfix, from userid 1000) id F19841DE05F; Sun, 3 Jan 2010 10:20:14 +0100 (CET) From: Benoit Papillault To: dsd@gentoo.org, kune@deine-taler.de Cc: linux-wireless@vger.kernel.org, zd1211-devs@lists.sourceforge.net, Benoit Papillault Subject: [PATCH] zd1211rw: Fix multicast filtering. Date: Sun, 3 Jan 2010 10:20:01 +0100 Message-Id: <1262510401-22037-1-git-send-email-benoit.papillault@free.fr> X-Mailer: git-send-email 1.6.3.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org diff --git a/drivers/net/wireless/zd1211rw/zd_mac.c b/drivers/net/wireless/zd1211rw/zd_mac.c index 5313313..9cb6cbc 100644 --- a/drivers/net/wireless/zd1211rw/zd_mac.c +++ b/drivers/net/wireless/zd1211rw/zd_mac.c @@ -1005,12 +1005,13 @@ static void zd_op_configure_filter(struct ieee80211_hw *hw, changed_flags &= SUPPORTED_FIF_FLAGS; *new_flags &= SUPPORTED_FIF_FLAGS; - /* changed_flags is always populated but this driver - * doesn't support all FIF flags so its possible we don't - * need to do anything */ - if (!changed_flags) - return; - + /* + * If multicast parameter (as returned by zd_op_prepare_multicast) + * has changed, no bit in changed_flags is set. To handle this + * situation, we do not return if changed_flags is 0. If we do so, + * we will have some issue with IPv6 which uses multicast for link + * layer address resolution. + */ if (*new_flags & (FIF_PROMISC_IN_BSS | FIF_ALLMULTI)) zd_mc_add_all(&hash);