From patchwork Mon Jul 19 23:56:38 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guy, Wey-Yi W" X-Patchwork-Id: 112837 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o6JNvInZ014792 for ; Mon, 19 Jul 2010 23:57:18 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757145Ab0GSX5R (ORCPT ); Mon, 19 Jul 2010 19:57:17 -0400 Received: from mga11.intel.com ([192.55.52.93]:49101 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756791Ab0GSX5Q (ORCPT ); Mon, 19 Jul 2010 19:57:16 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 19 Jul 2010 16:55:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.55,229,1278313200"; d="scan'208,223";a="587762716" Received: from wwguy-ubuntu.jf.intel.com (HELO [134.134.163.226]) ([134.134.163.226]) by fmsmga002.fm.intel.com with ESMTP; 19 Jul 2010 16:56:37 -0700 Subject: Re: iwlagn and many firmware restarts with Fedora kernel From: "Guy, Wey-Yi" To: Marcel Holtmann Cc: drago01 , "linux-wireless@vger.kernel.org" In-Reply-To: <1279582174.4572.43.camel@localhost.localdomain> References: <1279565034.4572.36.camel@localhost.localdomain> <1279582174.4572.43.camel@localhost.localdomain> Date: Mon, 19 Jul 2010 16:56:38 -0700 Message-Id: <1279583798.28066.3.camel@wwguy-ubuntu> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Mon, 19 Jul 2010 23:57:18 +0000 (UTC) From d399851898df57fc03d513c2a336d3f3745b0d10 Mon Sep 17 00:00:00 2001 From: Wey-Yi Guy Date: Mon, 19 Jul 2010 16:38:19 -0700 Subject: [PATCH 1/1] iwlwifi: extend the stuck queue monitor timer for 5350 device Different hardware has differnet behavior, extend the monitor period timer from 1 second to 5 seconds to avoid the un-necessary firmware reload Signed-off-by: Wey-Yi Guy --- drivers/net/wireless/iwlwifi/iwl-5000.c | 2 +- drivers/net/wireless/iwlwifi/iwl-dev.h | 1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c index 68e282b..4325a53 100644 --- a/drivers/net/wireless/iwlwifi/iwl-5000.c +++ b/drivers/net/wireless/iwlwifi/iwl-5000.c @@ -642,7 +642,7 @@ struct iwl_cfg iwl5350_agn_cfg = { .chain_noise_num_beacons = IWL_CAL_NUM_BEACONS, .plcp_delta_threshold = IWL_MAX_PLCP_ERR_LONG_THRESHOLD_DEF, .chain_noise_scale = 1000, - .monitor_recover_period = IWL_MONITORING_PERIOD, + .monitor_recover_period = IWL_LONG_MONITORING_PERIOD, .max_event_log_size = 512, .ucode_tracing = true, .sensitivity_calib_by_driver = true, diff --git a/drivers/net/wireless/iwlwifi/iwl-dev.h b/drivers/net/wireless/iwlwifi/iwl-dev.h index 30853c8..d439b80 100644 --- a/drivers/net/wireless/iwlwifi/iwl-dev.h +++ b/drivers/net/wireless/iwlwifi/iwl-dev.h @@ -1051,6 +1051,7 @@ struct iwl_event_log { /* timer constants use to monitor and recover stuck tx queues in mSecs */ #define IWL_MONITORING_PERIOD (1000) +#define IWL_LONG_MONITORING_PERIOD (5000) #define IWL_ONE_HUNDRED_MSECS (100) #define IWL_SIXTY_SECS (60000) -- 1.5.6.3