From patchwork Wed Jul 21 20:38:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "John W. Linville" X-Patchwork-Id: 113459 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.4/8.14.3) with ESMTP id o6LKjHSp008093 for ; Wed, 21 Jul 2010 20:45:17 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754135Ab0GUUpO (ORCPT ); Wed, 21 Jul 2010 16:45:14 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:49490 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206Ab0GUUpN (ORCPT ); Wed, 21 Jul 2010 16:45:13 -0400 Received: from uucp by smtp.tuxdriver.com with local-rmail (Exim 4.63) (envelope-from ) id 1ObgAB-0006A3-Em; Wed, 21 Jul 2010 16:45:11 -0400 Received: from linville-t400.local (linville-t400.local [127.0.0.1]) by linville-t400.local (8.14.4/8.14.3) with ESMTP id o6LKcRlV032424; Wed, 21 Jul 2010 16:38:27 -0400 Received: (from linville@localhost) by linville-t400.local (8.14.4/8.14.4/Submit) id o6LKcRV1032422; Wed, 21 Jul 2010 16:38:27 -0400 From: "John W. Linville" To: linux-wireless@vger.kernel.org Cc: "John W. Linville" Subject: [PATCH] rtl8180: silence "dubious: x | !y" sparse warning Date: Wed, 21 Jul 2010 16:38:25 -0400 Message-Id: <1279744705-32389-1-git-send-email-linville@tuxdriver.com> X-Mailer: git-send-email 1.7.1.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Wed, 21 Jul 2010 20:45:17 +0000 (UTC) diff --git a/drivers/net/wireless/rtl818x/rtl8180_rtl8225.c b/drivers/net/wireless/rtl818x/rtl8180_rtl8225.c index 4d2be0d..69e4d47 100644 --- a/drivers/net/wireless/rtl818x/rtl8180_rtl8225.c +++ b/drivers/net/wireless/rtl818x/rtl8180_rtl8225.c @@ -50,7 +50,10 @@ static void rtl8225_write(struct ieee80211_hw *dev, u8 addr, u16 data) udelay(10); for (i = 15; i >= 0; i--) { - u16 reg = reg80 | !!(bangdata & (1 << i)); + u16 reg = reg80; + + if (bangdata & (1 << i)) + reg |= 1; if (i & 1) rtl818x_iowrite16(priv, &priv->map->RFPinsOutput, reg);