From patchwork Wed Jul 13 12:19:14 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 971632 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6DCJKM8022103 for ; Wed, 13 Jul 2011 12:19:21 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958Ab1GMMTR (ORCPT ); Wed, 13 Jul 2011 08:19:17 -0400 Received: from mail.perches.com ([173.55.12.10]:3962 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907Ab1GMMTQ (ORCPT ); Wed, 13 Jul 2011 08:19:16 -0400 Received: from [192.168.1.162] (unknown [192.168.1.162]) by mail.perches.com (Postfix) with ESMTP id 6867324368; Wed, 13 Jul 2011 05:19:10 -0700 (PDT) Subject: Re: [PATCH 01/24] ath6kl: add bmi.c From: Joe Perches To: Kalle Valo Cc: linux-wireless@vger.kernel.org, devel@linuxdriverproject.org, gregkh@suse.de In-Reply-To: <4E1D4479.8090201@qca.qualcomm.com> References: <20110713013023.8517.15940.stgit@localhost6.localdomain6> <20110713013300.8517.98566.stgit@localhost6.localdomain6> <1310531333.1143.25.camel@Joe-Laptop> <4E1D4479.8090201@qca.qualcomm.com> Date: Wed, 13 Jul 2011 05:19:14 -0700 Message-ID: <1310559554.1662.6.camel@Joe-Laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 13 Jul 2011 12:19:21 +0000 (UTC) On Wed, 2011-07-13 at 10:08 +0300, Kalle Valo wrote: > On 07/13/2011 07:28 AM, Joe Perches wrote: > > On Wed, 2011-07-13 at 04:33 +0300, Kalle Valo wrote: > >> diff --git a/drivers/net/wireless/ath/ath6kl/bmi.c b/drivers/net/wireless/ath/ath6kl/bmi.c > > [] > >> + ath6kl_err("Unable to decrement the command " > >> + "credit count register: %d\n", ret); > > I think all of these ath6kl_ uses in all the patches > > should coalesce formats that are split across multiple lines. > > This helps grepping the sources for a specific dmesg. > > ath6kl_err("Unable to decrement the command credit count register: %d\n", > > ret); > I agree, that would improve readibility. The reason why the lines were > split is because of checkpatch warnings. I could unsplit them but then > someone else might start complaining about high number checkpatch > warnings about long lines. So I really don't know what to do with them. Add this patch to checkpatch? I'll submit it to Andrew Morton later. Tested-by: Kalle Valo --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b0aa2c6..c0be3c5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -210,7 +210,7 @@ our $typeTypedefs = qr{(?x: our $logFunctions = qr{(?x: printk| - [a-z]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)| + [a-z0-9]+_(emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)| WARN| panic| MODULE_[A-Z_]+