From patchwork Fri Jul 22 18:56:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 1000782 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6MIwlQF027138 for ; Fri, 22 Jul 2011 18:58:49 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755164Ab1GVS6r (ORCPT ); Fri, 22 Jul 2011 14:58:47 -0400 Received: from mms2.broadcom.com ([216.31.210.18]:3342 "EHLO mms2.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755032Ab1GVS5e (ORCPT ); Fri, 22 Jul 2011 14:57:34 -0400 Received: from [10.9.200.131] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Fri, 22 Jul 2011 12:02:25 -0700 X-Server-Uuid: D3C04415-6FA8-4F2C-93C1-920E106A2031 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Fri, 22 Jul 2011 11:57:21 -0700 Received: from mail-sj1-12.sj.broadcom.com (mail-sj1-12.sj.broadcom.com [10.17.16.106]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 5026C74D05; Fri, 22 Jul 2011 11:57:21 -0700 (PDT) Received: from arend-laptop (unknown [10.177.252.246]) by mail-sj1-12.sj.broadcom.com (Postfix) with ESMTP id 8CFF520504; Fri, 22 Jul 2011 11:57:18 -0700 (PDT) Received: from arend by arend-laptop with local (Exim 4.74) ( envelope-from ) id 1QkKuS-0000qJ-Qz; Fri, 22 Jul 2011 20:57:16 +0200 From: "Arend van Spriel" To: gregkh@suse.de cc: "Roland Vossen" , devel@linuxdriverproject.org, linux-wireless@vger.kernel.org, "Arend van Spriel" Subject: [PATCH 02/29] staging: brcm80211: fixed checkpatch warnings for brcmutil dir Date: Fri, 22 Jul 2011 20:56:49 +0200 Message-ID: <1311361036-3175-3-git-send-email-arend@broadcom.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1311361036-3175-1-git-send-email-arend@broadcom.com> References: <1311361036-3175-1-git-send-email-arend@broadcom.com> MIME-Version: 1.0 X-WSS-ID: 623716CA4U8628101-06-01 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Fri, 22 Jul 2011 18:58:50 +0000 (UTC) From: Roland Vossen Most of them being 'line longer than 80 chars' type of warning. Cc: devel@linuxdriverproject.org Cc: linux-wireless@vger.kernel.org Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel --- drivers/staging/brcm80211/brcmutil/utils.c | 9 ++++++--- drivers/staging/brcm80211/brcmutil/wifi.c | 23 +++++++++++++++-------- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/staging/brcm80211/brcmutil/utils.c b/drivers/staging/brcm80211/brcmutil/utils.c index 4b08157..7b4d658 100644 --- a/drivers/staging/brcm80211/brcmutil/utils.c +++ b/drivers/staging/brcm80211/brcmutil/utils.c @@ -489,8 +489,8 @@ static const u8 crc8_table[256] = { }; u8 brcmu_crc8(u8 *pdata, /* pointer to array of data to process */ - uint nbytes, /* number of input data bytes to process */ - u8 crc /* either CRC8_INIT_VALUE or previous return value */ + uint nbytes, /* number of input data bytes to process */ + u8 crc /* either CRC8_INIT_VALUE or previous return value */ ) { /* loop over the buffer data */ while (nbytes-- > 0) @@ -586,7 +586,10 @@ brcmu_format_flags(const struct brcmu_bit_desc *bd, u32 flags, char *buf, } EXPORT_SYMBOL(brcmu_format_flags); -/* print bytes formatted as hex to a string. return the resulting string length */ +/* + * print bytes formatted as hex to a string. return the resulting + * string length + */ int brcmu_format_hex(char *str, const void *bytes, int len) { int i; diff --git a/drivers/staging/brcm80211/brcmutil/wifi.c b/drivers/staging/brcm80211/brcmutil/wifi.c index 1bce888..636515c 100644 --- a/drivers/staging/brcm80211/brcmutil/wifi.c +++ b/drivers/staging/brcm80211/brcmutil/wifi.c @@ -43,9 +43,9 @@ bool brcmu_chspec_malformed(u16 chanspec) EXPORT_SYMBOL(brcmu_chspec_malformed); /* - * This function returns the channel number that control traffic is being sent on, for legacy - * channels this is just the channel number, for 40MHZ channels it is the upper or lowre 20MHZ - * sideband depending on the chanspec selected + * This function returns the channel number that control traffic is being sent + * on, for legacy channels this is just the channel number, for 40MHZ channels + * it is the upper or lower 20MHZ sideband depending on the chanspec selected. */ u8 brcmu_chspec_ctlchan(u16 chspec) { @@ -55,15 +55,22 @@ u8 brcmu_chspec_ctlchan(u16 chspec) if (CHSPEC_CTL_SB(chspec) == WL_CHANSPEC_CTL_SB_NONE) { return CHSPEC_CHANNEL(chspec); } else { - /* we only support 40MHZ with sidebands */ - /* chanspec channel holds the centre frequency, use that and the - * side band information to reconstruct the control channel number + /* + * we only support 40MHZ with sidebands. chanspec channel holds + * the centre frequency, use that and the side band information + * to reconstruct the control channel number */ if (CHSPEC_CTL_SB(chspec) == WL_CHANSPEC_CTL_SB_UPPER) - /* control chan is the upper 20 MHZ SB of the 40MHZ channel */ + /* + * control chan is the upper 20 MHZ SB of the + * 40MHZ channel + */ ctl_chan = UPPER_20_SB(CHSPEC_CHANNEL(chspec)); else - /* control chan is the lower 20 MHZ SB of the 40MHZ channel */ + /* + * control chan is the lower 20 MHZ SB of the + * 40MHZ channel + */ ctl_chan = LOWER_20_SB(CHSPEC_CHANNEL(chspec)); }