From patchwork Fri Jul 13 08:38:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zefir Kurtisi X-Patchwork-Id: 1194431 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 23EC43FD48 for ; Fri, 13 Jul 2012 08:38:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756503Ab2GMIir (ORCPT ); Fri, 13 Jul 2012 04:38:47 -0400 Received: from mail.neratec.com ([80.75.119.105]:33156 "EHLO mail.neratec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756231Ab2GMIio (ORCPT ); Fri, 13 Jul 2012 04:38:44 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.neratec.com (Postfix) with ESMTP id C8DC68A0927; Fri, 13 Jul 2012 10:38:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at neratec.com Received: from mail.neratec.com ([127.0.0.1]) by localhost (mail.neratec.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 43MrWvINw3FB; Fri, 13 Jul 2012 10:38:31 +0200 (CEST) Received: from CHL500308.neratec.local (CHL500308.neratec.local [192.168.11.104]) by mail.neratec.com (Postfix) with ESMTPSA id 299E38A0926; Fri, 13 Jul 2012 10:38:31 +0200 (CEST) From: Zefir Kurtisi To: mcgrof@kernel.org Cc: lf_driver_backport@lists.linux-foundation.org, linux-wireless@vger.kernel.org, linux-bluetooth@vger.kernel.org, Zefir Kurtisi Subject: [PATCH] compat: fix system crash on 2.6.35 when flushing work Date: Fri, 13 Jul 2012 10:38:34 +0200 Message-Id: <1342168714-3361-1-git-send-email-zefir.kurtisi@neratec.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Ubuntu 10.10 stock kernel (2.6.35-22-generic) crashes in compat_flush_scheduled_work(), that is called e.g. when mac80211 module is unloaded. The problem was introduced with 80bf8a83 compat: backport system work queues system_wq and system_long_wq The crash happens in compat_flush_scheduled_work() where both flush_workqueue() and flush_scheduled_work() are called successively. Removing one of them resolves the issue. All compat-wireless tarballs after 2012-03-18 are affected. Signed-off-by: Zefir Kurtisi --- compat/compat-2.6.36.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/compat/compat-2.6.36.c b/compat/compat-2.6.36.c index 9190ecd..8f25be0 100644 --- a/compat/compat-2.6.36.c +++ b/compat/compat-2.6.36.c @@ -140,7 +140,6 @@ void compat_flush_scheduled_work(void) * go with the old kernel's one first for now (keventd_wq) and * if think its reasonable later we can flip this around. */ - flush_workqueue(system_wq); flush_scheduled_work(); } EXPORT_SYMBOL_GPL(compat_flush_scheduled_work);