From patchwork Thu Oct 4 09:16:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Emeltchenko X-Patchwork-Id: 1545521 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 00B4ADF238 for ; Thu, 4 Oct 2012 09:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428Ab2JDJO7 (ORCPT ); Thu, 4 Oct 2012 05:14:59 -0400 Received: from mga14.intel.com ([143.182.124.37]:39837 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777Ab2JDJO7 (ORCPT ); Thu, 4 Oct 2012 05:14:59 -0400 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 04 Oct 2012 02:14:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,533,1344236400"; d="scan'208";a="152295589" Received: from aemeltch-mobl1.fi.intel.com (HELO aemeltch-MOBL1.ger.corp.intel.com) ([10.237.72.165]) by AZSMGA002.ch.intel.com with ESMTP; 04 Oct 2012 02:14:57 -0700 Received: by aemeltch-MOBL1.ger.corp.intel.com (Postfix, from userid 1001) id 20719140042; Thu, 4 Oct 2012 12:16:01 +0300 (EEST) From: Andrei Emeltchenko To: linux-wireless@vger.kernel.org Cc: bzhao@marvell.com Subject: [PATCH] mwifiex: Using %*phD instead of print_hex_dump_bytes Date: Thu, 4 Oct 2012 12:16:01 +0300 Message-Id: <1349342161-27008-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Andrei Emeltchenko Make output more readable and remove unneeded function call. ... mwifiex_sdio mmc0:0001:1: last_cmd_index = 3 last_cmd_id: 00000000: 28 00 28 00 28 (.(.( ... would be changed to: ... mwifiex_sdio mmc0:0001:1: last_cmd_index = 3 mwifiex_sdio mmc0:0001:1: last_cmd_id: 28 00 28 00 28 ... Signed-off-by: Andrei Emeltchenko --- drivers/net/wireless/mwifiex/cmdevt.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c index 225c1a4..e6a0600 100644 --- a/drivers/net/wireless/mwifiex/cmdevt.c +++ b/drivers/net/wireless/mwifiex/cmdevt.c @@ -917,21 +917,20 @@ mwifiex_cmd_timeout_func(unsigned long function_context) dev_err(adapter->dev, "last_cmd_index = %d\n", adapter->dbg.last_cmd_index); - print_hex_dump_bytes("last_cmd_id: ", DUMP_PREFIX_OFFSET, - adapter->dbg.last_cmd_id, DBG_CMD_NUM); - print_hex_dump_bytes("last_cmd_act: ", DUMP_PREFIX_OFFSET, - adapter->dbg.last_cmd_act, DBG_CMD_NUM); + dev_err(adapter->dev, "last_cmd_id: %*ph\n", DBG_CMD_NUM, + adapter->dbg.last_cmd_id); + dev_err(adapter->dev, "last_cmd_act: %*ph\n", DBG_CMD_NUM, + adapter->dbg.last_cmd_act); dev_err(adapter->dev, "last_cmd_resp_index = %d\n", adapter->dbg.last_cmd_resp_index); - print_hex_dump_bytes("last_cmd_resp_id: ", DUMP_PREFIX_OFFSET, - adapter->dbg.last_cmd_resp_id, - DBG_CMD_NUM); + dev_err(adapter->dev, "last_cmd_resp_id: %*ph\n", DBG_CMD_NUM, + adapter->dbg.last_cmd_resp_id); dev_err(adapter->dev, "last_event_index = %d\n", adapter->dbg.last_event_index); - print_hex_dump_bytes("last_event: ", DUMP_PREFIX_OFFSET, - adapter->dbg.last_event, DBG_CMD_NUM); + dev_err(adapter->dev, "last_event: %*ph\n", DBG_CMD_NUM, + adapter->dbg.last_event); dev_err(adapter->dev, "data_sent=%d cmd_sent=%d\n", adapter->data_sent, adapter->cmd_sent);