From patchwork Wed Feb 20 15:11:04 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 2167711 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id B86BA3FE37 for ; Wed, 20 Feb 2013 15:11:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935488Ab3BTPLJ (ORCPT ); Wed, 20 Feb 2013 10:11:09 -0500 Received: from mail-da0-f42.google.com ([209.85.210.42]:33721 "EHLO mail-da0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933198Ab3BTPLH (ORCPT ); Wed, 20 Feb 2013 10:11:07 -0500 Received: by mail-da0-f42.google.com with SMTP id z17so3559498dal.1 for ; Wed, 20 Feb 2013 07:11:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:subject:from:to:cc:date:in-reply-to :references:content-type:x-mailer:content-transfer-encoding :mime-version; bh=HXlWRy1VdEEfFBChtbCh+FEgb/YfFGkXaUvVQDPblDk=; b=evBIrIhdW3c9Tk6vN4HueFpL+CIXTcRyH097S4e+yJgHEaeg0rHj5VgYHdpbF66kQP PRCN7dXCXuaMgz8uMMNunKM/669gWk9TWbauP120wJQUA2LfWNk58hyAxpkAIEMgefyl 0pGcGr+TMZN+QqUDtUcq9JFLsTTTaU5HGy1TNhz/l6bWBBjywgLWb73MbCBOChae8aZ4 yhBRMoeRYgfb9g+YNUMfePZoYREfD0Iss022y2TvWwyuWSJdMm1SWeL1k8+9TqQcRBFL KpwDMIqo4B8QLi13EhSYZHp22ZVDiN7um3zOB1tzv497P+8CWkraxSwtVLq1hPEtjUDA j5lA== X-Received: by 10.68.48.165 with SMTP id m5mr49880485pbn.40.1361373066825; Wed, 20 Feb 2013 07:11:06 -0800 (PST) Received: from [172.26.49.221] ([172.26.49.221]) by mx.google.com with ESMTPS id ab1sm21932134pbd.37.2013.02.20.07.11.05 (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 20 Feb 2013 07:11:06 -0800 (PST) Message-ID: <1361373064.19353.180.camel@edumazet-glaptop> Subject: Re: 3.7.8/amd64 full interrupt hangs due to iwlwifi under big nfs copies out From: Eric Dumazet To: Johannes Berg Cc: Marc MERLIN , David Miller , Larry.Finger@lwfinger.net, bhutchings@solarflare.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 20 Feb 2013 07:11:04 -0800 In-Reply-To: <1361351703.8629.5.camel@jlt4.sipsolutions.net> References: <1333998672.3007.245.camel@edumazet-glaptop> <20120409.153452.1284163346306246866.davem@davemloft.net> <1334030180.13293.98.camel@edumazet-glaptop> <20120410051127.GA32048@merlins.org> <1334038263.2907.1.camel@edumazet-glaptop> <20120411052733.GA17352@merlins.org> <20120715215935.GF24420@merlins.org> <1342419529.3265.12217.camel@edumazet-glaptop> <20120716151826.GA10586@merlins.org> <1342455717.2830.14.camel@edumazet-glaptop> <20130219040557.GB4778@merlins.org> <1361251033.19353.120.camel@edumazet-glaptop> (sfid-20130219_061917_530878_1ED7A14C) <1361268221.8553.1.camel@jlt4.sipsolutions.net> <1361290909.19353.140.camel@edumazet-glaptop> (sfid-20130219_172155_748777_C3ED0F5E) <1361351538.8629.3.camel@jlt4.sipsolutions.net> (sfid-20130220_101252_930264_DBD3955C) <1361351703.8629.5.camel@jlt4.sipsolutions.net> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2013-02-20 at 10:15 +0100, Johannes Berg wrote: > OTOH, this affects the protocol, and when you really can't allocate any > order-1 pages you pointed out yourself that many other things also won't > work, so I'm not really sure it makes a big difference if we change the > driver? It will make a huge difference, even on non pressure mode, as TCP receive window will grow twice faster. Unless wifi speed reaches 10Gbps, following patch should do the trick --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/iwlwifi/dvm/rx.c b/drivers/net/wireless/iwlwifi/dvm/rx.c index a4eed20..77a3ee3 100644 --- a/drivers/net/wireless/iwlwifi/dvm/rx.c +++ b/drivers/net/wireless/iwlwifi/dvm/rx.c @@ -750,7 +750,12 @@ static void iwlagn_pass_packet_to_mac80211(struct iwl_priv *priv, /* Dont use dev_alloc_skb(), we'll have enough headroom once * ieee80211_hdr pulled. */ - skb = alloc_skb(128, GFP_ATOMIC); + fraglen = 128; + /* if we use order-1 pages, copy to get better TCP performance */ + if (rxb->truesize > PAGE_SIZE) + fraglen = max_t(unsigned, fraglen, len); + + skb = alloc_skb(fraglen, GFP_ATOMIC); if (!skb) { IWL_ERR(priv, "alloc_skb failed\n"); return;