From patchwork Thu Apr 25 13:31:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 2488321 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 837B23FC64 for ; Thu, 25 Apr 2013 13:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141Ab3DYNbe (ORCPT ); Thu, 25 Apr 2013 09:31:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:27498 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932134Ab3DYNbe (ORCPT ); Thu, 25 Apr 2013 09:31:34 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 25 Apr 2013 06:31:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,551,1363158000"; d="scan'208";a="301871314" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.173]) by orsmga001.jf.intel.com with ESMTP; 25 Apr 2013 06:31:26 -0700 Received: from andy by smile with local (Exim 4.80) (envelope-from ) id 1UVMGi-0000XE-G0; Thu, 25 Apr 2013 16:31:24 +0300 From: Andy Shevchenko To: linux-wireless@vger.kernel.org, Kalle Valo , "John W . Linville" Cc: Andy Shevchenko Subject: [PATCH v2] wireless: ath6kl: re-use native helper to parse MAC Date: Thu, 25 Apr 2013 16:31:22 +0300 Message-Id: <1366896682-2023-1-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 1.8.2.rc0.22.gb3600c3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org There is native mac_pton() function which helps to parse MAC. Signed-off-by: Andy Shevchenko --- drivers/net/wireless/ath/ath6kl/debug.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c index fe38b83..dbfd17d 100644 --- a/drivers/net/wireless/ath/ath6kl/debug.c +++ b/drivers/net/wireless/ath/ath6kl/debug.c @@ -1240,20 +1240,14 @@ static ssize_t ath6kl_force_roam_write(struct file *file, char buf[20]; size_t len; u8 bssid[ETH_ALEN]; - int i; - int addr[ETH_ALEN]; len = min(count, sizeof(buf) - 1); if (copy_from_user(buf, user_buf, len)) return -EFAULT; buf[len] = '\0'; - if (sscanf(buf, "%02x:%02x:%02x:%02x:%02x:%02x", - &addr[0], &addr[1], &addr[2], &addr[3], &addr[4], &addr[5]) - != ETH_ALEN) + if (!mac_pton(buf, bssid)) return -EINVAL; - for (i = 0; i < ETH_ALEN; i++) - bssid[i] = addr[i]; ret = ath6kl_wmi_force_roam_cmd(ar->wmi, bssid); if (ret)