From patchwork Wed Oct 30 11:42:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 3114251 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 05DD79F43F for ; Wed, 30 Oct 2013 11:45:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6099A201FB for ; Wed, 30 Oct 2013 11:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F5FB2025B for ; Wed, 30 Oct 2013 11:45:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753500Ab3J3LpP (ORCPT ); Wed, 30 Oct 2013 07:45:15 -0400 Received: from mail-ee0-f42.google.com ([74.125.83.42]:43310 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786Ab3J3LpM (ORCPT ); Wed, 30 Oct 2013 07:45:12 -0400 Received: by mail-ee0-f42.google.com with SMTP id b45so711396eek.15 for ; Wed, 30 Oct 2013 04:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hJ/B5M6jtl8/pjJHsUPJEx6JIJBZuZ71CDCNf0DvALw=; b=5Q2ZSifqI4cRMo6T1eMwCN27Fj7IxXBNcLgg0tFqSro6BVFSyuxP8NnCEU8Z2kXRDy S8fXeS3GFFiF5FHOSBL25bK3c5PKewnTRN2E6FDaH/+Kytkabaz1nJrk8o7H+Y179eVQ U4GzOX+zrG20GxsEbw/9K595dpp8ucppfRJ/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hJ/B5M6jtl8/pjJHsUPJEx6JIJBZuZ71CDCNf0DvALw=; b=MBsLHoIA31YcXwivajJeJZB7nM8AFwd+GBAqZSTUM47EdabuP0OfaOQMfvJw3d4euQ 8CRwYMdOnJEPSet9idfufmDiaCRM35Y4G1AekG4LgpMQvfwMP1/JyPP/l35zHsKRtdBq sRmLPqvEdiU3Okex6rqOZkLvRvHFuuQ83sx1YSDpas39wJYuxAdcDB0MAfo06ZpkW7ke s3I6YRPH7ZGeWY7BeQxDmcrm0gemTY8Y6cQImRRG7tl929vw64JMAX/G36LdWVK7p7Fe JWh21EffaowfKu7xvtxdJgxMuasQZ5V8OZjgZ3tYOYRd0bl8t0GZmpQfr2q/va83RNYm pyqw== X-Gm-Message-State: ALoCoQnARlWFLLXhjvMkFVQvZnVi2yy0gvzfNQXiGjSmTykTeym5kbD8YSjcKpmbi+8xJIx6eud/uaSyPJXjgNGkYpoFmOAF18UkOm5YYkrb4nfhgUCIQnU= X-Received: by 10.15.75.73 with SMTP id k49mr4627192eey.36.1383133511080; Wed, 30 Oct 2013 04:45:11 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id a6sm82510594eei.10.2013.10.30.04.45.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Oct 2013 04:45:10 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, greearb@candelatech.com, Michal Kazior Subject: [PATCH/RFT 02/12] ath10k: don't forget to kill fw error tasklet Date: Wed, 30 Oct 2013 12:42:16 +0100 Message-Id: <1383133346-8135-3-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.4.rc3 In-Reply-To: <1383133346-8135-1-git-send-email-michal.kazior@tieto.com> References: <1383133346-8135-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It was possible for FW error tasklet to be executed during teardown. This could lead to system crashes and/or memory corruption. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 05cdbf0..aa43466 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -888,6 +888,7 @@ static void ath10k_pci_stop_ce(struct ath10k *ar) /* Cancel the pending tasklet */ tasklet_kill(&ar_pci->intr_tq); + tasklet_kill(&ar_pci->msi_fw_err); for (i = 0; i < CE_COUNT; i++) tasklet_kill(&ar_pci->pipe_info[i].intr);