From patchwork Fri Nov 8 07:01:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 3156511 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5C6249F440 for ; Fri, 8 Nov 2013 07:04:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2ED3020490 for ; Fri, 8 Nov 2013 07:04:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31F8920481 for ; Fri, 8 Nov 2013 07:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418Ab3KHHEw (ORCPT ); Fri, 8 Nov 2013 02:04:52 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:45600 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946Ab3KHHEr (ORCPT ); Fri, 8 Nov 2013 02:04:47 -0500 Received: by mail-ee0-f54.google.com with SMTP id c50so792971eek.27 for ; Thu, 07 Nov 2013 23:04:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xyk7QQMSQSTeEIiA9WQ9RQE31ojVOn3mmFPVogFl814=; b=cxrQd7ow8z/oxezkiOYi/vSdly9aVa61f/Wt3TTjiHS8BbvK5IeDgsXfj+SrqUOOKA C5b7V6rGMmR3DoJZSVEuZuJQm9Yz0cWFwKfLgLHBys7Hw/JkzD4lByzRUIYi9ZUIiXdq 2WqAZ9lZ+yuwy07e8U47i+qJtFo25cCZCxxak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xyk7QQMSQSTeEIiA9WQ9RQE31ojVOn3mmFPVogFl814=; b=NB5bDKn28D4XSOEhbg8ZgrHTey7134aMrDNiHso8j++VvyzKwmum+2i1f7WN6eIIt3 QTx0mXoYnns1dMCD3CoUGHXXIduGYZlyHTUibA/i8V2WaltIcX8DWPAjYoTF1Q7s0mb2 CykumaJPkmq6t4t9DS+LPsSD5YnNJSmG/lJK50sKATm3FyTFiQgNrwzB1iev4Dw0QGr7 ff2qUMPNfBj+xFc1i+Dv274PkoxnEwiCsvvSO4uZbT5jEu+YTsgja/6ZX3EYO43hro4P m2f06b4CsUwn1fTybTBMbBO9qKVQFMhMfC4qjYHccVejiY4FjTSZS/6iqW3l4IaPdFw2 nBUQ== X-Gm-Message-State: ALoCoQktbVljLztQ2MQchQYR0YFghiz6EU6ZLcmObJCKGMwlhURV/stKi8CXX4Kh9XLY4j8ZqEZFA9IzxKv7LaqcbOcCVHiJXyKrpvyMiebTPPmlAbPeuQo= X-Received: by 10.14.198.66 with SMTP id u42mr75759een.80.1383894286633; Thu, 07 Nov 2013 23:04:46 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id u46sm18915155eep.17.2013.11.07.23.04.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Nov 2013 23:04:46 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCHv2 02/13] ath10k: don't forget to kill fw error tasklet Date: Fri, 8 Nov 2013 08:01:24 +0100 Message-Id: <1383894095-27998-3-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.4.rc3 In-Reply-To: <1383894095-27998-1-git-send-email-michal.kazior@tieto.com> References: <1383133346-8135-1-git-send-email-michal.kazior@tieto.com> <1383894095-27998-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It was possible for FW error tasklet to be executed during teardown. This could lead to system crashes and/or memory corruption. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index f054d4c..31cdde0 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -888,6 +888,7 @@ static void ath10k_pci_stop_ce(struct ath10k *ar) /* Cancel the pending tasklet */ tasklet_kill(&ar_pci->intr_tq); + tasklet_kill(&ar_pci->msi_fw_err); for (i = 0; i < CE_COUNT; i++) tasklet_kill(&ar_pci->pipe_info[i].intr);