From patchwork Tue Nov 19 10:36:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 3200891 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 00610C045B for ; Tue, 19 Nov 2013 10:37:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D2CF62030E for ; Tue, 19 Nov 2013 10:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB07420334 for ; Tue, 19 Nov 2013 10:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752104Ab3KSKgu (ORCPT ); Tue, 19 Nov 2013 05:36:50 -0500 Received: from mail.skyhub.de ([78.46.96.112]:34107 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650Ab3KSKgr (ORCPT ); Tue, 19 Nov 2013 05:36:47 -0500 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1384857406; bh=9FQGdJnwd1/DmJ//IWE2M5toVISzyT+aiTnSxmq2g9I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; b=phJtGC96+13 2Rcjr180vVkV80bp3RjWzX4V/a5yaDsNC3gJCwGVcJZWA98uldqsm4qMug1cHfnOrp7 xb59E5uEOPg10kdlVFPlHr4Y7Nd++eJfJlTeOcqn85HAaqrziYaTvlXX0dXhkaRuqJR DISufwbfxcDTgAjt6O+rnFWaBM= Received: from mail.skyhub.de ([127.0.0.1]) by localhost (door.skyhub.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id MdYLfHSqqAHL; Tue, 19 Nov 2013 11:36:46 +0100 (CET) Received: from liondog.tnic (p54B4689E.dip0.t-ipconnect.de [84.180.104.158]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 27BE91DA274; Tue, 19 Nov 2013 11:36:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1384857406; bh=9FQGdJnwd1/DmJ//IWE2M5toVISzyT+aiTnSxmq2g9I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type:Content-Transfer-Encoding; b=phJtGC96+13 2Rcjr180vVkV80bp3RjWzX4V/a5yaDsNC3gJCwGVcJZWA98uldqsm4qMug1cHfnOrp7 xb59E5uEOPg10kdlVFPlHr4Y7Nd++eJfJlTeOcqn85HAaqrziYaTvlXX0dXhkaRuqJR DISufwbfxcDTgAjt6O+rnFWaBM= Received: by liondog.tnic (Postfix, from userid 1000) id 82446107160; Tue, 19 Nov 2013 11:36:43 +0100 (CET) From: Borislav Petkov To: LKML Cc: "John W. Linville" , Borislav Petkov , Arend van Spriel , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Subject: [PATCH] brcmsmac: Fix build dep on LEDS_CLASS Date: Tue, 19 Nov 2013 11:36:42 +0100 Message-Id: <1384857402-4138-1-git-send-email-bp@alien8.de> X-Mailer: git-send-email 1.8.4 In-Reply-To: <528B2B2A.2030504@broadcom.com> References: <528B2B2A.2030504@broadcom.com> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Borislav Petkov When building randconfigs with CONFIG_BCMA_DRIVER_GPIO=y, I get drivers/built-in.o: In function `brcms_led_unregister': (.text+0x351aca): undefined reference to `led_classdev_unregister' drivers/built-in.o: In function `brcms_led_register': (.text+0x351c65): undefined reference to `led_classdev_register' during final linking stage because brcmsmac/led.c needs LEDS_CLASS for registering/deregistering the led device. Select the required symbols. Cc: Arend van Spriel Cc: "Rafa? Mi?ecki" Cc: Signed-off-by: Borislav Petkov --- drivers/net/wireless/brcm80211/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/brcm80211/Kconfig b/drivers/net/wireless/brcm80211/Kconfig index b00a7e92225f..54e36fcb3954 100644 --- a/drivers/net/wireless/brcm80211/Kconfig +++ b/drivers/net/wireless/brcm80211/Kconfig @@ -5,6 +5,8 @@ config BRCMSMAC tristate "Broadcom IEEE802.11n PCIe SoftMAC WLAN driver" depends on MAC80211 depends on BCMA + select NEW_LEDS if BCMA_DRIVER_GPIO + select LEDS_CLASS if BCMA_DRIVER_GPIO select BRCMUTIL select FW_LOADER select CRC_CCITT