From patchwork Tue Nov 19 20:52:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emmanuel Grumbach X-Patchwork-Id: 3204001 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B85BA9F753 for ; Tue, 19 Nov 2013 20:52:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EFB1E20528 for ; Tue, 19 Nov 2013 20:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E49FE201E4 for ; Tue, 19 Nov 2013 20:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228Ab3KSUw3 (ORCPT ); Tue, 19 Nov 2013 15:52:29 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:60489 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750812Ab3KSUwY (ORCPT ); Tue, 19 Nov 2013 15:52:24 -0500 Received: by mail-wi0-f179.google.com with SMTP id fb10so6111231wid.0 for ; Tue, 19 Nov 2013 12:52:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FJZ38nfFNaPQg/0ocBRK9pFgWnOAYrKuQiDm6Xiyh7g=; b=ETO1abvK0R+QuCzEbJW5RV+bo+i0yc0o7Ep+10/BC0xNYrEuF9PAoW3weKZnNqP0ov jPYtVoGfw1lYccCxIcJGfCe4gIbl6kcwoY3lkLJ2jGngSASJAa6iskHiB6pv+IHESJLN ki33akBcsSzQDnALHFMIOilHgsALpaRJSO1jozINJiPNNAP9yzVvV8hzE77II6U9lOgb TRf+dizx173I0iIuLiRftgR/1Tc1F3jWz9Goz3LWeuIE9jHz9IJlCrKXpIgQhxLBDioC w69bOt/NRzLKjqVsqgIAJV/ifOn8Xf48GJzYPkWHpV6JM+tgxKi0XPlM7nNuJJgmVQEy tEwQ== X-Received: by 10.180.39.238 with SMTP id s14mr22899646wik.60.1384894343698; Tue, 19 Nov 2013 12:52:23 -0800 (PST) Received: from localhost.localdomain (93-173-143-36.bb.netvision.net.il. [93.173.143.36]) by mx.google.com with ESMTPSA id je17sm9236772wic.4.2013.11.19.12.52.22 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 19 Nov 2013 12:52:23 -0800 (PST) From: Emmanuel Grumbach To: linux-wireless@vger.kernel.org Cc: Emmanuel Grumbach Subject: [PATCH 6/7] iwlwifi: mvm: don't WARN about unsuccessful time event Date: Tue, 19 Nov 2013 22:52:05 +0200 Message-Id: <1384894326-24676-6-git-send-email-egrumbach@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <528BCEDB.8010703@gmail.com> References: <528BCEDB.8010703@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Emmanuel Grumbach Time event notification can have a failure status even if the time event was scheduled: * in START notification, this can happen if the time event was scheduled later than the requested apply time. * in STOP notification, this can happen if the time event is truncated. Even if both happened, the offchannel packets sent during the remain on channel are very likely to have been sent. Hence, don't WARN when this happens, but rather print a discrete line in the kernel log. Signed-off-by: Emmanuel Grumbach Reviewed-by: Johannes Berg --- drivers/net/wireless/iwlwifi/mvm/time-event.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/iwlwifi/mvm/time-event.c b/drivers/net/wireless/iwlwifi/mvm/time-event.c index 33cf56f..95ce4b6 100644 --- a/drivers/net/wireless/iwlwifi/mvm/time-event.c +++ b/drivers/net/wireless/iwlwifi/mvm/time-event.c @@ -176,8 +176,11 @@ static void iwl_mvm_te_handle_notif(struct iwl_mvm *mvm, * P2P Device discoveribility, while there are other higher priority * events in the system). */ - if (WARN_ONCE(!le32_to_cpu(notif->status), - "Failed to schedule time event\n")) { + if (!le32_to_cpu(notif->status)) { + bool start = le32_to_cpu(notif->action) & + TE_V2_NOTIF_HOST_EVENT_START; + IWL_WARN(mvm, "Time Event %s notification failure\n", + start ? "start" : "end"); if (iwl_mvm_te_check_disconnect(mvm, te_data->vif, NULL)) { iwl_mvm_te_clear_data(mvm, te_data); return;