Message ID | 1388390871-3932-1-git-send-email-marek.puzyniak@tieto.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers | show |
On 2 January 2014 13:41, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: > > On Dec 30, 2013 4:08 PM, "Marek Puzyniak" <marek.puzyniak@tieto.com> wrote: >> >> Currently ath10k is not using STA KICKOUT firmware functionality. >> In order to avoid unwanted FW events this functionality should be >> disabled when not used. > > What are unwanted FW events? WMI_PEER_STA_KICKOUT_EVENT which indicates lack of activity from associated STA for specified period of time. > > ---- > Chun-Yeow Marek > >> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> >> --- >> drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/net/wireless/ath/ath10k/mac.c >> b/drivers/net/wireless/ath/ath10k/mac.c >> index 5b45f3a..93416ab 100644 >> --- a/drivers/net/wireless/ath/ath10k/mac.c >> +++ b/drivers/net/wireless/ath/ath10k/mac.c >> @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct >> ieee80211_hw *hw, >> } >> >> if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { >> + u32 param_id; >> + >> ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); >> if (ret) { >> ath10k_warn("Failed to create peer for AP: %d\n", >> ret); >> goto err_vdev_delete; >> } >> + >> + param_id = ar->wmi.pdev_param->sta_kickout_th; >> + >> + /* Disable STA KICKOUT functionality in FW */ >> + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); >> + if (ret) >> + ath10k_warn("Failed to disable STA KICKOUT\n"); >> } >> >> if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { >> -- >> 1.8.1.2 >> >> >> _______________________________________________ >> ath10k mailing list >> ath10k@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/ath10k -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Marek Do you mind to share which firmware that you are using? I have tried your patch and this is set accordingly in an the AP (set param 13). But once the associated STA is leaving, WMI_PEER_STA_KICKOUT_EVENTID is still received. [ 145.060000] ath10k: wmi pdev set param 13 value 0 ....... [ 148.560000] ath10k: wmi vdev id 0x0 set param 8 value 1 [ 148.560000] ath10k: wmi peer create vdev_id 0 peer_addr 04:f0:21:0c:a5:44 [ 148.560000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 [ 149.040000] ath10k: wmi event debug mesg len 44 [ 209.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 210.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID FYI, I am using firmware version 999.999.0.636 ethtool -i wlan0 driver: ath10k_pci firmware-version: 999.999.0.636 Thanks Regards, Chun-Yeow On Wed, Jan 8, 2014 at 6:40 PM, Marek Puzyniak <marek.puzyniak@tieto.com> wrote: > On 2 January 2014 13:41, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: >> >> On Dec 30, 2013 4:08 PM, "Marek Puzyniak" <marek.puzyniak@tieto.com> wrote: >>> >>> Currently ath10k is not using STA KICKOUT firmware functionality. >>> In order to avoid unwanted FW events this functionality should be >>> disabled when not used. >> >> What are unwanted FW events? > > WMI_PEER_STA_KICKOUT_EVENT which indicates lack of activity from > associated STA for specified period of time. > >> >> ---- >> Chun-Yeow > Marek >> >>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> >>> --- >>> drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c >>> b/drivers/net/wireless/ath/ath10k/mac.c >>> index 5b45f3a..93416ab 100644 >>> --- a/drivers/net/wireless/ath/ath10k/mac.c >>> +++ b/drivers/net/wireless/ath/ath10k/mac.c >>> @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct >>> ieee80211_hw *hw, >>> } >>> >>> if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { >>> + u32 param_id; >>> + >>> ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); >>> if (ret) { >>> ath10k_warn("Failed to create peer for AP: %d\n", >>> ret); >>> goto err_vdev_delete; >>> } >>> + >>> + param_id = ar->wmi.pdev_param->sta_kickout_th; >>> + >>> + /* Disable STA KICKOUT functionality in FW */ >>> + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); >>> + if (ret) >>> + ath10k_warn("Failed to disable STA KICKOUT\n"); >>> } >>> >>> if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { >>> -- >>> 1.8.1.2 >>> >>> >>> _______________________________________________ >>> ath10k mailing list >>> ath10k@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/ath10k -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Marek Puzyniak <marek.puzyniak@tieto.com> writes: > Currently ath10k is not using STA KICKOUT firmware functionality. > In order to avoid unwanted FW events this functionality should be > disabled when not used. > > Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> Thanks, applied. I did minor changes to the commit log based on the feedback: ath10k: disable STA kickout in FW Currently ath10k is not using STA KICKOUT firmware functionality. In order to avoid unwanted WMI_PEER_STA_KICKOUT_EVENT event this functionality should be disabled when not used. Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, > } > > if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { > + u32 param_id; > + Also I moved this to the beginning of the function.
On 9 January 2014 10:09, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: > Hi, Marek Hi, > > Do you mind to share which firmware that you are using? I am using FW from: https://github.com/kvalo/ath10k-firmware/blob/master/ap/firmware-2.bin_10.1.467-1 > I have tried your patch and this is set accordingly in an the AP (set > param 13). But once the associated STA is leaving, > WMI_PEER_STA_KICKOUT_EVENTID is still received. > > [ 145.060000] ath10k: wmi pdev set param 13 value 0 > ....... > [ 148.560000] ath10k: wmi vdev id 0x0 set param 8 value 1 > [ 148.560000] ath10k: wmi peer create vdev_id 0 peer_addr 04:f0:21:0c:a5:44 > [ 148.560000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 > [ 149.040000] ath10k: wmi event debug mesg len 44 > [ 209.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 210.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > > FYI, I am using firmware version 999.999.0.636 > > ethtool -i wlan0 > driver: ath10k_pci > firmware-version: 999.999.0.636 > > Thanks > > Regards, > Chun-Yeow Marek > > > On Wed, Jan 8, 2014 at 6:40 PM, Marek Puzyniak <marek.puzyniak@tieto.com> wrote: >> On 2 January 2014 13:41, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: >>> >>> On Dec 30, 2013 4:08 PM, "Marek Puzyniak" <marek.puzyniak@tieto.com> wrote: >>>> >>>> Currently ath10k is not using STA KICKOUT firmware functionality. >>>> In order to avoid unwanted FW events this functionality should be >>>> disabled when not used. >>> >>> What are unwanted FW events? >> >> WMI_PEER_STA_KICKOUT_EVENT which indicates lack of activity from >> associated STA for specified period of time. >> >>> >>> ---- >>> Chun-Yeow >> Marek >>> >>>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> >>>> --- >>>> drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c >>>> b/drivers/net/wireless/ath/ath10k/mac.c >>>> index 5b45f3a..93416ab 100644 >>>> --- a/drivers/net/wireless/ath/ath10k/mac.c >>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c >>>> @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct >>>> ieee80211_hw *hw, >>>> } >>>> >>>> if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { >>>> + u32 param_id; >>>> + >>>> ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); >>>> if (ret) { >>>> ath10k_warn("Failed to create peer for AP: %d\n", >>>> ret); >>>> goto err_vdev_delete; >>>> } >>>> + >>>> + param_id = ar->wmi.pdev_param->sta_kickout_th; >>>> + >>>> + /* Disable STA KICKOUT functionality in FW */ >>>> + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); >>>> + if (ret) >>>> + ath10k_warn("Failed to disable STA KICKOUT\n"); >>>> } >>>> >>>> if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { >>>> -- >>>> 1.8.1.2 >>>> >>>> >>>> _______________________________________________ >>>> ath10k mailing list >>>> ath10k@lists.infradead.org >>>> http://lists.infradead.org/mailman/listinfo/ath10k -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Unfortunately, I have tried your mentioned firmware, but I am still getting the WMI_PEER_STA_KICKOUT_EVENTID. [ 159.020000] ath10k: wmi pdev set param 13 value 0 ..... [ 181.380000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 [ 182.000000] ath10k: wmi event debug mesg len 44 [ 182.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 183.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 184.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 185.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 185.580000] ath10k: wmi mgmt tx skb 86845f00 len 176 ftype 00 stype 50 [ 185.580000] ath10k: wmi mgmt tx skb 86846180 len 176 ftype 00 stype 50 [ 186.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 187.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 188.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 189.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 190.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 191.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 192.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 193.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 194.050000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID [ 195.050000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID # ethtool -i wlan0 driver: ath10k_pci version: 3.3.8 firmware-version: 10.1.467-1 Am I miss out something? ---- Chun-Yeow On Mon, Jan 13, 2014 at 4:40 PM, Marek Puzyniak <marek.puzyniak@tieto.com> wrote: > On 9 January 2014 10:09, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: >> Hi, Marek > Hi, >> >> Do you mind to share which firmware that you are using? > > I am using FW from: > https://github.com/kvalo/ath10k-firmware/blob/master/ap/firmware-2.bin_10.1.467-1 > >> I have tried your patch and this is set accordingly in an the AP (set >> param 13). But once the associated STA is leaving, >> WMI_PEER_STA_KICKOUT_EVENTID is still received. >> >> [ 145.060000] ath10k: wmi pdev set param 13 value 0 >> ....... >> [ 148.560000] ath10k: wmi vdev id 0x0 set param 8 value 1 >> [ 148.560000] ath10k: wmi peer create vdev_id 0 peer_addr 04:f0:21:0c:a5:44 >> [ 148.560000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 >> [ 149.040000] ath10k: wmi event debug mesg len 44 >> [ 209.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID >> [ 210.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID >> >> FYI, I am using firmware version 999.999.0.636 >> >> ethtool -i wlan0 >> driver: ath10k_pci >> firmware-version: 999.999.0.636 >> >> Thanks >> >> Regards, >> Chun-Yeow > Marek >> >> >> On Wed, Jan 8, 2014 at 6:40 PM, Marek Puzyniak <marek.puzyniak@tieto.com> wrote: >>> On 2 January 2014 13:41, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: >>>> >>>> On Dec 30, 2013 4:08 PM, "Marek Puzyniak" <marek.puzyniak@tieto.com> wrote: >>>>> >>>>> Currently ath10k is not using STA KICKOUT firmware functionality. >>>>> In order to avoid unwanted FW events this functionality should be >>>>> disabled when not used. >>>> >>>> What are unwanted FW events? >>> >>> WMI_PEER_STA_KICKOUT_EVENT which indicates lack of activity from >>> associated STA for specified period of time. >>> >>>> >>>> ---- >>>> Chun-Yeow >>> Marek >>>> >>>>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> >>>>> --- >>>>> drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ >>>>> 1 file changed, 9 insertions(+) >>>>> >>>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c >>>>> b/drivers/net/wireless/ath/ath10k/mac.c >>>>> index 5b45f3a..93416ab 100644 >>>>> --- a/drivers/net/wireless/ath/ath10k/mac.c >>>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c >>>>> @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct >>>>> ieee80211_hw *hw, >>>>> } >>>>> >>>>> if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { >>>>> + u32 param_id; >>>>> + >>>>> ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); >>>>> if (ret) { >>>>> ath10k_warn("Failed to create peer for AP: %d\n", >>>>> ret); >>>>> goto err_vdev_delete; >>>>> } >>>>> + >>>>> + param_id = ar->wmi.pdev_param->sta_kickout_th; >>>>> + >>>>> + /* Disable STA KICKOUT functionality in FW */ >>>>> + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); >>>>> + if (ret) >>>>> + ath10k_warn("Failed to disable STA KICKOUT\n"); >>>>> } >>>>> >>>>> if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { >>>>> -- >>>>> 1.8.1.2 >>>>> >>>>> >>>>> _______________________________________________ >>>>> ath10k mailing list >>>>> ath10k@lists.infradead.org >>>>> http://lists.infradead.org/mailman/listinfo/ath10k -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 13 January 2014 10:51, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: > Unfortunately, I have tried your mentioned firmware, but I am still > getting the WMI_PEER_STA_KICKOUT_EVENTID. > > [ 159.020000] ath10k: wmi pdev set param 13 value 0 > ..... > [ 181.380000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 > [ 182.000000] ath10k: wmi event debug mesg len 44 > [ 182.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 183.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 184.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 185.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 185.580000] ath10k: wmi mgmt tx skb 86845f00 len 176 ftype 00 stype 50 > [ 185.580000] ath10k: wmi mgmt tx skb 86846180 len 176 ftype 00 stype 50 > [ 186.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 187.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 188.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 189.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 190.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 191.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 192.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 193.040000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 194.050000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > [ 195.050000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID > > # ethtool -i wlan0 > driver: ath10k_pci > version: 3.3.8 > firmware-version: 10.1.467-1 > > Am I miss out something? You are right there are still too much WMI_PEER_STA_KICKOUT_EVENTID events. Soon there will followup patch which will handle all cases. It looks like the first one covers only one situation when STA_KICKOUT event can be generated. > > ---- > Chun-Yeow Marek > > > On Mon, Jan 13, 2014 at 4:40 PM, Marek Puzyniak > <marek.puzyniak@tieto.com> wrote: >> On 9 January 2014 10:09, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: >>> Hi, Marek >> Hi, >>> >>> Do you mind to share which firmware that you are using? >> >> I am using FW from: >> https://github.com/kvalo/ath10k-firmware/blob/master/ap/firmware-2.bin_10.1.467-1 >> >>> I have tried your patch and this is set accordingly in an the AP (set >>> param 13). But once the associated STA is leaving, >>> WMI_PEER_STA_KICKOUT_EVENTID is still received. >>> >>> [ 145.060000] ath10k: wmi pdev set param 13 value 0 >>> ....... >>> [ 148.560000] ath10k: wmi vdev id 0x0 set param 8 value 1 >>> [ 148.560000] ath10k: wmi peer create vdev_id 0 peer_addr 04:f0:21:0c:a5:44 >>> [ 148.560000] ath10k: wmi peer assoc vdev 0 addr 04:f0:21:0c:a5:44 >>> [ 149.040000] ath10k: wmi event debug mesg len 44 >>> [ 209.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID >>> [ 210.090000] ath10k: WMI_PEER_STA_KICKOUT_EVENTID >>> >>> FYI, I am using firmware version 999.999.0.636 >>> >>> ethtool -i wlan0 >>> driver: ath10k_pci >>> firmware-version: 999.999.0.636 >>> >>> Thanks >>> >>> Regards, >>> Chun-Yeow >> Marek >>> >>> >>> On Wed, Jan 8, 2014 at 6:40 PM, Marek Puzyniak <marek.puzyniak@tieto.com> wrote: >>>> On 2 January 2014 13:41, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: >>>>> >>>>> On Dec 30, 2013 4:08 PM, "Marek Puzyniak" <marek.puzyniak@tieto.com> wrote: >>>>>> >>>>>> Currently ath10k is not using STA KICKOUT firmware functionality. >>>>>> In order to avoid unwanted FW events this functionality should be >>>>>> disabled when not used. >>>>> >>>>> What are unwanted FW events? >>>> >>>> WMI_PEER_STA_KICKOUT_EVENT which indicates lack of activity from >>>> associated STA for specified period of time. >>>> >>>>> >>>>> ---- >>>>> Chun-Yeow >>>> Marek >>>>> >>>>>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> >>>>>> --- >>>>>> drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ >>>>>> 1 file changed, 9 insertions(+) >>>>>> >>>>>> diff --git a/drivers/net/wireless/ath/ath10k/mac.c >>>>>> b/drivers/net/wireless/ath/ath10k/mac.c >>>>>> index 5b45f3a..93416ab 100644 >>>>>> --- a/drivers/net/wireless/ath/ath10k/mac.c >>>>>> +++ b/drivers/net/wireless/ath/ath10k/mac.c >>>>>> @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct >>>>>> ieee80211_hw *hw, >>>>>> } >>>>>> >>>>>> if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { >>>>>> + u32 param_id; >>>>>> + >>>>>> ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); >>>>>> if (ret) { >>>>>> ath10k_warn("Failed to create peer for AP: %d\n", >>>>>> ret); >>>>>> goto err_vdev_delete; >>>>>> } >>>>>> + >>>>>> + param_id = ar->wmi.pdev_param->sta_kickout_th; >>>>>> + >>>>>> + /* Disable STA KICKOUT functionality in FW */ >>>>>> + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); >>>>>> + if (ret) >>>>>> + ath10k_warn("Failed to disable STA KICKOUT\n"); >>>>>> } >>>>>> >>>>>> if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { >>>>>> -- >>>>>> 1.8.1.2 >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> ath10k mailing list >>>>>> ath10k@lists.infradead.org >>>>>> http://lists.infradead.org/mailman/listinfo/ath10k > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5b45f3a..93416ab 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2292,11 +2292,20 @@ static int ath10k_add_interface(struct ieee80211_hw *hw, } if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { + u32 param_id; + ret = ath10k_peer_create(ar, arvif->vdev_id, vif->addr); if (ret) { ath10k_warn("Failed to create peer for AP: %d\n", ret); goto err_vdev_delete; } + + param_id = ar->wmi.pdev_param->sta_kickout_th; + + /* Disable STA KICKOUT functionality in FW */ + ret = ath10k_wmi_pdev_set_param(ar, param_id, 0); + if (ret) + ath10k_warn("Failed to disable STA KICKOUT\n"); } if (arvif->vdev_type == WMI_VDEV_TYPE_STA) {
Currently ath10k is not using STA KICKOUT firmware functionality. In order to avoid unwanted FW events this functionality should be disabled when not used. Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com> --- drivers/net/wireless/ath/ath10k/mac.c | 9 +++++++++ 1 file changed, 9 insertions(+)