From patchwork Wed Feb 12 19:20:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Priestley X-Patchwork-Id: 3640191 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A522BBF13A for ; Wed, 12 Feb 2014 19:24:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CC34D201ED for ; Wed, 12 Feb 2014 19:24:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03B64201CE for ; Wed, 12 Feb 2014 19:24:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753187AbaBLTYq (ORCPT ); Wed, 12 Feb 2014 14:24:46 -0500 Received: from mail-we0-f180.google.com ([74.125.82.180]:41058 "EHLO mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641AbaBLTYp (ORCPT ); Wed, 12 Feb 2014 14:24:45 -0500 Received: by mail-we0-f180.google.com with SMTP id u57so6512190wes.11 for ; Wed, 12 Feb 2014 11:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:content-type:date:mime-version :content-transfer-encoding; bh=hABluUNYhMnqznNFhIYvbwwlE5QBQboXfjX3VLi8U2k=; b=dVB8AV1txp8zEneOwt7jEF3ERz1vgsjKCZs8T1u/K2coISdRswLTON2NbL+vPQF9L5 sdLvVPr27BWriZSdSERKINivLZIlHKrA80ZXIxHoV9lpT0a6rA8rB/eDyZnzAspbmwWS E6nOmUAXEAcP7GGDFlxsuO/a7EarZwEYRqpMyK83+/UAgCiw8vBzwBunFJnKNWs/reFr NU5UZyRlAqi+8E4SSCdZAdlDJAcWp4N5O9ALSXWpM25hdjwh1FjKcYz428Cp4NWJ24Gi LY3qaidosdohj0NAMkXG0AjNGI+DkU13oPbb2hk7Af28nswL17WvSkEv4Zp9UOn3dbi+ uhvw== X-Received: by 10.180.101.230 with SMTP id fj6mr3349496wib.27.1392233084255; Wed, 12 Feb 2014 11:24:44 -0800 (PST) Received: from [192.168.1.100] (188.28.137.166.threembb.co.uk. [188.28.137.166]) by mx.google.com with ESMTPSA id r1sm8015439wia.5.2014.02.12.11.24.36 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 12 Feb 2014 11:24:43 -0800 (PST) Message-ID: <1392232848.4053.6.camel@canaries32-MCP7A> Subject: [PATCH 2/3] staging: vt6656: device_set_multi: set filter off with MACvWriteMultiAddr From: Malcolm Priestley To: gregkh@linuxfoundation.org Cc: linux-wireless@vger.kernel.org Date: Wed, 12 Feb 2014 19:20:48 +0000 Mime-Version: 1.0 X-Mailer: Evolution 3.10.3-0ubuntu3 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP set u64 mc_filter to ~0x0 multi cast filter off and write MAC_REG_MAR0 using MACvWriteMultiAddr to replace pbyData. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6656/main_usb.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c index c5e9dee2..e682c9d 100644 --- a/drivers/staging/vt6656/main_usb.c +++ b/drivers/staging/vt6656/main_usb.c @@ -1354,7 +1354,6 @@ static void device_set_multi(struct net_device *dev) struct vnt_manager *pMgmt = &pDevice->vnt_mgmt; struct netdev_hw_addr *ha; u64 mc_filter = 0; - u8 pbyData[8] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; u8 byTmpMode = 0; int rc; @@ -1377,13 +1376,9 @@ static void device_set_multi(struct net_device *dev) } else if ((netdev_mc_count(dev) > pDevice->multicast_limit) || (dev->flags & IFF_ALLMULTI)) { - CONTROLnsRequestOut(pDevice, - MESSAGE_TYPE_WRITE, - MAC_REG_MAR0, - MESSAGE_REQUEST_MACREG, - 8, - pbyData - ); + mc_filter = ~0x0; + MACvWriteMultiAddr(pDevice, mc_filter); + pDevice->byRxMode |= (RCR_MULTICAST|RCR_BROADCAST); } else {