From patchwork Tue Feb 18 01:10:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrea Merello X-Patchwork-Id: 3666411 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 101009F1EE for ; Tue, 18 Feb 2014 01:10:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 351F1201F7 for ; Tue, 18 Feb 2014 01:10:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 942D820142 for ; Tue, 18 Feb 2014 01:10:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753216AbaBRBKh (ORCPT ); Mon, 17 Feb 2014 20:10:37 -0500 Received: from mail-ee0-f49.google.com ([74.125.83.49]:59846 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752394AbaBRBKg (ORCPT ); Mon, 17 Feb 2014 20:10:36 -0500 Received: by mail-ee0-f49.google.com with SMTP id d17so7466516eek.36 for ; Mon, 17 Feb 2014 17:10:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XPuSVHLAvBfB6f0EIK+iMiiDxFLqaMkvD2ONDqw+EiU=; b=GeydOFQxwzO42B58B8BOygivmMbUFfDA0tuslwy29ivxFIDjqsypCKIsJn+WfPMBmt hfYA3ibqlzweoaQoSyOvf8BFmcwg2sW9vh90yZ6u9ePr4drPgyrV3wQCFxpm5y6FWmiG aFmNMNvR1Sd+S6nBowG48OIN1hZM5wr5jV47udqJRNQ8fMHyY8JQ7TZhf8y6MGaUL0J9 bOfk6sLEneuWtlcNvPoaS2J54wAwTlVOar/CS6UuLDeHZB9/A0p+2LTE6GewN2yChelk 49QtSZXzbbpR+hNZvMB/WB4gX/ksRnMisB0konEeQRYpb1W11AhKybUBVJZVRer47Pb5 bQSA== X-Received: by 10.15.56.130 with SMTP id y2mr30568522eew.17.1392685835674; Mon, 17 Feb 2014 17:10:35 -0800 (PST) Received: from localhost.localdomain ([95.237.125.26]) by mx.google.com with ESMTPSA id j41sm63723093eeg.10.2014.02.17.17.10.33 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Feb 2014 17:10:34 -0800 (PST) From: Andrea Merello To: linville@tuxdriver.com Cc: linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net, bernhard@schiffner-limbach.de, dan.carpenter@oracle.com, liuhq11@mails.tsinghua.edu.cn, andrea merello Subject: [PATCH 2/7] rtl818x: pci_iomap() should pair with pci_iounmap() Date: Tue, 18 Feb 2014 02:10:41 +0100 Message-Id: <1392685846-10116-3-git-send-email-andrea.merello@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1392685846-10116-1-git-send-email-andrea.merello@gmail.com> References: <1392685846-10116-1-git-send-email-andrea.merello@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY,URIBL_BLACK autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: andrea merello Currently the driver uses pci_iomap() but iounmap() is called in the error path Change to use pci_iounmap() instead. Reported-by: Huqiu Liu Signed-off-by: Andrea Merello --- drivers/net/wireless/rtl818x/rtl8180/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rtl818x/rtl8180/dev.c b/drivers/net/wireless/rtl818x/rtl8180/dev.c index 470a1e3..bf59ff9 100644 --- a/drivers/net/wireless/rtl818x/rtl8180/dev.c +++ b/drivers/net/wireless/rtl818x/rtl8180/dev.c @@ -1137,7 +1137,7 @@ static int rtl8180_probe(struct pci_dev *pdev, return 0; err_iounmap: - iounmap(priv->map); + pci_iounmap(pdev, priv->map); err_free_dev: ieee80211_free_hw(dev);