From patchwork Thu Mar 20 18:52:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Wu X-Patchwork-Id: 3867411 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0845F9F39B for ; Thu, 20 Mar 2014 18:53:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3178B201FB for ; Thu, 20 Mar 2014 18:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CD25201FA for ; Thu, 20 Mar 2014 18:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759578AbaCTSww (ORCPT ); Thu, 20 Mar 2014 14:52:52 -0400 Received: from lekensteyn.nl ([178.21.112.251]:43202 "EHLO lekensteyn.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759551AbaCTSwv (ORCPT ); Thu, 20 Mar 2014 14:52:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lekensteyn.nl; s=s2048-2014-q1; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=RiR8SxEhkv0BrwPOeyoVbo9rT4kYq0I+mZ1qKOJDWxE=; b=0gEtWeSdvNC1X0K8fqcoqoK/cM8CiURps6qN7Bs3bI0Ye3gOhMGP5mLbcVWNodFnP8WdiwS9KLj83yqy2wAxsxXU26X4Zvr5DapLeqSPYU2UwscR55FQnwHsvSiBo1m0z7w/VGV+yz8TiqRkHZ8Y+pfRu7oeEzlVT3dl1BtAptPcYA83OQV2r497GO9HjUMJ5xThJcr1PHT1zwocMi511RvXjbzvv5fH1X8M5Dk/IIr8xoPlZx8IxrVdTt2oLXPFyKuQp/gyrRXHZtBRI9phu+O+196GqcNCeY45+vepj8n9X3dFzRGy++LCQ2u3uumjwYIHCSsHF+FS1mnd8L76EQ==; Received: from ip4da018ae.direct-adsl.nl ([77.160.24.174] helo=localhost.localdomain) by lekensteyn.nl with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA256:128) (Exim 4.80) (envelope-from ) id 1WQi4r-0000q2-8d; Thu, 20 Mar 2014 19:52:29 +0100 From: Peter Wu To: Larry Finger , John W Linville , Greg Kroah-Hartman Cc: Chaoming_Li , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, lekensteyn@gmail.com Subject: [PATCH 3/3] staging/rtl8821ae: remove unused allow_all_destaddr function Date: Thu, 20 Mar 2014 19:52:24 +0100 Message-Id: <1395341544-21464-4-git-send-email-peter@lekensteyn.nl> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1395341544-21464-1-git-send-email-peter@lekensteyn.nl> References: <1395341544-21464-1-git-send-email-peter@lekensteyn.nl> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Similar to commit "rtlwifi: remove unused allow_all_destaddr functions", this patch removes an unused function. Unused as configure_filter takes care of setting/clearing RCR_AAP. Signed-off-by: Peter Wu --- drivers/staging/rtl8821ae/rtl8821ae/hw.c | 22 ---------------------- drivers/staging/rtl8821ae/rtl8821ae/hw.h | 3 --- drivers/staging/rtl8821ae/rtl8821ae/sw.c | 1 - drivers/staging/rtl8821ae/wifi.h | 2 -- 4 files changed, 28 deletions(-) diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.c b/drivers/staging/rtl8821ae/rtl8821ae/hw.c index e4dbf05..8ae4fae 100644 --- a/drivers/staging/rtl8821ae/rtl8821ae/hw.c +++ b/drivers/staging/rtl8821ae/rtl8821ae/hw.c @@ -3323,25 +3323,3 @@ void rtl8821ae_suspend(struct ieee80211_hw *hw) void rtl8821ae_resume(struct ieee80211_hw *hw) { } - -/* Turn on AAP (RCR:bit 0) for promicuous mode. */ -void rtl8821ae_allow_all_destaddr(struct ieee80211_hw *hw, - bool allow_all_da, bool write_into_reg) -{ - struct rtl_priv *rtlpriv = rtl_priv(hw); - struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); - - if (allow_all_da) /* Set BIT0 */ - rtlpci->receive_config |= RCR_AAP; - else /* Clear BIT0 */ - rtlpci->receive_config &= ~RCR_AAP; - - if(write_into_reg) - rtl_write_dword(rtlpriv, REG_RCR, rtlpci->receive_config); - - - RT_TRACE(COMP_TURBO | COMP_INIT, DBG_LOUD, - ("receive_config=0x%08X, write_into_reg=%d\n", - rtlpci->receive_config, write_into_reg )); -} - diff --git a/drivers/staging/rtl8821ae/rtl8821ae/hw.h b/drivers/staging/rtl8821ae/rtl8821ae/hw.h index 4fb6bf0..f1d2949 100644 --- a/drivers/staging/rtl8821ae/rtl8821ae/hw.h +++ b/drivers/staging/rtl8821ae/rtl8821ae/hw.h @@ -67,9 +67,6 @@ void rtl8821ae_bt_reg_init(struct ieee80211_hw* hw); void rtl8821ae_bt_hw_init(struct ieee80211_hw* hw); void rtl8821ae_suspend(struct ieee80211_hw *hw); void rtl8821ae_resume(struct ieee80211_hw *hw); -void rtl8821ae_allow_all_destaddr(struct ieee80211_hw *hw, - bool allow_all_da, - bool write_into_reg); void _rtl8821ae_stop_tx_beacon(struct ieee80211_hw *hw); void _rtl8821ae_resume_tx_beacon(struct ieee80211_hw *hw); #endif diff --git a/drivers/staging/rtl8821ae/rtl8821ae/sw.c b/drivers/staging/rtl8821ae/rtl8821ae/sw.c index 85a3474..25a8114 100644 --- a/drivers/staging/rtl8821ae/rtl8821ae/sw.c +++ b/drivers/staging/rtl8821ae/rtl8821ae/sw.c @@ -298,7 +298,6 @@ struct rtl_hal_ops rtl8821ae_hal_ops = { .enable_hw_sec = rtl8821ae_enable_hw_security_config, .set_key = rtl8821ae_set_key, .init_sw_leds = rtl8821ae_init_sw_leds, - .allow_all_destaddr = rtl8821ae_allow_all_destaddr, .get_bbreg = rtl8821ae_phy_query_bb_reg, .set_bbreg = rtl8821ae_phy_set_bb_reg, .get_rfreg = rtl8821ae_phy_query_rf_reg, diff --git a/drivers/staging/rtl8821ae/wifi.h b/drivers/staging/rtl8821ae/wifi.h index cfe88a1..871ff51 100644 --- a/drivers/staging/rtl8821ae/wifi.h +++ b/drivers/staging/rtl8821ae/wifi.h @@ -1840,8 +1840,6 @@ struct rtl_hal_ops { u32 regaddr, u32 bitmask); void (*set_rfreg) (struct ieee80211_hw * hw, enum radio_path rfpath, u32 regaddr, u32 bitmask, u32 data); - void (*allow_all_destaddr)(struct ieee80211_hw *hw, - bool allow_all_da, bool write_into_reg); void (*linked_set_reg) (struct ieee80211_hw * hw); void (*check_switch_to_dmdp) (struct ieee80211_hw * hw); void (*dualmac_easy_concurrent) (struct ieee80211_hw *hw);