From patchwork Sun Mar 30 21:31:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denys Vlasenko X-Patchwork-Id: 3910211 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0D1FE9F1E1 for ; Sun, 30 Mar 2014 21:32:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4B96320256 for ; Sun, 30 Mar 2014 21:32:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A11020253 for ; Sun, 30 Mar 2014 21:32:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752803AbaC3Vbz (ORCPT ); Sun, 30 Mar 2014 17:31:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33773 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752663AbaC3Vby (ORCPT ); Sun, 30 Mar 2014 17:31:54 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2ULVkU1026243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 30 Mar 2014 17:31:46 -0400 Received: from localhost.localdomain (vpn1-7-171.ams2.redhat.com [10.36.7.171]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s2ULVRPO029556; Sun, 30 Mar 2014 17:31:44 -0400 From: Denys Vlasenko To: Franky Lin , Arend van Spriel , Hante Meuleman , "John W. Linville" , linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Cc: Denys Vlasenko Subject: [PATCH 3/4] brcm80211: deinline wlc_intstatus, save 429 bytes Date: Sun, 30 Mar 2014 23:31:18 +0200 Message-Id: <1396215079-7541-3-git-send-email-dvlasenk@redhat.com> In-Reply-To: <1396215079-7541-1-git-send-email-dvlasenk@redhat.com> References: <1396215079-7541-1-git-send-email-dvlasenk@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Automated script discovered that without forced inlining, gcc-4.7 generates smaller code for this function. There is no need to declare static functions inline anyway: nowadays gcc detects single-callsite static functions which benefit from inlining. In this case, function is large and has two callsites. Signed-off-by: Denys Vlasenko --- drivers/net/wireless/brcm80211/brcmsmac/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c index 9417cb5..fa7bc18 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c @@ -2539,7 +2539,7 @@ brcms_c_mute(struct brcms_c_info *wlc, bool mute_tx) * 0 if the interrupt is not for us, or we are in some special cases; * device interrupt status bits otherwise. */ -static inline u32 wlc_intstatus(struct brcms_c_info *wlc, bool in_isr) +static u32 wlc_intstatus(struct brcms_c_info *wlc, bool in_isr) { struct brcms_hardware *wlc_hw = wlc->hw; struct bcma_device *core = wlc_hw->d11core;