From patchwork Thu Apr 24 03:08:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Lee X-Patchwork-Id: 4045551 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 273A0BFF02 for ; Thu, 24 Apr 2014 03:09:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5B629201F2 for ; Thu, 24 Apr 2014 03:09:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D82E5201C0 for ; Thu, 24 Apr 2014 03:08:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbaDXDIx (ORCPT ); Wed, 23 Apr 2014 23:08:53 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:59428 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbaDXDIv (ORCPT ); Wed, 23 Apr 2014 23:08:51 -0400 Received: by mail-pd0-f171.google.com with SMTP id r10so1432669pdi.16 for ; Wed, 23 Apr 2014 20:08:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=c6DQafSv5Oqtywyv569hKbGnmNdU21dh7NzrDsGzEew=; b=Jze05TcFltjzPjLkziaqsDp4JVw8+OVeihVyvb5BP4XCHh2UwlT1+D1+IGlXgRmfxt mqLOtKtXj0sGw3+m4fSHLuS0I01AJD3XLtejUfO5Q0sRt0mOR7trCUADhOWD8eDk84uk yHrKfUisNDCqhOX0wNii+MkQj9DkG9P4YlE/+RTr9kg98P97jpc7NuunjbFMHYx8+DGj tih8d65Vq/rTj2GvhezuIxtVo4tv570oKj8avkEo+zJ57oHyQTkkHMVEuao9AdClqdMb hbKq4ioNzrzWuhQqhrD0wR+ia7xrDXoRu5rdBPOnfxJaIbrpGmnA7C4dMvCRLSRcF4Tz arIw== X-Gm-Message-State: ALoCoQmnv062GZ6RcyB7dFAZk4D2e5gk6Gupse42W+2i1iSfi6uahlqYqN8NMoqeooVDo0fzM7RO X-Received: by 10.66.250.161 with SMTP id zd1mr2072734pac.136.1398308931364; Wed, 23 Apr 2014 20:08:51 -0700 (PDT) Received: from localhost ([116.213.97.190]) by mx.google.com with ESMTPSA id xo9sm13339145pab.18.2014.04.23.20.08.48 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 23 Apr 2014 20:08:50 -0700 (PDT) From: Adam Lee To: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, Larry Finger , "John W. Linville" Subject: [PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode" Date: Thu, 24 Apr 2014 11:08:43 +0800 Message-Id: <1398308924-15312-1-git-send-email-adam.lee@canonical.com> X-Mailer: git-send-email 2.0.0.rc0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 2a54eb5e1476426ee639bbfbe179b52342a0d82c. 94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode support, which seemed safe enough with RTL8188EE and RTL8723BE as RealTek's testing results, but some users reported their RTL8188EE modules could not connect to any wireless network after the MSI mode was enabled by Ubuntu 14.04. So, let's fallback to pin-based mode until rtlwifi's MSI support get good compatibility. BugLink: https://bugs.launchpad.net/bugs/1310512 Signed-off-by: Adam Lee --- drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c index 1b4101b..347af1e 100644 --- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c @@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw) u8 tid; rtl8188ee_bt_reg_init(hw); - rtlpci->msi_support = true; rtlpriv->dm.dm_initialgain_enable = 1; rtlpriv->dm.dm_flag = 0;