From patchwork Sat May 3 06:15:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Coelho X-Patchwork-Id: 4105721 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B13CC9F1E1 for ; Sat, 3 May 2014 06:15:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EC48020383 for ; Sat, 3 May 2014 06:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1276120380 for ; Sat, 3 May 2014 06:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751050AbaECGPh (ORCPT ); Sat, 3 May 2014 02:15:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:46180 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbaECGPh (ORCPT ); Sat, 3 May 2014 02:15:37 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 02 May 2014 23:10:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,976,1389772800"; d="scan'208";a="533990615" Received: from kcthilak-mobl.gar.corp.intel.com (HELO [10.252.121.144]) ([10.252.121.144]) by orsmga002.jf.intel.com with ESMTP; 02 May 2014 23:15:34 -0700 Message-ID: <1399097729.5873.2.camel@dubbel> Subject: Re: [PATCH] cfg80211/mac80211: Fix warning on make xmldocs caused by cfg80211.h From: Luciano Coelho To: Masanari Iida Cc: johannes.berg@intel.com, netdev@vger.kernel.org, linux-wireless@vger.kernel.org Date: Sat, 03 May 2014 09:15:29 +0300 In-Reply-To: <1399041597-27409-2-git-send-email-standby24x7@gmail.com> References: <1399041597-27409-1-git-send-email-standby24x7@gmail.com> <1399041597-27409-2-git-send-email-standby24x7@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Mailer: Evolution 3.8.5-2+b3 Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Fri, 2014-05-02 at 23:39 +0900, Masanari Iida wrote: > Following error messages caused by wrong description. > > Warning(include/net/cfg80211.h:461): No description found > for parameter 'nl80211_iftype' > > Change "iftype" to "nl80211_iftype" fix the errors. > > Signed-off-by: Masanari Iida > --- > include/net/cfg80211.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h > index 7eae46c..695c562 100644 > --- a/include/net/cfg80211.h > +++ b/include/net/cfg80211.h > @@ -452,7 +452,7 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy, > * cfg80211_chandef_dfs_required - checks if radar detection is required > * @wiphy: the wiphy to validate against > * @chandef: the channel definition to check > - * @iftype: the interface type as specified in &enum nl80211_iftype > + * @nl80211_iftype: the interface type as specified in &enum nl80211_iftype > * Returns: > * 1 if radar detection is required, 0 if it is not, < 0 on error > */ A better way to fix this would be to add "iftype" to the function prototype, since we don't usually use nameless arguments: Tested-by: Masanari Iida --- Cheers, Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 43c674e..f9e7373 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -458,7 +458,7 @@ bool cfg80211_chandef_usable(struct wiphy *wiphy, */ int cfg80211_chandef_dfs_required(struct wiphy *wiphy, const struct cfg80211_chan_def *chandef, - enum nl80211_iftype); + enum nl80211_iftype iftype); /** * ieee80211_chandef_rate_flags - returns rate flags for a channel