From patchwork Sat Jun 7 14:30:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 4315571 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6F66C9F170 for ; Sat, 7 Jun 2014 14:29:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9FC5D201BA for ; Sat, 7 Jun 2014 14:29:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A48402018B for ; Sat, 7 Jun 2014 14:29:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752854AbaFGO32 (ORCPT ); Sat, 7 Jun 2014 10:29:28 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:55800 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752769AbaFGO31 (ORCPT ); Sat, 7 Jun 2014 10:29:27 -0400 Received: by mail-la0-f47.google.com with SMTP id pn19so2176019lab.20 for ; Sat, 07 Jun 2014 07:29:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vSOaNbQKb93QXAAkVN658WsMzpZgXbBdjiOTQxJW9pM=; b=Zj4sPeJuFPG3j7ufPrscAjXXeR6fcQOa8ccRV9kkZJQ5SHOHRF3dQPIBNNQ26tGpqk vD04F+ZWTJUqNeeAFYsS3bAmtk3n7qMBDDFTBv7a8/pA9Lq9rwDoawHK0jChQA95LY7G eaAN+pJxYcKhOHVz0/jZ5ddfx7bRaM+VYT94TnScmn6DlTc22/xLAXCk7uL3h7ROBS+a Df3uSubB2R6um3kv9/nAxp5E0t2/Eqp1Lne36rrmm7gI/eHdROMPK9cUaVUl9eO/QiNr VZeKZYF8eqIEkzqMW8U7lvZ9B/oqYVfq1RmDr1cXohQnwW8LwPy4WBVcwBEN2pdncQJ2 NYiA== X-Gm-Message-State: ALoCoQlam0FnB/e4sdi/denqlR23+zegG1184wcloxLeCHT1GChfBeRYKsL0U6q+8qZQTgzzFxDw X-Received: by 10.152.29.200 with SMTP id m8mr2111896lah.49.1402151364817; Sat, 07 Jun 2014 07:29:24 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id k16sm12111217lbo.37.2014.06.07.07.29.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jun 2014 07:29:23 -0700 (PDT) From: Rickard Strandqvist To: Larry Finger , Chaoming Li Cc: Rickard Strandqvist , "John W. Linville" , Peter Wu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: wireless: rtlwifi: rtl8192de: hw.c: Cleaning up conjunction always evaluates to false Date: Sat, 7 Jun 2014 16:30:19 +0200 Message-Id: <1402151419-18296-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Expression '(X & 0xfc) == 0x3' is always false I chose to remove this code, because it will not make any difference. But obviously it is rather a properly designed if statement that is needed. This was partly found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c index 2b08671..a1520d5 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c @@ -1128,10 +1128,7 @@ static int _rtl92de_set_media_status(struct ieee80211_hw *hw, } rtl_write_byte(rtlpriv, REG_CR + 2, bt_msr); rtlpriv->cfg->ops->led_control(hw, ledaction); - if ((bt_msr & 0xfc) == MSR_AP) - rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00); - else - rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66); + rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66); return 0; }