From patchwork Wed Jun 25 10:17:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jahnavi Meher X-Patchwork-Id: 4419081 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 78FFEBEEAA for ; Wed, 25 Jun 2014 10:18:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 55B292038F for ; Wed, 25 Jun 2014 10:17:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A25A320381 for ; Wed, 25 Jun 2014 10:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbaFYKRy (ORCPT ); Wed, 25 Jun 2014 06:17:54 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:45597 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbaFYKRx (ORCPT ); Wed, 25 Jun 2014 06:17:53 -0400 Received: by mail-pa0-f51.google.com with SMTP id hz1so1534177pad.38 for ; Wed, 25 Jun 2014 03:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=EVIMyqU//6K2hninlijw1sa++yDAL3FKL9l8LbU+KJY=; b=jADtidNCZlU6lwMSkdwcLUeFmgI1wRYiUe1v8W8tLGVUYcw0LPPjLit/V8sOHrnAbX zkNt9TaDQsjcXmqNdKgVbq6UoLcQvW1tHUIvHZOIALpo9/P7I4CjbhWij0B4a/Kf7ulz tW8OjMCRtCJW5Djd5MhlDUVmnurHReTQg5bGoyqyqk+t75Xy7D6/C8wluTHJ/bQSB72E l5mgjDn5balnuiK3HQjbQn8SFlO5PXoYVbYSXme2VXvEG/6q0EY3HArZQPTXqzsBKbmG x1c9uJJvvPKXFcflXy3MyGr6vBHAvGbJUtdabZ1LcWRkdnI4av5dyS5kqxryAEbtIpyE oCEA== X-Received: by 10.66.138.48 with SMTP id qn16mr10009746pab.152.1403691473527; Wed, 25 Jun 2014 03:17:53 -0700 (PDT) Received: from localhost.localdomain ([115.248.87.14]) by mx.google.com with ESMTPSA id oz7sm4523086pbc.41.2014.06.25.03.17.52 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 25 Jun 2014 03:17:53 -0700 (PDT) From: Jahnavi Meher To: Subject: [PATCH 1/2] rsi: Fixed errors and warnings reported by static code analyzers. Date: Wed, 25 Jun 2014 15:47:45 +0530 Message-Id: <1403691465-4968-1-git-send-email-jahnavi.meher@gmail.com> X-Mailer: git-send-email 1.7.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixed a potential buffer overflow in 'rsi_rates' and a sparse warning related to difference in endianness in rsi_91x_mgmt.c. Signed-off-by: Jahnavi Meher --- drivers/net/wireless/rsi/rsi_91x_mgmt.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c index 83abe58..8d110fd 100644 --- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c +++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c @@ -1055,7 +1055,8 @@ static int rsi_send_auto_rate_request(struct rsi_common *common) rate_table_offset = 4; } - for (ii = 0, jj = 0; ii < ARRAY_SIZE(rsi_rates); ii++) { + for (ii = 0, jj = 0; + ii < (ARRAY_SIZE(rsi_rates) - rate_table_offset); ii++) { if (rate_bitmap & BIT(ii)) { selected_rates[jj++] = (rsi_rates[ii + rate_table_offset].bitrate / 5); @@ -1103,7 +1104,7 @@ static int rsi_send_auto_rate_request(struct rsi_common *common) } for (; ii < RSI_TBL_SZ; ii++) - auto_rate->supported_rates[ii] = min_rate; + auto_rate->supported_rates[ii] = cpu_to_le16(min_rate); auto_rate->num_supported_rates = cpu_to_le16(num_supported_rates * 2); auto_rate->moderate_rate_inx = cpu_to_le16(num_supported_rates / 2);