From patchwork Tue Aug 5 20:49:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 4682261 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 148F7C0338 for ; Tue, 5 Aug 2014 20:49:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4C657201CD for ; Tue, 5 Aug 2014 20:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41EA9201BC for ; Tue, 5 Aug 2014 20:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753696AbaHEUtj (ORCPT ); Tue, 5 Aug 2014 16:49:39 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:36221 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbaHEUti (ORCPT ); Tue, 5 Aug 2014 16:49:38 -0400 Received: from ben-dt2.candelatech.com. (firewall.candelatech.com [70.89.124.249]) by mail2.candelatech.com (Postfix) with ESMTP id E0D1C40B7F0; Tue, 5 Aug 2014 13:49:37 -0700 (PDT) From: greearb@candelatech.com To: linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org, Ben Greear Subject: [PATCH] ath10k: improve logging in firmware crash routine. Date: Tue, 5 Aug 2014 13:49:32 -0700 Message-Id: <1407271772-14874-1-git-send-email-greearb@candelatech.com> X-Mailer: git-send-email 1.7.11.7 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Ben Greear Only print error message upon failure, and print more details in case it does find an error. Signed-off-by: Ben Greear --- This is on top of the firmware crash reporting patches, not sure it would apply clean until those get in. drivers/net/wireless/ath/ath10k/pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 24688b7..085c0c8 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -929,12 +929,11 @@ static void ath10k_pci_hif_dump_area(struct ath10k *ar) ret = ath10k_pci_diag_read_mem(ar, host_addr, ®_dump_area, sizeof(u32)); if (ret) { - ath10k_err("failed to read FW dump area address: %d\n", ret); + ath10k_err("failed to read FW dump area address: %d (hostaddr 0x%08X hi-failure-state 0x%08lX)\n", + ret, host_addr, HI_ITEM(hi_failure_state)); goto exit; } - ath10k_err("target register Dump Location: 0x%08X\n", reg_dump_area); - ret = ath10k_pci_diag_read_mem(ar, reg_dump_area, ®_dump_values[0], REG_DUMP_COUNT_QCA988X * sizeof(u32));