From patchwork Mon Oct 27 10:56:06 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 5159311 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8F11FC11AC for ; Mon, 27 Oct 2014 10:56:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A8DFE20256 for ; Mon, 27 Oct 2014 10:56:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B79072024F for ; Mon, 27 Oct 2014 10:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751363AbaJ0K4M (ORCPT ); Mon, 27 Oct 2014 06:56:12 -0400 Received: from static.88-198-24-112.clients.your-server.de ([88.198.24.112]:41213 "EHLO nbd.name" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750967AbaJ0K4L (ORCPT ); Mon, 27 Oct 2014 06:56:11 -0400 Received: by nf.local (Postfix, from userid 501) id D2878A93B457; Mon, 27 Oct 2014 11:56:06 +0100 (CET) From: Felix Fietkau To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net Subject: [PATCH 3.18] mac80211: flush keys for AP mode on ieee80211_do_stop Date: Mon, 27 Oct 2014 11:56:06 +0100 Message-Id: <1414407366-52891-1-git-send-email-nbd@openwrt.org> X-Mailer: git-send-email 2.1.2 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Userspace can add keys to an AP mode interface before start_ap has been called. If there have been no calls to start_ap/stop_ap in the mean time, the keys will still be around when the interface is brought down. Signed-off-by: Felix Fietkau --- net/mac80211/iface.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index af23722..b8efd5b 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -931,9 +931,6 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, * another CPU. */ ieee80211_free_keys(sdata, true); - - /* fall through */ - case NL80211_IFTYPE_AP: skb_queue_purge(&sdata->skb_queue); }