From patchwork Tue Oct 28 09:32:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5173911 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E7026C11AD for ; Tue, 28 Oct 2014 09:44:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 16F3E202F8 for ; Tue, 28 Oct 2014 09:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31937202B8 for ; Tue, 28 Oct 2014 09:44:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753394AbaJ1JoK (ORCPT ); Tue, 28 Oct 2014 05:44:10 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:53633 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753491AbaJ1JoI (ORCPT ); Tue, 28 Oct 2014 05:44:08 -0400 Received: by mail-la0-f52.google.com with SMTP id hz20so235906lab.39 for ; Tue, 28 Oct 2014 02:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TWr1bT8m2PtlcjMoA2upqWpb5S96nkRbMZvrigGTRsk=; b=0Do92UoZwl1fvCBegm/cLQvENWc+JIja73Uw3KCPwFV6ieZIBKbLasoLtAjlQ7AwG9 16m2ccj1MqYuzM+t2dK4Sfq+IWciFDUYBb30LRFNRmncX4rPSxkna7HiUuhTvvNhV2jN 2d0YHGp4BWdVJAKcbCWA0sIz6ylszHSqhv2u0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TWr1bT8m2PtlcjMoA2upqWpb5S96nkRbMZvrigGTRsk=; b=QdWJLvlm9BEe9N5FVth9srMVJBGfItjcfDXafzEJUWyT1+vpDs8eGzL2Bu4ktl5J0U sGiFEme8MpCj7L5iNsHgewHfKeQfUDGh3cgDKXZDX6GmL3/Zpke0I3TR4NopRYLGBr7w t+23j/YQoH+fRJOtx+6azT+JfmMs3qgrqjLTsGmJD0/IwW1R1nLuDHFE+Arnz1gRxqp/ eiZbvn0BKdqPo9vaXoymHbf9yr65+qJP+SaQbc/i/d0/MPrSwZ/0455mDn26jc8wbBIw 8f6PBmY4V+iU4+lvzBHZurIMCdfakWMJ8key+Ykf5jALnvtDTBchIIaTufJFAJKG193o LyBA== X-Gm-Message-State: ALoCoQkIVZFIRwcyZksmNgS0dSijTobUj6OmxjQEI00+e1DKrtmZCd/MT1vCNBjq+11vTeB/B3Qb1rBu2f0J2dZA03vzdFXNGVelAs36XikMTmPXGoflvBSot9GfA7MB/sFHWm+MLKxG X-Received: by 10.152.8.136 with SMTP id r8mr2461168laa.91.1414489446167; Tue, 28 Oct 2014 02:44:06 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id xh2sm392052lbb.7.2014.10.28.02.44.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Oct 2014 02:44:05 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH v3 4/4] ath10k: don't reset chip on power_down Date: Tue, 28 Oct 2014 10:32:08 +0100 Message-Id: <1414488728-31489-5-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1414488728-31489-1-git-send-email-michal.kazior@tieto.com> References: <1414488728-31489-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently hif_power_up performs effectively a reset and hif_stop resets the chip as well so there's no point in resetting here. Signed-off-by: Michal Kazior --- Notes: v2: * this patch replaces `replace power up/down with reset callback` [Kalle] drivers/net/wireless/ath/ath10k/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 117e14d..63f374ed 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1919,7 +1919,9 @@ static void ath10k_pci_hif_power_down(struct ath10k *ar) { ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot hif power down\n"); - ath10k_pci_warm_reset(ar); + /* Currently hif_power_up performs effectively a reset and hif_stop + * resets the chip as well so there's no point in resetting here. + */ } #ifdef CONFIG_PM