From patchwork Wed Oct 29 11:50:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emmanuel Grumbach X-Patchwork-Id: 5186671 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B3DD59F30B for ; Wed, 29 Oct 2014 11:51:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBF0E20158 for ; Wed, 29 Oct 2014 11:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A43320154 for ; Wed, 29 Oct 2014 11:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932649AbaJ2LvB (ORCPT ); Wed, 29 Oct 2014 07:51:01 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:43134 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932384AbaJ2LvA (ORCPT ); Wed, 29 Oct 2014 07:51:00 -0400 Received: by mail-wi0-f169.google.com with SMTP id n3so1308665wiv.2 for ; Wed, 29 Oct 2014 04:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+OG6Rpj6U2rPQEBQJIDh3mNPELzFLgFQTjyy+p2YSag=; b=cAvOxO5MSU62iUa4oXAZwMWXXgdeIdwrHQMgQAQ84uZd96k1LSRI/jDRVzwROrGKv+ pZyPPybbEs/Ao6C7BhpAq7yAbf8A7UJsGPgfKWH2+qdOsEEnGL/Nnr+qp8TK581Ni0X8 dY3dk+P2a3SiEfYjgwTnyeL7wOTjM0BeykYZmzlQ7/QPUP7sUfqbeiJCSoAWeOLAWJ0D fE5r31PduWvmObEgfCwF9Jvffb8JY4z79bu4hDOalOhfP8ILwFlkosf8jQXVzb2T3qCj ji6i676T+ja9gpwd8ZFqL2Eo2QX9YP9I7tDfqKkZMnv2mWuxJeolhxIkZNpnaYIY6Nie NX9g== X-Received: by 10.194.190.130 with SMTP id gq2mr11812533wjc.18.1414583459124; Wed, 29 Oct 2014 04:50:59 -0700 (PDT) Received: from localhost.localdomain (109-186-77-39.bb.netvision.net.il. [109.186.77.39]) by mx.google.com with ESMTPSA id el4sm18476402wid.11.2014.10.29.04.50.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Oct 2014 04:50:58 -0700 (PDT) From: Emmanuel Grumbach To: linux-wireless@vger.kernel.org Cc: Emmanuel Grumbach Subject: [PATCH 02/25] iwlwifi: mvm: remove unneeded NULL pointer check Date: Wed, 29 Oct 2014 13:50:23 +0200 Message-Id: <1414583446-11032-2-git-send-email-egrumbach@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Emmanuel Grumbach mac80211 will never call rate_control_tx_status with a NULL pointer for sta. Remove the superfluous check. This check misled smatch. Signed-off-by: Emmanuel Grumbach --- drivers/net/wireless/iwlwifi/mvm/rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/iwlwifi/mvm/rs.c b/drivers/net/wireless/iwlwifi/mvm/rs.c index 0d836fe..66e971a 100644 --- a/drivers/net/wireless/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/iwlwifi/mvm/rs.c @@ -1225,7 +1225,7 @@ void iwl_mvm_rs_tx_status(struct iwl_mvm *mvm, struct ieee80211_sta *sta, IWL_DEBUG_RATE(mvm, "reduced txpower: %d\n", reduced_txp); done: /* See if there's a better rate or modulation mode to try. */ - if (sta && sta->supp_rates[info->band]) + if (sta->supp_rates[info->band]) rs_rate_scale_perform(mvm, sta, lq_sta, tid); }