From patchwork Wed Nov 12 12:08:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jukka Rissanen X-Patchwork-Id: 5288941 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3AAE69F440 for ; Wed, 12 Nov 2014 12:09:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3AE7B20165 for ; Wed, 12 Nov 2014 12:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E98372017E for ; Wed, 12 Nov 2014 12:09:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162AbaKLMJG (ORCPT ); Wed, 12 Nov 2014 07:09:06 -0500 Received: from mga01.intel.com ([192.55.52.88]:60814 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbaKLMJE (ORCPT ); Wed, 12 Nov 2014 07:09:04 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 12 Nov 2014 04:09:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,368,1413270000"; d="scan'208";a="630740612" Received: from jrissane-mobl.ger.corp.intel.com ([10.237.67.33]) by fmsmga002.fm.intel.com with ESMTP; 12 Nov 2014 04:09:02 -0800 From: Jukka Rissanen To: linux-wireless@vger.kernel.org Subject: [PATCH v3 2/2] nl80211: Stop scheduled scan if netlink client disappears Date: Wed, 12 Nov 2014 14:08:59 +0200 Message-Id: <1415794139-7124-3-git-send-email-jukka.rissanen@linux.intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1415794139-7124-1-git-send-email-jukka.rissanen@linux.intel.com> References: <1415794139-7124-1-git-send-email-jukka.rissanen@linux.intel.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP An attribute NL80211_ATTR_SOCKET_OWNER can be set by the scan initiator. If present, the attribute will cause the scan to be stopped if the client dies. Signed-off-by: Jukka Rissanen --- include/net/cfg80211.h | 2 ++ include/uapi/linux/nl80211.h | 3 +++ net/wireless/core.c | 10 +++++++++- net/wireless/nl80211.c | 34 ++++++++++++++++++++++++++++++++++ 4 files changed, 48 insertions(+), 1 deletion(-) diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index 220d5f5..84378bf 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -1512,6 +1512,8 @@ struct cfg80211_sched_scan_request { struct wiphy *wiphy; struct net_device *dev; unsigned long scan_start; + u32 owner_nlportid; + struct work_struct sched_scan_stop_wk; /* keep last */ struct ieee80211_channel *channels[0]; diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index 185f9c7..5038240 100644 --- a/include/uapi/linux/nl80211.h +++ b/include/uapi/linux/nl80211.h @@ -1640,6 +1640,9 @@ enum nl80211_commands { * @NL80211_ATTR_SOCKET_OWNER: Flag attribute, if set during interface * creation then the new interface will be owned by the netlink socket * that created it and will be destroyed when the socket is closed. + * If set during scheduled scan start then the new scan req will be + * owned by the netlink socket that created it and the scheduled scan will + * be stopped when the socket is closed. * * @NL80211_ATTR_TDLS_INITIATOR: flag attribute indicating the current end is * the TDLS link initiator. diff --git a/net/wireless/core.c b/net/wireless/core.c index a4d2792..88898d9 100644 --- a/net/wireless/core.c +++ b/net/wireless/core.c @@ -840,6 +840,8 @@ void __cfg80211_leave(struct cfg80211_registered_device *rdev, struct wireless_dev *wdev) { struct net_device *dev = wdev->netdev; + struct cfg80211_sched_scan_request *sched_scan_req = + rdev->sched_scan_req; ASSERT_RTNL(); ASSERT_WDEV_LOCK(wdev); @@ -850,8 +852,10 @@ void __cfg80211_leave(struct cfg80211_registered_device *rdev, break; case NL80211_IFTYPE_P2P_CLIENT: case NL80211_IFTYPE_STATION: - if (rdev->sched_scan_req && dev == rdev->sched_scan_req->dev) + if (sched_scan_req && dev == sched_scan_req->dev) { + cancel_work_sync(&sched_scan_req->sched_scan_stop_wk); __cfg80211_stop_sched_scan(rdev, false); + } #ifdef CONFIG_CFG80211_WEXT kfree(wdev->wext.ie); @@ -991,6 +995,10 @@ static int cfg80211_netdev_notifier_call(struct notifier_block *nb, if (WARN_ON(rdev->sched_scan_req && rdev->sched_scan_req->dev == wdev->netdev)) { + struct cfg80211_sched_scan_request *sched_scan_req = + rdev->sched_scan_req; + + cancel_work_sync(&sched_scan_req->sched_scan_stop_wk); __cfg80211_stop_sched_scan(rdev, false); } diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index df447c0..8fc500d 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5681,6 +5681,21 @@ static int nl80211_trigger_scan(struct sk_buff *skb, struct genl_info *info) return err; } +static void nl80211_sched_scan_stop_wk(struct work_struct *work) +{ + struct cfg80211_sched_scan_request *req; + struct cfg80211_registered_device *rdev; + + req = container_of(work, struct cfg80211_sched_scan_request, + sched_scan_stop_wk); + + rdev = wiphy_to_rdev(req->wiphy); + + rtnl_lock(); + __cfg80211_stop_sched_scan(rdev, false); + rtnl_unlock(); +} + static int nl80211_start_sched_scan(struct sk_buff *skb, struct genl_info *info) { @@ -5955,6 +5970,13 @@ static int nl80211_start_sched_scan(struct sk_buff *skb, err = rdev_sched_scan_start(rdev, dev, request); if (!err) { + if (info->attrs[NL80211_ATTR_SOCKET_OWNER]) { + INIT_WORK(&request->sched_scan_stop_wk, + nl80211_sched_scan_stop_wk); + + request->owner_nlportid = info->snd_portid; + } + rdev->sched_scan_req = request; nl80211_send_sched_scan(rdev, dev, NL80211_CMD_START_SCHED_SCAN); @@ -12127,6 +12149,12 @@ static int nl80211_netlink_notify(struct notifier_block * nb, list_for_each_entry_rcu(rdev, &cfg80211_rdev_list, list) { bool schedule_destroy_work = false; + bool schedule_scan_stop = false; + struct cfg80211_sched_scan_request *req = rdev->sched_scan_req; + + if (req && req->owner_nlportid == notify->portid && + notify->portid) + schedule_scan_stop = true; list_for_each_entry_rcu(wdev, &rdev->wdev_list, list) { cfg80211_mlme_unregister_socket(wdev, notify->portid); @@ -12157,6 +12185,12 @@ static int nl80211_netlink_notify(struct notifier_block * nb, spin_unlock(&rdev->destroy_list_lock); schedule_work(&rdev->destroy_work); } + } else if (schedule_scan_stop) { + req->owner_nlportid = 0; + + if (rdev->ops->sched_scan_stop && + rdev->wiphy.flags & WIPHY_FLAG_SUPPORTS_SCHED_SCAN) + schedule_work(&req->sched_scan_stop_wk); } }