From patchwork Sat Dec 20 16:47:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yannis Damigos X-Patchwork-Id: 5522961 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DE38E9F1CD for ; Sat, 20 Dec 2014 16:48:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0330B2015A for ; Sat, 20 Dec 2014 16:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED55320158 for ; Sat, 20 Dec 2014 16:48:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbaLTQru (ORCPT ); Sat, 20 Dec 2014 11:47:50 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:43685 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753123AbaLTQrt (ORCPT ); Sat, 20 Dec 2014 11:47:49 -0500 Received: by mail-wg0-f42.google.com with SMTP id k14so3687924wgh.29; Sat, 20 Dec 2014 08:47:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XIzc5kzzoUbHpH0rvqbY7X+MS+FclIPWJbZH5Vyf09s=; b=ahdkZ4dXmsSCrdljuiTZUR1rwgbVW70rlW2CctovmtLj5J4NXlPcI8Xwbi5DLRo5BT f5AnuJS9aSXQSvmWokk2+z6RgZSXTMiS39ueTJMDR74RcVzCW/WfSN+cdqUNPoUb+Qpr aJWEmCozshdTIe2GMnWLOIaRmkvw1VQdw5PLi9Ab+uvcznZYVFZj2hJ5MuKXG6iBwfKE KlX4839HGGYGRNDpcXskl82NOzcjmTdEm+T4a7WrAQ2Nwg9giKnQ4G1xb85qYGOCoDLu Pig1AtpPFLxYrBzO++PY/DeZswAPE1CLECuUCfr2canLqobdtGTM5mM0Ec5eE+akJw5O hmww== X-Received: by 10.194.95.232 with SMTP id dn8mr24586880wjb.91.1419094068451; Sat, 20 Dec 2014 08:47:48 -0800 (PST) Received: from localhost (athedsl-228451.home.otenet.gr. [85.74.212.1]) by mx.google.com with ESMTPSA id c10sm16890033wjy.4.2014.12.20.08.47.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Dec 2014 08:47:47 -0800 (PST) From: Yannis Damigos To: Larry Finger , Jes Sorensen , linux-wireless@vger.kernel.org Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Yannis Damigos Subject: [PATCHv2 1/1] staging: rtl8723au: Fix sparse invalid assignment warnings Date: Sat, 20 Dec 2014 18:47:27 +0200 Message-Id: <1419094047-16107-1-git-send-email-giannis.damigos@gmail.com> X-Mailer: git-send-email 2.2.1 In-Reply-To: <1418567365-18168-1-git-send-email-giannis.damigos@gmail.com> References: <1418567365-18168-1-git-send-email-giannis.damigos@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is a patch to the hal/rtl8723au_xmit.c file that fixes the following warnings found by sparse tool: drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:91:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:99:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:103:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:106:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:108:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:112:38: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:120:22: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:123:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:125:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: left side has type unsigned int drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:129:30: right side has type restricted __le32 drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: expected unsigned int [usertype] *pdw drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:184:51: got restricted __le32 * drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: expected unsigned int [usertype] *pdw drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:185:51: got restricted __le32 * Signed-off-by: Yannis Damigos --- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c index 6070510..1759487 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c +++ b/drivers/staging/rtl8723au/hal/rtl8723au_xmit.c @@ -79,7 +79,7 @@ static void fill_txdesc_sectype(struct pkt_attrib *pattrib, struct tx_desc *ptxd } } -static void fill_txdesc_vcs(struct pkt_attrib *pattrib, u32 *pdw) +static void fill_txdesc_vcs(struct pkt_attrib *pattrib, __le32 *pdw) { /* DBG_8723A("cvs_mode =%d\n", pattrib->vcs_mode); */ @@ -114,7 +114,7 @@ static void fill_txdesc_vcs(struct pkt_attrib *pattrib, u32 *pdw) } } -static void fill_txdesc_phy(struct pkt_attrib *pattrib, u32 *pdw) +static void fill_txdesc_phy(struct pkt_attrib *pattrib, __le32 *pdw) { if (pattrib->ht_en) { *pdw |= (pattrib->bwmode&HT_CHANNEL_WIDTH_40) ? cpu_to_le32(BIT(25)) : 0;