From patchwork Sun Dec 21 12:59:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5524011 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 074E7BEEA8 for ; Sun, 21 Dec 2014 12:56:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1B10A2011E for ; Sun, 21 Dec 2014 12:56:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CBAA20117 for ; Sun, 21 Dec 2014 12:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752729AbaLUM4y (ORCPT ); Sun, 21 Dec 2014 07:56:54 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:34219 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbaLUM4x (ORCPT ); Sun, 21 Dec 2014 07:56:53 -0500 Received: by mail-wi0-f182.google.com with SMTP id h11so5720240wiw.15 for ; Sun, 21 Dec 2014 04:56:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2hSHD1BeAKuU5oRH45x1trciiQf25phJgzSgYUSJ8gw=; b=IfBqJD6ZaoRyaMWkB0ONbMuDgs2c30Y1iA7CAucyCiejcYBB2CTrAWzi03OdY/WCGj JQUv4LLq2avOlzBrYZbEKzaGDOW7ea2WUlxObuoFceoAW7mqv3A8Q06stu5baTg3aOV1 NENseKg/eRWlryjM/qq8Q5xkIbnp1WNL79pJEnugB5H19DuLSJw11N2UBPKejifV5hIz YV7qxYwVb3GmyEP/o2fbXSEkz27HUSQ7XiOm7adBFti1nmyL8nWdUkSlKJHwqM3uTlWQ FKVXuppVWg3rmOuBzklqUI0K7OlG6Epz2oizwFcXdRaik9MhcQUrGCqBKDMsK9SN29hm Re+Q== X-Gm-Message-State: ALoCoQndzmXyB1ucid5BhJaezX+LPdOdJkAuUWraPFJXbwUjvK1NccJDenzewUE3zSMmjCGOo7X/ X-Received: by 10.194.59.33 with SMTP id w1mr32713660wjq.123.1419166612182; Sun, 21 Dec 2014 04:56:52 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id e7sm19809283wjf.18.2014.12.21.04.56.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Dec 2014 04:56:51 -0800 (PST) From: Rickard Strandqvist To: Larry Finger , Jes Sorensen Cc: Rickard Strandqvist , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723au: hal: rtl8723au_led.c: Remove some unused functions Date: Sun, 21 Dec 2014 13:59:39 +0100 Message-Id: <1419166779-2619-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Removes some functions that are not used anywhere: rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/hal/rtl8723au_led.c | 23 ---------------------- drivers/staging/rtl8723au/include/rtl8723a_led.h | 2 -- 2 files changed, 25 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723au_led.c b/drivers/staging/rtl8723au/hal/rtl8723au_led.c index b946636..99d627a7 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723au_led.c +++ b/drivers/staging/rtl8723au/hal/rtl8723au_led.c @@ -99,26 +99,3 @@ exit: /* Interface to manipulate LED objects. */ -/* Description: */ -/* Initialize all LED_871x objects. */ -void -rtl8723au_InitSwLeds(struct rtw_adapter *padapter) -{ - struct led_priv *pledpriv = &padapter->ledpriv; - - pledpriv->LedControlHandler = LedControl871x23a; - /* 8723as-vau wifi used led2 */ - InitLed871x23a(padapter, &pledpriv->SwLed0, LED_PIN_LED2); - -/* InitLed871x23a(padapter,&pledpriv->SwLed1, LED_PIN_LED2); */ -} - -/* Description: */ -/* DeInitialize all LED_819xUsb objects. */ -void -rtl8723au_DeInitSwLeds(struct rtw_adapter *padapter) -{ - struct led_priv *ledpriv = &padapter->ledpriv; - - DeInitLed871x23a(&ledpriv->SwLed0); -} diff --git a/drivers/staging/rtl8723au/include/rtl8723a_led.h b/drivers/staging/rtl8723au/include/rtl8723a_led.h index 1623d18..c83efe6 100644 --- a/drivers/staging/rtl8723au/include/rtl8723a_led.h +++ b/drivers/staging/rtl8723au/include/rtl8723a_led.h @@ -22,8 +22,6 @@ /* */ /* Interface to manipulate LED objects. */ /* */ -void rtl8723au_InitSwLeds(struct rtw_adapter *padapter); -void rtl8723au_DeInitSwLeds(struct rtw_adapter *padapter); void SwLedOn23a(struct rtw_adapter *padapter, struct led_8723a * pLed); void SwLedOff23a(struct rtw_adapter *padapter, struct led_8723a * pLed);