From patchwork Fri Jan 9 19:15:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bob Copeland X-Patchwork-Id: 5602301 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 076F3C058D for ; Fri, 9 Jan 2015 19:18:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2C5D620634 for ; Fri, 9 Jan 2015 19:18:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DBE020630 for ; Fri, 9 Jan 2015 19:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758191AbbAITS3 (ORCPT ); Fri, 9 Jan 2015 14:18:29 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:49998 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758175AbbAITS2 (ORCPT ); Fri, 9 Jan 2015 14:18:28 -0500 Received: by mail-oi0-f54.google.com with SMTP id u20so13178366oif.13 for ; Fri, 09 Jan 2015 11:18:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lvLbqRe0Lgg5+v6E7nMTiZSXKG0x0lb+9NZguAVWPbQ=; b=FBBd+v55UEygo1PmoyQ9SVRAbdVuf07FYKz5KeXIyZ/W92NAfXPaEdeVOqcKKGlIB8 pJ10y3QFr6z+j4IFzFoUmObcJeQxb1bNIpjX+Ptj06Nw1RAsfYYnWuXbuJeM3eYYQEA/ gROT5f2OMIlYeioYwCI0QhAuX5OsdKGEfDDjy1BkGmI7lLrFMidAjKP95qGNC72wkR8+ boPBShsC5g7koOG4HF3zvpmHRSNgoAiFbcTIj+4M1e3RuIb6fEdA/t4jtWCEXrc7bgV9 hppUYPNxZRrTOs5dFWG8vCBQC9+qIlhH+MpHjpwu8iPP7lPJ+pbbpObfUT1Qe5FCsXhJ 6nmA== X-Gm-Message-State: ALoCoQleSJ4SNa74hHF2+r4q4kwieeBqQyZKXIxlOs1J6w635i7g+O69/mpbZA8jYlcAgYy2mCos X-Received: by 10.202.217.138 with SMTP id q132mr9544199oig.35.1420831107597; Fri, 09 Jan 2015 11:18:27 -0800 (PST) Received: from hash ([2001:470:1d:6db:230:48ff:fe9d:9c89]) by mx.google.com with ESMTPSA id df11sm4725411oec.12.2015.01.09.11.18.26 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 09 Jan 2015 11:18:26 -0800 (PST) Received: from bob by hash with local (Exim 4.80) (envelope-from ) id 1Y9f3V-0002Wi-1b; Fri, 09 Jan 2015 14:17:09 -0500 From: Bob Copeland To: linux-wireless@vger.kernel.org Cc: Eugene Krasnikov , Bob Copeland Subject: [PATCH 2/8] wcn36xx: use !! when assigning int as a boolean Date: Fri, 9 Jan 2015 14:15:46 -0500 Message-Id: <1420830952-9624-3-git-send-email-me@bobcopeland.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1420830952-9624-1-git-send-email-me@bobcopeland.com> References: <1420830952-9624-1-git-send-email-me@bobcopeland.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP bd->tx_comp is a single bit in a bitfield, so assigning "info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS" only happens to work because TX_STATUS is defined to BIT(0); if it were any other bit this assignment would fail. Signed-off-by: Bob Copeland --- drivers/net/wireless/ath/wcn36xx/txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/txrx.c b/drivers/net/wireless/ath/wcn36xx/txrx.c index 32bb26a..f701873 100644 --- a/drivers/net/wireless/ath/wcn36xx/txrx.c +++ b/drivers/net/wireless/ath/wcn36xx/txrx.c @@ -237,7 +237,7 @@ int wcn36xx_start_tx(struct wcn36xx *wcn, bd->dpu_rf = WCN36XX_BMU_WQ_TX; - bd->tx_comp = info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS; + bd->tx_comp = !!(info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS); if (bd->tx_comp) { wcn36xx_dbg(WCN36XX_DBG_DXE, "TX_ACK status requested\n"); spin_lock_irqsave(&wcn->dxe_lock, flags);