diff mbox

ath5k: document a fall-through case in ath5k_hw_set_opmode

Message ID 1421694555-20795-1-git-send-email-linville@tuxdriver.com (mailing list archive)
State Accepted
Delegated to: Kalle Valo
Headers show

Commit Message

John W. Linville Jan. 19, 2015, 7:09 p.m. UTC 
Coverity: CID 114932

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
I'm guessing this is OK, since it seems to work?

 drivers/net/wireless/ath/ath5k/pcu.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Nick Kossifidis Jan. 23, 2015, 4:59 p.m. UTC | #1 
It's AR5210 related, we haven't worked much on that chip but I think that's ok.
AR5K_STA_ID1_NO_PSPOLL is set in every case on AR5210 so this
fall-through makes sure it gets set on station and monitor mode too.

Acked-by: Nick Kossifidis <mickflemm@gmail.com>

2015-01-19 21:09 GMT+02:00 John W. Linville <linville@tuxdriver.com>:
> Coverity: CID 114932
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> I'm guessing this is OK, since it seems to work?
>
>  drivers/net/wireless/ath/ath5k/pcu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
> index c60d36aa13e2..bf29da5e90da 100644
> --- a/drivers/net/wireless/ath/ath5k/pcu.c
> +++ b/drivers/net/wireless/ath/ath5k/pcu.c
> @@ -912,6 +912,7 @@ ath5k_hw_set_opmode(struct ath5k_hw *ah, enum nl80211_iftype op_mode)
>                 pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
>                         | (ah->ah_version == AR5K_AR5210 ?
>                                 AR5K_STA_ID1_PWR_SV : 0);
> +               /* fall through */
>         case NL80211_IFTYPE_MONITOR:
>                 pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
>                         | (ah->ah_version == AR5K_AR5210 ?
> --
> 2.1.0
>
Kalle Valo Jan. 23, 2015, 7:18 p.m. UTC | #2 
> Coverity: CID 114932
> 
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Acked-by: Nick Kossifidis <mickflemm@gmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index c60d36aa13e2..bf29da5e90da 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -912,6 +912,7 @@  ath5k_hw_set_opmode(struct ath5k_hw *ah, enum nl80211_iftype op_mode)
 		pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
 			| (ah->ah_version == AR5K_AR5210 ?
 				AR5K_STA_ID1_PWR_SV : 0);
+		/* fall through */
 	case NL80211_IFTYPE_MONITOR:
 		pcu_reg |= AR5K_STA_ID1_KEYSRCH_MODE
 			| (ah->ah_version == AR5K_AR5210 ?