From patchwork Fri Jan 30 12:31:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5749501 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4AAE0BF440 for ; Fri, 30 Jan 2015 12:33:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 771A420225 for ; Fri, 30 Jan 2015 12:33:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1D1C20222 for ; Fri, 30 Jan 2015 12:33:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756530AbbA3Mdf (ORCPT ); Fri, 30 Jan 2015 07:33:35 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:41037 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753784AbbA3Mdd (ORCPT ); Fri, 30 Jan 2015 07:33:33 -0500 Received: by mail-we0-f179.google.com with SMTP id q59so26870602wes.10 for ; Fri, 30 Jan 2015 04:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w1W+CAmspXWaqppOnlZ3UYziFWc39lwGq2zSSKh8eKg=; b=WZPQLlXxDDmYV9rlzWZ/uRNVqBk6pAq8GuOTtPQimFGea5HZWhg/lIE6u192QM5b7y HBA2Z5AIVUfDpUf+F3RfzrDYE47earo6qAvsYh27XoR8rKddV00iaEG6qUZFl3bqvt/O 4z0+uAWFaFqWBOYkLNfJ5LTwgGBU/iUZ+yhws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w1W+CAmspXWaqppOnlZ3UYziFWc39lwGq2zSSKh8eKg=; b=f5rSIjnEIhrBqbvG4Z4Iuuh7GasRjlDTdLw+tigcOPGk52I7KjwtST2R9Wp5DrJ6nI rjJa6OSaW49GjQC5EYkHLQfyrkYf9pSTz1f6Scghw/CiNxJXgS+3tmz8KuyTaoX76DzX c3riGf40hrUBMgbrT0x0HkXbCLC5ld+yd3jmQ/Yd07cYDkz3RV+X1hA+I65bytD1w+XC ZgQfLrmHVlrSNScj8qVuTk2FJZgSKspmJkvI7BtNKUYtrGfPMvvMRrhnJAbiPs7aCOPT 51lmJHwIW/J74viVCQBkjv5mKkDwITWf21TwwK3DDx4Ekao0JePXZU9ThXGISOV5ardc 6qmw== X-Gm-Message-State: ALoCoQkCu7ugUmV3dkRiemt5ou/I1U1oezpGJkADWxeMWXN2a45MdkO7z/liCRNLUBT/gQzKv28feIeHlmo7/rCxEMCS6jRobANoloRLaA+eDnWuJrRbQPiNdiX2uLbQgHa8aaAEzLHZ X-Received: by 10.180.79.106 with SMTP id i10mr4375267wix.35.1422621211705; Fri, 30 Jan 2015 04:33:31 -0800 (PST) Received: from bob.homerouter.cpe (apn-31-1-134-151.dynamic.gprs.plus.pl. [31.1.134.151]) by mx.google.com with ESMTPSA id fi10sm6730330wib.13.2015.01.30.04.33.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 04:33:31 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH v2 1/7] ath10k: allow empty ssid vdev config Date: Fri, 30 Jan 2015 13:31:20 +0100 Message-Id: <1422621086-28970-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1422621086-28970-1-git-send-email-michal.kazior@tieto.com> References: <1422607287-12289-1-git-send-email-michal.kazior@tieto.com> <1422621086-28970-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index be32db9..ccafb69 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1302,8 +1302,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index ce6f0c7..97ee2e9 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4264,8 +4264,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))