From patchwork Fri Jan 30 20:35:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 5752751 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 485EC9F302 for ; Fri, 30 Jan 2015 20:35:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6AE762026F for ; Fri, 30 Jan 2015 20:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 862252026D for ; Fri, 30 Jan 2015 20:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759446AbbA3UfP (ORCPT ); Fri, 30 Jan 2015 15:35:15 -0500 Received: from s3.sipsolutions.net ([5.9.151.49]:56032 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167AbbA3UfO (ORCPT ); Fri, 30 Jan 2015 15:35:14 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1YHIHZ-0002MI-0E; Fri, 30 Jan 2015 21:35:13 +0100 Message-ID: <1422650111.1919.45.camel@sipsolutions.net> Subject: Re: [IWLMVM] Firmware restart issue with 3.19-rc6-wl with AC 3160, REV=0x164 From: Johannes Berg To: Christian Lamparter Cc: linux-wireless , "ilw@linux.intel.com" , Emmanuel Grumbach Date: Fri, 30 Jan 2015 21:35:11 +0100 In-Reply-To: (sfid-20150130_212341_718339_20307764) References: (sfid-20150130_212341_718339_20307764) X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, 2015-01-30 at 21:23 +0100, Christian Lamparter wrote: > [ 6.274625] iwlwifi 0000:01:00.0: 0x00000038 | BAD_COMMAND > [ 6.275034] iwlwifi 0000:01:00.0: FW error in SYNC CMD SCD_QUEUE_CFG WTF. How did the firmware even announce support for this command?? Perhaps I missed it in the log, but which firmware are you using? Any chance you also upgraded that? Because I can't imagine this code is new in the tree... Anyway, make this change: I guess Emmanuel will look at it on Sunday :) johannes --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/iwlwifi/mvm/mvm.h b/drivers/net/wireless/iwlwifi/mvm/mvm.h index 979ac23522f2..5b8c969f457e 100644 --- a/drivers/net/wireless/iwlwifi/mvm/mvm.h +++ b/drivers/net/wireless/iwlwifi/mvm/mvm.h @@ -874,7 +874,7 @@ static inline bool iwl_mvm_is_d0i3_supported(struct iwl_mvm *mvm) static inline bool iwl_mvm_is_scd_cfg_supported(struct iwl_mvm *mvm) { - return mvm->fw->ucode_capa.capa[0] & IWL_UCODE_TLV_API_SCD_CFG; + return false; } extern const u8 iwl_mvm_ac_to_tx_fifo[];