From patchwork Sat Jan 31 15:08:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 5754821 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1ADAA9F336 for ; Sat, 31 Jan 2015 15:05:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4A2052026D for ; Sat, 31 Jan 2015 15:05:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1CF5D20263 for ; Sat, 31 Jan 2015 15:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753035AbbAaPFI (ORCPT ); Sat, 31 Jan 2015 10:05:08 -0500 Received: from mail-wi0-f176.google.com ([209.85.212.176]:61071 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbbAaPFH (ORCPT ); Sat, 31 Jan 2015 10:05:07 -0500 Received: by mail-wi0-f176.google.com with SMTP id bs8so8607862wib.3 for ; Sat, 31 Jan 2015 07:05:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=punTTsusIseAZuH7RFTAIAitqNr2CQILYIqs5Ah4qOo=; b=IxA5vVnzfXD4tkZDa5Dbb/b4qeIHmyxB6sLmpksjp7a3uwfXXuoj5kmxKeD5OORH2L 7tlrUTyhtmimF3vzMkhlWU+mbb7ip6MXUwOm3RhMLGIX67x+RjGQXHLpd5O5cuA/laeR S5fDw9/7GD/7hR8tS3lqpalvYjoBHwGGno2UKxgSckQlrqmDBki4MCTCGgDFE/f7SBm9 LuRYiG2xiFccnnE1oZdsTIXK6DKZZu82CpHt2u7pTwtF/Iu3X7qIwVh8xGu156QUTMwn n/AJfDnlF+INfTFMGKQaYONxxxSgsyU1rdV6w10NU6BTDf8S+Fmr3Qfqfx2QUjOocMI+ 0J3A== X-Gm-Message-State: ALoCoQmbB4pvi2nmxrgN4N90gg3axxYvOndIge+hWa1fcGaQlAsz0DRShGL1GQisFSLLKD/X0uRd X-Received: by 10.181.13.206 with SMTP id fa14mr5508354wid.57.1422716702991; Sat, 31 Jan 2015 07:05:02 -0800 (PST) Received: from localhost.localdomain (h-246-111.a218.priv.bahnhof.se. [85.24.246.111]) by mx.google.com with ESMTPSA id d7sm19553129wjs.2.2015.01.31.07.05.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Jan 2015 07:05:02 -0800 (PST) From: Rickard Strandqvist To: Larry Finger , Jes Sorensen Cc: Rickard Strandqvist , Greg Kroah-Hartman , Roberta Dobrescu , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723au: hal: HalDMOutSrc8723A_CE: Removed variables that is never used Date: Sat, 31 Jan 2015 16:08:24 +0100 Message-Id: <1422716904-5208-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Variable was assigned a value that was never used. I have also removed all the code that thereby serves no purpose. This was found using a static code analysis program called cppcheck Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c index 179a1ba..3cbbfb7 100644 --- a/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c +++ b/drivers/staging/rtl8723au/hal/HalDMOutSrc8723A_CE.c @@ -743,10 +743,8 @@ static void _PHY_IQCalibrate(struct rtw_adapter *pAdapter, int result[][8], u8 t /* Note: IQ calibration must be performed after loading */ /* PHY_REG.txt , and radio_a, radio_b.txt */ - u32 bbvalue; - if (t == 0) { - bbvalue = PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); + PHY_QueryBBReg(pAdapter, rFPGA0_RFMOD, bMaskDWord); /* Save ADDA parameters, turn Path A ADDA on */ _PHY_SaveADDARegisters(pAdapter, ADDA_REG, pdmpriv->ADDA_backup, IQK_ADDA_REG_NUM); @@ -1047,7 +1045,7 @@ void rtl8723a_phy_iq_calibrate(struct rtw_adapter *pAdapter, bool bReCovery) bPathAOK = bPathBOK = true; } else { RegE94 = RegEB4 = pdmpriv->RegE94 = pdmpriv->RegEB4 = 0x100; /* X default value */ - RegE9C = RegEBC = pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ + pdmpriv->RegE9C = pdmpriv->RegEBC = 0x0; /* Y default value */ } if ((RegE94 != 0)/*&&(RegEA4 != 0)*/)