From patchwork Thu Feb 5 13:33:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 5784621 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E6D15BF440 for ; Thu, 5 Feb 2015 13:33:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 233A62026F for ; Thu, 5 Feb 2015 13:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4180D2011E for ; Thu, 5 Feb 2015 13:33:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752944AbbBENde (ORCPT ); Thu, 5 Feb 2015 08:33:34 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:47639 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbbBENdc (ORCPT ); Thu, 5 Feb 2015 08:33:32 -0500 Received: by mail-ig0-f174.google.com with SMTP id b16so42484072igk.1; Thu, 05 Feb 2015 05:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; bh=8iVTycINSNXwT0PANJ9SsS1U41dbASCxm9jqmSo5aFY=; b=eHbFLpIiXddugZGRh11zHm6P1dyPHi4AhslYLsPlW6Av2+8Gy9aKJv8SA/n0uaWIM/ jxZSchLo0Ctgp/+QEijZRbpBzgqpC916YqmOVhXbqInIlTiMOZYwwj6V8ShkpiiimRVn tojwJVIV97GOh/EexJ/ejwROih+Daj89fNlnXs+uAGm3968QrNFubhwUaEAT9FmUIaTS vUrehmZfbaHzaqQfSGRIK98m5c/3BOKQ6GIumEjC6YB4clKe7DM7qTFAkT5j1oo3FhCz +mjYtWxqjpq0mbUfPYC0XBkeNPLSlSOFwmb3PI7BmESrMaZW8vb4LPuiaBBL/2cbCEaJ vjfQ== X-Received: by 10.42.98.139 with SMTP id s11mr7163580icn.3.1423143212112; Thu, 05 Feb 2015 05:33:32 -0800 (PST) Received: from [172.19.248.118] ([172.19.248.118]) by mx.google.com with ESMTPSA id b1sm2467345ioe.12.2015.02.05.05.33.31 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Thu, 05 Feb 2015 05:33:31 -0800 (PST) Message-ID: <1423143210.31870.51.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: Throughput regression with `tcp: refine TSO autosizing` From: Eric Dumazet To: Michal Kazior Cc: Neal Cardwell , linux-wireless , Network Development , eyalpe@dev.mellanox.co.il Date: Thu, 05 Feb 2015 05:33:30 -0800 In-Reply-To: <1423142342.31870.49.camel@edumazet-glaptop2.roam.corp.google.com> References: <1422537297.21689.15.camel@edumazet-glaptop2.roam.corp.google.com> <1422628835.21689.95.camel@edumazet-glaptop2.roam.corp.google.com> <1422903136.21689.114.camel@edumazet-glaptop2.roam.corp.google.com> <1422926330.21689.138.camel@edumazet-glaptop2.roam.corp.google.com> <1422973660.907.10.camel@edumazet-glaptop2.roam.corp.google.com> <1423051045.907.108.camel@edumazet-glaptop2.roam.corp.google.com> <1423053531.907.115.camel@edumazet-glaptop2.roam.corp.google.com> <1423055810.907.125.camel@edumazet-glaptop2.roam.corp.google.com> <1423056591.907.130.camel@edumazet-glaptop2.roam.corp.google.com> <1423084303.31870.15.camel@edumazet-glaptop2.roam.corp.google.com> <1423141038.31870.38.camel@edumazet-glaptop2.roam.corp.google.com> <1423142342.31870.49.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2015-02-05 at 05:19 -0800, Eric Dumazet wrote: > > TCP could eventually dynamically adjust the tcp_limit_output_bytes, > using a per flow dynamic value, but I would rather not add a kludge in > TCP stack only to deal with a possible bug in ath10k driver. > > niu has a similar issue and simply had to call skb_orphan() : > > drivers/net/ethernet/sun/niu.c:6669: skb_orphan(skb); In your case that might be the place : --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c index 4bc51d8a14a3..cbda7a87d5a1 100644 --- a/drivers/net/wireless/ath/ath10k/htt_tx.c +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c @@ -468,6 +468,7 @@ int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *msdu) msdu_id = res; htt->pending_tx[msdu_id] = msdu; spin_unlock_bh(&htt->tx_lock); + skb_orphan(msdu); prefetch_len = min(htt->prefetch_len, msdu->len); prefetch_len = roundup(prefetch_len, 4);