From patchwork Fri Feb 6 12:02:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5790031 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DAD4F9F2ED for ; Fri, 6 Feb 2015 12:04:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0BD34200E6 for ; Fri, 6 Feb 2015 12:04:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C28E200DB for ; Fri, 6 Feb 2015 12:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756427AbbBFMD6 (ORCPT ); Fri, 6 Feb 2015 07:03:58 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:53697 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624AbbBFMDw (ORCPT ); Fri, 6 Feb 2015 07:03:52 -0500 Received: by mail-we0-f179.google.com with SMTP id u56so7738939wes.10 for ; Fri, 06 Feb 2015 04:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nmpHWE+AE95+VU1vv0qt5DOvPQRW4T9MWI382gQ/3+s=; b=pNqMI12BvmS0QbMc3BxhRni5WRe0H3Mgeb34Q31+E4c0aHo/v63yjG5N4mCW772weu iDbSa/G2gNLZe7QhXnWYJR/lPgY110/MS9GA16VZDTe8hlNtD+FJiN46xsMamcOHxDhT gIoy3m5TKQ+wG2Mb7Q7cGP+ocvuF8OPlHvHF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nmpHWE+AE95+VU1vv0qt5DOvPQRW4T9MWI382gQ/3+s=; b=SV86PEVw+UPSHcbbRNDyo0Mg5Jzmnx+rwhBpTRQNdK+kBXN/ctXmyxvXvQe2kxedOD dn6hNFInkXA+bORah3v6UY2v5vJvNYpkbF36RF4xsnoDFVzxcctBXiZ5TXgD9Sq8yM5d 4sE6IxtXd4TThT3JjDTZVkdE5l+G5YqnWkRTx5DsMZjeq7KcYmFFIHORNKL+3P0gZJRP u9XV+0S++apD/fPdYnEVYLQFtjAZWv7g4NCzb2O+xPGLW4KTGSLiKAMDUgNliCGD8i96 t9bWBPBmgM85C3zPQZhSkV3RlOBY77i2BBiIJlrUMEi4ssNNR4MIvOyjz6wsPq+fiRvU TXTg== X-Gm-Message-State: ALoCoQk+uY9nZJVqJFY68m2UE8kvbl3b9WIeJVZ/j2Et81JlrpkUHCI8Fhhq3GnMNRYwpJ+o+BqFtvUzBBFQ3Z1yIXaXfhieEastmjTIfFrVf0q5BVO21+UBs4TxFfEgh8euueJzX+5s X-Received: by 10.180.100.202 with SMTP id fa10mr2775321wib.10.1423224231006; Fri, 06 Feb 2015 04:03:51 -0800 (PST) Received: from bob.homerouter.cpe (apn-31-1-134-151.dynamic.gprs.plus.pl. [31.1.134.151]) by mx.google.com with ESMTPSA id kj8sm3070158wjc.29.2015.02.06.04.03.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Feb 2015 04:03:50 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH v3 1/7] ath10k: allow empty ssid vdev config Date: Fri, 6 Feb 2015 13:02:48 +0100 Message-Id: <1423224174-24764-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1423224174-24764-1-git-send-email-michal.kazior@tieto.com> References: <1423224174-24764-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 71614ba..c13a505 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1302,8 +1302,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index aeea1c7..0da1cdc 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4295,8 +4295,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))