From patchwork Tue Feb 10 11:48:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5806711 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8DADC9F37F for ; Tue, 10 Feb 2015 11:50:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A8E7120108 for ; Tue, 10 Feb 2015 11:50:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C34B620107 for ; Tue, 10 Feb 2015 11:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbbBJLue (ORCPT ); Tue, 10 Feb 2015 06:50:34 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:46786 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbbBJLud (ORCPT ); Tue, 10 Feb 2015 06:50:33 -0500 Received: by lams18 with SMTP id s18so19651751lam.13 for ; Tue, 10 Feb 2015 03:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=268tHLB5hjG6XCXM6mMjDIKZI11GUWopluv5JXz2jg8=; b=mzHgwe3Fg97NhncI9I9qkPO6ziBBuBJA7Ix4e+0uiGfPB/UmWNscAV1COEScVzVCuf PTcf7/4tLVP7q7/fq2fbAYECEStL0kGXz0EI7wwAjhx+gFREHVt/yLtuqMUVbK22N6Yp b0JVhHC+iphf0oc3rD6MF5BHVe9BJOqoGJzwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=268tHLB5hjG6XCXM6mMjDIKZI11GUWopluv5JXz2jg8=; b=jFG9Gk4TUNgLrsYpXgj9Z/+B/4eQXYBeNSxvWUVqQfyFfGfyhLWAv57jMP3Ev3Iptl fAkVjyrDpycZO9A8pPNMWg6qFImrXAyGCrtEhcs/455uCQEyBYJCjPP9vK9kyk8DCCAz EHO9ij4JNg174jDiW7F3F0kPwpZVDLsk1Xfg4rYZ1TmFjNq5Jl3G19OzIyy33UT+eATh Mm5re9SA5uqlc+xzt9CXS+d1yWnG+oNjv1Y5sOsodiV7fRdDsTaU0uw/zQBBfB8+72vw V3asg0IPspgwL6/nkfm8PHHItDZoxjGH2jr/n5kU9jymvyuVxeyS+V152ih2BSsVjwAG C3yw== X-Gm-Message-State: ALoCoQnhi6nCdaQKRayZFKPJEfaRcjSUz42FZvkfvrsJ0gxe8BEtINoOcYPz00QzONJIyVHyuHLl3tcVeCNP870BSPv5uYqFVCf0s54VdfBuc98NH5BqK6jHl+MYs7bfo2+yq/uVzfok3y6xAVq10YUsCIJ2sqrOYLkQn5dzYzSlshsoPEulOHqVusXnsTARdYSHd0wSSJO5 X-Received: by 10.152.5.72 with SMTP id q8mr22646368laq.57.1423569032159; Tue, 10 Feb 2015 03:50:32 -0800 (PST) Received: from bob.homerouter.cpe (apn-31-1-134-151.dynamic.gprs.plus.pl. [31.1.134.151]) by mx.google.com with ESMTPSA id d8sm2657124lah.15.2015.02.10.03.50.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Feb 2015 03:50:31 -0800 (PST) From: Michal Kazior To: linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net, Michal Kazior Subject: [PATCH] mac80211: disable u-APSD queues by default Date: Tue, 10 Feb 2015 12:48:44 +0100 Message-Id: <1423568924-11895-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some APs experience problems when working with U-APSD. Decreasing the probability of that happening by using legacy mode for all ACs but VO isn't enough. Cisco 4410N originally forced us to enable VO by default only because it treated non-VO ACs as legacy. However some APs (notably Netgear R7000) silently reclassify packets to different ACs. Since u-APSD ACs require trigger frames for frame retrieval clients would never see some frames (e.g. ARP responses) or would fetch them accidentally after a long time. It makes little sense to enable u-APSD queues by default because it needs userspace applications to be aware of it to actually take advantage of the possible additional powersavings. Implicitly depending on driver autotrigger frame support doesn't make much sense. Signed-off-by: Michal Kazior --- net/mac80211/ieee80211_i.h | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h index 3afe368..c0e089c 100644 --- a/net/mac80211/ieee80211_i.h +++ b/net/mac80211/ieee80211_i.h @@ -58,13 +58,24 @@ struct ieee80211_local; #define IEEE80211_UNSET_POWER_LEVEL INT_MIN /* - * Some APs experience problems when working with U-APSD. Decrease the - * probability of that happening by using legacy mode for all ACs but VO. - * The AP that caused us trouble was a Cisco 4410N. It ignores our - * setting, and always treats non-VO ACs as legacy. + * Some APs experience problems when working with U-APSD. Decreasing the + * probability of that happening by using legacy mode for all ACs but VO isn't + * enough. + * + * Cisco 4410N originally forced us to enable VO by default only because it + * treated non-VO ACs as legacy. + * + * However some APs (notably Netgear R7000) silently reclassify packets to + * different ACs. Since u-APSD ACs require trigger frames for frame retrieval + * clients would never see some frames (e.g. ARP responses) or would fetch them + * accidentally after a long time. + * + * It makes little sense to enable u-APSD queues by default because it needs + * userspace applications to be aware of it to actually take advantage of the + * possible additional powersavings. Implicitly depending on driver autotrigger + * frame support doesn't make much sense. */ -#define IEEE80211_DEFAULT_UAPSD_QUEUES \ - IEEE80211_WMM_IE_STA_QOSINFO_AC_VO +#define IEEE80211_DEFAULT_UAPSD_QUEUES 0 #define IEEE80211_DEFAULT_MAX_SP_LEN \ IEEE80211_WMM_IE_STA_QOSINFO_SP_ALL