From patchwork Wed Feb 25 10:39:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5879131 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9F568BF440 for ; Wed, 25 Feb 2015 10:40:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BF24F2034A for ; Wed, 25 Feb 2015 10:40:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F072A202F8 for ; Wed, 25 Feb 2015 10:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752809AbbBYKkq (ORCPT ); Wed, 25 Feb 2015 05:40:46 -0500 Received: from mail-lb0-f173.google.com ([209.85.217.173]:38241 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338AbbBYKkp (ORCPT ); Wed, 25 Feb 2015 05:40:45 -0500 Received: by lbiz11 with SMTP id z11so2915191lbi.5 for ; Wed, 25 Feb 2015 02:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=zDpV4eFKoK5w/T2N2p6EzC3tEnDomuC5T/p84FFf1xY=; b=eUROwwRVZurYBfwX6RcsEyMmUoz0LqUFjBNwQhE62za5QiSDw0d3yY8IhFlhRR5FvC 5kEtPnzd4vuVm76Fof7AZwrIG9juv7OIiPLDkgT0U2804nu1j8+J3qXGVfInZqTbkuke BXqLclP+gOv/40EkRdYXmh1qgVkgkLacf9hGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zDpV4eFKoK5w/T2N2p6EzC3tEnDomuC5T/p84FFf1xY=; b=g/ImMBbVPCSQWmf9b5aXI0pJKC6GnBGcwgeZlYAFUP+9YTQ0kDMIeJtT6EcKu3I+9n QcjW5al1lL+Rz2FtjeXlSYXgfumFa87onQxNZDs30f2+YGRmnc5Eh7LJDqTFYk4+7HW5 x8aAVW73lNU4lq3PuTNAvKcuIuf8A0h8iRp4Q0MBD0sXAX6tHHpGZSd3/XJpGAHOhxz6 SO78ThHB529igEhERwj4BZFst982P5Ikvzyjc8iM4QX/58O8xlHXoC0x0uUAkOCp8Q8i 3gV/F/Del4JDwH1sFpcaztAOSK0KgXOWcE7cobflhTa5qlEhc8SuTKN5YBVRN4U8s5fA zHiQ== X-Gm-Message-State: ALoCoQmcbuCnLW8uAomx0H73m+ea6E6758V/USTlOSjAbKorBdALwfiujHzy6ZR0GJuy/UjTGYv5ThJkr18It1dSHRLvbGPbQR7lL/czgr++DfbKrFjkCSu6Uvfa4LLWqRTPXpPJd+Y+ X-Received: by 10.112.148.38 with SMTP id tp6mr2203626lbb.82.1424860843491; Wed, 25 Feb 2015 02:40:43 -0800 (PST) Received: from bob.homerouter.cpe (apn-77-113-114-198.dynamic.gprs.plus.pl. [77.113.114.198]) by mx.google.com with ESMTPSA id ms3sm7698964lbb.4.2015.02.25.02.40.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 02:40:42 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath10k: fix ap u-apsd cmd on qca6174 w/ wmi-tlv Date: Wed, 25 Feb 2015 11:39:36 +0100 Message-Id: <1424860776-11668-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The command was truncated so the parameter value was seen in fw as 0. This caused U-APSD enabled stations to be misconfigured and mistreated by AP. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index f34baa0..af5d858 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -2032,7 +2032,7 @@ ath10k_wmi_tlv_op_gen_set_ap_ps(struct ath10k *ar, u32 vdev_id, const u8 *mac, if (!mac) return ERR_PTR(-EINVAL); - skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd)); + skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd)); if (!skb) return ERR_PTR(-ENOMEM);