From patchwork Tue Mar 17 12:30:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6031611 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 10BF49F2A9 for ; Tue, 17 Mar 2015 12:33:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 402BF203E9 for ; Tue, 17 Mar 2015 12:33:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 581142045B for ; Tue, 17 Mar 2015 12:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753314AbbCQMdZ (ORCPT ); Tue, 17 Mar 2015 08:33:25 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:34972 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753228AbbCQMdX (ORCPT ); Tue, 17 Mar 2015 08:33:23 -0400 Received: by lbcgn8 with SMTP id gn8so5771138lbc.2 for ; Tue, 17 Mar 2015 05:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=85QANAatgDQ7Jxc8SKZXHYAf3vMNHKQPh2L2+WgrBaQ=; b=dS6shqGkwk1J5QuVwXIeKHQFHl5sVCy+Oc7egj2JH++ATXoOViJYMC/dC1vHObz1SB Hjmq5GPoruejrF4AiEwjbfisriOXv89yFBqKWEiXtrkybD0xa4FgQlAkf0hFxunYTuKq xxlLg8mThycHpV3USxaN3egclYtanb2E5VbNw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=85QANAatgDQ7Jxc8SKZXHYAf3vMNHKQPh2L2+WgrBaQ=; b=jzCl6qA3si0jHYvvM6TWWBhy9ay9RWpywExRL3m27bIT0mT4MHxcIWsj7szYYkcY3i F/2RqqBnmo8C/P1lokrIHqbF8Z3R3UTvs4j7lEW48bTs8D8PYO/CkBFWAxNL3XRKY0VV e6AAt1ZWWfT4A37FzcFkim9Wg+Ld2YRVTkQQDLkwhEPC0dP6Lm2do4zS22Fmyvi1LEsU JSW55DUpGrI1ZlDnPcXC/cJx+k47KKFg8zrgpt5hJ5SWZFm7eS59bMmqzqA2Lrn8ugsd wfZThB3LVm7qJ8pcIABsyz/lCjKWsYNQSlqB40hHpUZor8DFBNME3BNtJHMADyhF12xk 3sTg== X-Gm-Message-State: ALoCoQlQovfuy4lJfI6tb33MkmztBaURe4qZpIqMobT10297t0W12Klwe2UKaaTSM5qa3X0wxeZxMp9NhXGuMv3hJ6zGRTikx734DAzOOwCCtEAeSNDCRhmABQx6EJqLt/OkXZYEn28P X-Received: by 10.112.170.132 with SMTP id am4mr59269796lbc.89.1426595601924; Tue, 17 Mar 2015 05:33:21 -0700 (PDT) Received: from bob.homerouter.cpe (apn-77-113-71-242.dynamic.gprs.plus.pl. [77.113.71.242]) by mx.google.com with ESMTPSA id w9sm2774934laj.24.2015.03.17.05.33.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 17 Mar 2015 05:33:20 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH v4 1/7] ath10k: allow empty ssid vdev config Date: Tue, 17 Mar 2015 12:30:42 +0000 Message-Id: <1426595448-1630-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1426595448-1630-1-git-send-email-michal.kazior@tieto.com> References: <1426595448-1630-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 3eec042..fa3eb1b 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1486,8 +1486,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 54430a1..7b3e6ca 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4286,8 +4286,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))