From patchwork Thu Mar 26 10:03:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6097401 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D09819F399 for ; Thu, 26 Mar 2015 10:06:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EE5B4201D3 for ; Thu, 26 Mar 2015 10:06:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D05D8201EC for ; Thu, 26 Mar 2015 10:06:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594AbbCZKF7 (ORCPT ); Thu, 26 Mar 2015 06:05:59 -0400 Received: from mail-lb0-f181.google.com ([209.85.217.181]:32833 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbCZKF6 (ORCPT ); Thu, 26 Mar 2015 06:05:58 -0400 Received: by lbcmq2 with SMTP id mq2so37151338lbc.0 for ; Thu, 26 Mar 2015 03:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=Ho/l5j3D4V4/MAj77e0uiaM1LX4tx4PlkdZlLn7T/i4=; b=HmE1XS0nUFIEYuzLKHFU2DAbWMDlh24LV6faskGgb66dsmbRBzATPy3dtsvYwb5bzv PFU1lxCqSmPOIC3YAVwZ/aRzf/AmFWikL84k4mOSVoeAHM9G6w9S4fZmAweuQTwd7Dzy rPLNwufZlZ34cYJwctZ2JAXtluziy9mablPRE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ho/l5j3D4V4/MAj77e0uiaM1LX4tx4PlkdZlLn7T/i4=; b=CQ4mf6zI8syUm0oddu4ZDBCQCJ3CqEY4v1ofK+IOc8agqHDw+pRUVQVgaGsO7FXOi7 OWYGA9+O3AaA2T9tbJPZzqfHyTyRhJbeZuKOcmz5vi2gsyAw0st7WoD6cMsEHT+ACm0O ZO41W/17IpN0A8eMc/lKzzTM1SChj7B1rxYVQAPDp8YEfhJbVnu3PAKBiNlE0ppZ3rSd rCEL8mJYumE94wvFXdxlAFxgoICt6/C3XhdgxcYseSYB3ax6jSazfVW26uoOXxvVLQPN 9wa+CFfQJH+C7OayBWA9SQDGS7U/P52E4KDV8v+e8wU0KZ8Ut/RqFWMjjKr4gMKRkZZ3 nicg== X-Gm-Message-State: ALoCoQljJoxhfl0GmOVr4Y6QbmL5GYoMofj+HdwpHDm0DoZU/14FZVW+NjllA99c0TN8ttFcbwHaaYkXR8cn+Qq65NzBxMsbr7MF2HP+5kyYAi+w87KeR8QYCNoogN7WzwgXAqfxB7no X-Received: by 10.152.163.2 with SMTP id ye2mr12377885lab.89.1427364357353; Thu, 26 Mar 2015 03:05:57 -0700 (PDT) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id s17sm118997lbp.40.2015.03.26.03.05.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 26 Mar 2015 03:05:56 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Michal Kazior Subject: [PATCH] ath10k: fix insufficient tracing buffer size Date: Thu, 26 Mar 2015 10:03:22 +0000 Message-Id: <1427364202-25235-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some trace messages were truncated and a kernel splat could be seen in the log: WARNING: CPU: 3 PID: 0 at /devel/src/linux/drivers/net/wireless/ath/ath10k/./trace.h:114 ftrace_raw_event_ath10k_log_dbg+0x20e/0x220 [ath10k_core]() Modules linked in: ath10k_pci(O) ath10k_core(O) ath iwldvm iwlwifi [last unloaded: iwlwifi] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G W O 4.0.0-rc3-wl-ath+ #703 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140531_083030-gandalf 04/01/2014 ffffffffa01d4cb0 ffff88001fd83998 ffffffff8191b86c ffffffff81e3b718 0000000000000000 ffff88001fd839d8 ffffffff8105573a ffff88001c0a5528 ffff88001bea9ae0 ffff88001c3dd940 00000000000d0018 ffff88001fd83a80 Call Trace: [] dump_stack+0x45/0x57 [] warn_slowpath_common+0x8a/0xc0 [] warn_slowpath_null+0x1a/0x20 [] ftrace_raw_event_ath10k_log_dbg+0x20e/0x220 [ath10k_core] [] ath10k_dbg+0xbb/0xd0 [ath10k_core] [] ? trace_clock_local+0x9/0x10 [] ath10k_wmi_event_service_ready+0x479/0x520 [ath10k_core] [] ? trace_buffer_unlock_commit+0x50/0x60 [] ath10k_wmi_tlv_op_rx+0x6b3/0x8b0 [ath10k_core] This could be reproduced with: trace-cmd record -e ath10k ifconfig wlan0 down ifconfig wlan0 up Fixes: 5c01aa3de918 ("ath10k: deduplicate wmi service ready logic") Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend") Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/trace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/trace.h b/drivers/net/wireless/ath/ath10k/trace.h index 5407887380ab..71dfcd96354b 100644 --- a/drivers/net/wireless/ath/ath10k/trace.h +++ b/drivers/net/wireless/ath/ath10k/trace.h @@ -46,7 +46,7 @@ static inline void trace_ ## name(proto) {} #undef TRACE_SYSTEM #define TRACE_SYSTEM ath10k -#define ATH10K_MSG_MAX 200 +#define ATH10K_MSG_MAX 400 DECLARE_EVENT_CLASS(ath10k_log_event, TP_PROTO(struct ath10k *ar, struct va_format *vaf),