From patchwork Mon Jun 1 09:23:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raja Mani X-Patchwork-Id: 6519831 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B8A48C0020 for ; Mon, 1 Jun 2015 09:24:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F1A08205EE for ; Mon, 1 Jun 2015 09:24:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5896205BD for ; Mon, 1 Jun 2015 09:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752332AbbFAJYW (ORCPT ); Mon, 1 Jun 2015 05:24:22 -0400 Received: from sabertooth02.qualcomm.com ([65.197.215.38]:8917 "EHLO sabertooth02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbbFAJYV (ORCPT ); Mon, 1 Jun 2015 05:24:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1433150661; x=1464686661; h=from:to:cc:subject:date:message-id:mime-version; bh=zLeKR0d9Ix6G+QrdPt28/Fcy1urkTe+FqAxc1iwOxV4=; b=yCXjccI0oXcLMGjWttVGP7q3cxkiZ88FkxaYwYgsFy/B0+fmc0LUl3c6 IdGWQjly/C6X3NUJumjunqJL09oyqCUNKcNb1W3VrlqRH13r8qNqKaQRn 2aoaqmOavEeWxTDVueXVOyIzGrAYj5f1R0iMPNOofx++zLupIjSNHq/+N c=; X-IronPort-AV: E=McAfee;i="5700,7163,7818"; a="91117478" Received: from ironmsg03-r.qualcomm.com ([172.30.46.17]) by sabertooth02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 01 Jun 2015 02:24:20 -0700 X-IronPort-AV: E=Sophos;i="5.13,531,1427785200"; d="scan'208";a="930270606" Received: from nasanexm01c.na.qualcomm.com ([10.85.0.83]) by Ironmsg03-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 01 Jun 2015 02:24:20 -0700 Received: from aphydexm01a.ap.qualcomm.com (10.252.127.10) by NASANEXM01C.na.qualcomm.com (10.85.0.83) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 1 Jun 2015 02:24:19 -0700 Received: from 10.80.81.91 (10.80.80.8) by aphydexm01a.ap.qualcomm.com (10.252.127.10) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 1 Jun 2015 14:54:08 +0530 Received: by 10.80.81.91 (sSMTP sendmail emulation); Mon, 01 Jun 2015 14:53:57 +0530 From: Raja Mani To: CC: , , Raja Mani Subject: [PATCH] ath10k: free wmi mgmt event skb when parsing fails Date: Mon, 1 Jun 2015 14:53:33 +0530 Message-ID: <1433150613-5662-1-git-send-email-rmani@qti.qualcomm.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01B.na.qualcomm.com (10.85.0.82) To aphydexm01a.ap.qualcomm.com (10.252.127.10) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When wmi mgmt event function fails to parse given skb, it should be freed on failure condition to avoid memory leaks. Found this during the code review. Signed-off-by: Raja Mani --- drivers/net/wireless/ath/ath10k/wmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index b892eb8..818bd25 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2089,6 +2089,7 @@ int ath10k_wmi_event_mgmt_rx(struct ath10k *ar, struct sk_buff *skb) ret = ath10k_wmi_pull_mgmt_rx(ar, skb, &arg); if (ret) { ath10k_warn(ar, "failed to parse mgmt rx event: %d\n", ret); + dev_kfree_skb(skb); return ret; }