From patchwork Fri Jul 17 07:13:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Fenkart X-Patchwork-Id: 6813441 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AC4199F358 for ; Fri, 17 Jul 2015 07:13:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E0B5E2065D for ; Fri, 17 Jul 2015 07:13:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D3D120672 for ; Fri, 17 Jul 2015 07:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756993AbbGQHNo (ORCPT ); Fri, 17 Jul 2015 03:13:44 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:36807 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756977AbbGQHNn (ORCPT ); Fri, 17 Jul 2015 03:13:43 -0400 Received: by widjy10 with SMTP id jy10so33791638wid.1 for ; Fri, 17 Jul 2015 00:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8UpXbQRZBz0ormopm+GJYkXP3KgUFFoVqfW3cIYnv7I=; b=GiwbcNHzn1HSzpFmnQ5oSvCH7/XMW5H/w0y5ywP4TjkaIqFjmtTOFy58MKAfFvGj6H 94mUTIlSMjqg1mMe+EYaf0p2bJOvOkQDc2pySuE7CmonrFw6NUt+HdSDj2J/ZQFLA6P2 WLtkM580yvmSnA7Z+cNPEZBkwrN5dRkE8DlW8tDsOwB49QscWGZbPvLRNsjLSB7v/sZk 5pnyhKKPhcYeXjtlSLtlluGherre9C/4Ax14D8EVz6XyD/EZ40/YmoApJbYmvXMS59ca ihIR18zMdh2VDFNJZclefgAg3yeaaCGTUfVvvpajn/hlS0n3eGnQzIuPz47qaAjMFsw9 lNtA== X-Received: by 10.180.77.115 with SMTP id r19mr13021741wiw.9.1437117222453; Fri, 17 Jul 2015 00:13:42 -0700 (PDT) Received: from localhost (ip-89-176-167-254.net.upcbroadband.cz. [89.176.167.254]) by smtp.gmail.com with ESMTPSA id k4sm7021208wix.19.2015.07.17.00.13.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jul 2015 00:13:41 -0700 (PDT) From: Andreas Fenkart To: linux-wireless@vger.kernel.org Cc: Amitkumar Karwar , Kalle Valo , Andreas Fenkart Subject: [PATCH 2/4] mwifiex: remove redundant reset of cmd_wait_q status Date: Fri, 17 Jul 2015 09:13:04 +0200 Message-Id: <1437117186-25243-3-git-send-email-afenkart@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1437117186-25243-1-git-send-email-afenkart@gmail.com> References: <1437117186-25243-1-git-send-email-afenkart@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mwifiex_cancel_pending_ioctl is called only from mwifiex_cmd_timeout_func. There the wait_q status is set to -ETIMEDWAIT before calling this function. Whether we reset the status to -1 or leave it at -ETIMEDWAIT at end doesn't matter since both are != 0 hence mean failure Signed-off-by: Andreas Fenkart Acked-by: Amitkumar Karwar --- drivers/net/wireless/mwifiex/cmdevt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/mwifiex/cmdevt.c b/drivers/net/wireless/mwifiex/cmdevt.c index 2f4715e..87b6dee 100644 --- a/drivers/net/wireless/mwifiex/cmdevt.c +++ b/drivers/net/wireless/mwifiex/cmdevt.c @@ -1123,7 +1123,6 @@ mwifiex_cancel_pending_ioctl(struct mwifiex_adapter *adapter) } } } - adapter->cmd_wait_q.status = -1; } /*