From patchwork Wed Aug 19 06:59:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 7035771 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C0EAC9F358 for ; Wed, 19 Aug 2015 06:59:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DB9AC207B2 for ; Wed, 19 Aug 2015 06:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D283E207B1 for ; Wed, 19 Aug 2015 06:59:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752994AbbHSG7e (ORCPT ); Wed, 19 Aug 2015 02:59:34 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:34763 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbbHSG7d (ORCPT ); Wed, 19 Aug 2015 02:59:33 -0400 Received: by paccq16 with SMTP id cq16so107269817pac.1 for ; Tue, 18 Aug 2015 23:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jUW4hV41BfoOYd4buG0CAtGCp41lXxP6874jk3uHLLU=; b=vszgvL78KnHaYbMTTNCKMEvCofqt19zWfTDYU9zZGGt/nvJHl11+a0o7wkJwrhg/Is yLKbyV0qPpOERW4ozo51Y7CcZ+jEpQoB11KTipO4BnhyK0S+AjD/lWtBwh9xh9UYEZBR RfGkqHIq5ATsR8GrVNSgg6UOjHwF9+4eS3bpzKSEHiGcdebExmDx48WZ3ElIaK09Mmgy 25XpSpUT0/MX3e1MgYd/4zSGGegyPFhjD0Ehn1/mMbPhfKFrpnuN1Tm3t/tysn2GuDz/ oRVWkxRfZ3f623+ef5QEhOTzCh5WhuhiW3le736XzjWPtngJIQASMj/ZzYmmzWoMTtjy 7UBQ== X-Received: by 10.69.27.68 with SMTP id je4mr21372302pbd.163.1439967573281; Tue, 18 Aug 2015 23:59:33 -0700 (PDT) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id jw13sm20536843pad.48.2015.08.18.23.59.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Aug 2015 23:59:32 -0700 (PDT) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH 06/13] staging: wilc1000: wilc_msgqueue.c: use ! operator instead of NULL comparison Date: Wed, 19 Aug 2015 15:59:01 +0900 Message-Id: <1439967548-25876-6-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1439967548-25876-1-git-send-email-chaehyun.lim@gmail.com> References: <1439967548-25876-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch uses ! operator instead of NULL comparison. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 53ce586..0770ff6 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c +++ b/drivers/staging/wilc1000/wilc_msgqueue.c @@ -34,7 +34,7 @@ WILC_ErrNo WILC_MsgQueueDestroy(WILC_MsgQueueHandle *pHandle) pHandle->u32ReceiversCount--; } - while (pHandle->pstrMessageList != NULL) { + while (pHandle->pstrMessageList) { Message *pstrMessge = pHandle->pstrMessageList->pstrNext; kfree(pHandle->pstrMessageList); @@ -57,7 +57,7 @@ WILC_ErrNo WILC_MsgQueueSend(WILC_MsgQueueHandle *pHandle, unsigned long flags; Message *pstrMessage = NULL; - if ((pHandle == NULL) || (u32SendBufferSize == 0) || (pvSendBuffer == NULL)) { + if ((!pHandle) || (u32SendBufferSize == 0) || (!pvSendBuffer)) { WILC_ERRORREPORT(s32RetStatus, WILC_INVALID_ARGUMENT); } @@ -77,12 +77,12 @@ WILC_ErrNo WILC_MsgQueueSend(WILC_MsgQueueHandle *pHandle, memcpy(pstrMessage->pvBuffer, pvSendBuffer, u32SendBufferSize); /* add it to the message queue */ - if (pHandle->pstrMessageList == NULL) { + if (!pHandle->pstrMessageList) { pHandle->pstrMessageList = pstrMessage; } else { Message *pstrTailMsg = pHandle->pstrMessageList; - while (pstrTailMsg->pstrNext != NULL) + while (pstrTailMsg->pstrNext) pstrTailMsg = pstrTailMsg->pstrNext; pstrTailMsg->pstrNext = pstrMessage; @@ -95,8 +95,8 @@ WILC_ErrNo WILC_MsgQueueSend(WILC_MsgQueueHandle *pHandle, WILC_CATCH(s32RetStatus) { /* error occured, free any allocations */ - if (pstrMessage != NULL) { - if (pstrMessage->pvBuffer != NULL) + if (pstrMessage) { + if (pstrMessage->pvBuffer) kfree(pstrMessage->pvBuffer); kfree(pstrMessage); @@ -120,8 +120,8 @@ WILC_ErrNo WILC_MsgQueueRecv(WILC_MsgQueueHandle *pHandle, WILC_ErrNo s32RetStatus = WILC_SUCCESS; unsigned long flags; - if ((pHandle == NULL) || (u32RecvBufferSize == 0) - || (pvRecvBuffer == NULL) || (pu32ReceivedLength == NULL)) { + if ((!pHandle) || (u32RecvBufferSize == 0) + || (!pvRecvBuffer) || (!pu32ReceivedLength)) { WILC_ERRORREPORT(s32RetStatus, WILC_INVALID_ARGUMENT); } @@ -151,7 +151,7 @@ WILC_ErrNo WILC_MsgQueueRecv(WILC_MsgQueueHandle *pHandle, spin_lock_irqsave(&pHandle->strCriticalSection, flags); pstrMessage = pHandle->pstrMessageList; - if (pstrMessage == NULL) { + if (!pstrMessage) { spin_unlock_irqrestore(&pHandle->strCriticalSection, flags); WILC_ERRORREPORT(s32RetStatus, WILC_FAIL); }