From patchwork Wed Aug 19 06:59:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 7035781 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9D7E5C05AC for ; Wed, 19 Aug 2015 06:59:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DFBA8207B2 for ; Wed, 19 Aug 2015 06:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 211FB207B1 for ; Wed, 19 Aug 2015 06:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbbHSG7h (ORCPT ); Wed, 19 Aug 2015 02:59:37 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34958 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbbHSG7g (ORCPT ); Wed, 19 Aug 2015 02:59:36 -0400 Received: by pdob1 with SMTP id b1so21900537pdo.2 for ; Tue, 18 Aug 2015 23:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CYOC7SjeP/DFaHIezu+61DWzlXwm89NQSfF3nY1RMF8=; b=Bri+SpRst1wiFE4BEUzDBPUQBzIu4T1gYNp24Yl5rwHDlOWaai5c1S+C0edBANbnLU /LAysgt4alrQNdj4tQQEHUCQobbTgBji6KP+39wmW8EF9VwzKTd//TR33z+AS/FmbdYK RCPB4QCz/xk+1HMJKhT/GvdprSfONDUwqaTomJ1HEoU8/e8TS4u8cYnSRqbFrBxLeICQ bBwvBvmfrAMbe1x6QLFRNKkIkaoo+WCven0Tqj2c9ArCuM4w1pl07hWrVdMg1qQY9Js3 PS7O6V1JB4aie/MfwJRnHXN9u3+rQfUKx1mPIl9K8qhSULpntHEI3Tn4koa4MUXgfM2c fE3A== X-Received: by 10.70.123.37 with SMTP id lx5mr21908365pdb.158.1439967576169; Tue, 18 Aug 2015 23:59:36 -0700 (PDT) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id jw13sm20536843pad.48.2015.08.18.23.59.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Aug 2015 23:59:35 -0700 (PDT) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH 07/13] staging: wilc1000: wilc_msgqueue.c: remove kfree NULL check Date: Wed, 19 Aug 2015 15:59:02 +0900 Message-Id: <1439967548-25876-7-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1439967548-25876-1-git-send-email-chaehyun.lim@gmail.com> References: <1439967548-25876-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes kfree NULL check. WARNING: kfree(NULL) is safe and this check is probably not required. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_msgqueue.c b/drivers/staging/wilc1000/wilc_msgqueue.c index 0770ff6..d97dd70 100644 --- a/drivers/staging/wilc1000/wilc_msgqueue.c +++ b/drivers/staging/wilc1000/wilc_msgqueue.c @@ -96,9 +96,7 @@ WILC_ErrNo WILC_MsgQueueSend(WILC_MsgQueueHandle *pHandle, { /* error occured, free any allocations */ if (pstrMessage) { - if (pstrMessage->pvBuffer) - kfree(pstrMessage->pvBuffer); - + kfree(pstrMessage->pvBuffer); kfree(pstrMessage); } }