diff mbox

[RFC] rtlwifi: rtl8192cu: Add missing case in rtl92cu_get_hw_reg

Message ID 1442296916-24336-1-git-send-email-plaes@plaes.org (mailing list archive)
State Accepted
Delegated to: Kalle Valo
Headers show

Commit Message

Priit Laes Sept. 15, 2015, 6:01 a.m. UTC
Driver was reporting 'switch case not processed' after association,
so HW_VAR_KEEP_ALIVE was added and filled similarily to other drivers.

Positive side effect to this seems to be a bit more stable connection.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Larry Finger Sept. 17, 2015, 1:43 a.m. UTC | #1
On 09/15/2015 01:01 AM, Priit Laes wrote:
> Driver was reporting 'switch case not processed' after association,
> so HW_VAR_KEEP_ALIVE was added and filled similarily to other drivers.
>
> Positive side effect to this seems to be a bit more stable connection.
>
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---

This patch looks good to me. Thanks.

Cc: Stable <stable@vger.kernel.org> 3.4+
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

>   drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> index 25db369..34ce064 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -1946,6 +1946,14 @@ void rtl92cu_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
>   		rtl_write_word(rtlpriv, REG_RXFLTMAP2, *(u16 *)val);
>   		mac->rx_data_filter = *(u16 *)val;
>   		break;
> +	case HW_VAR_KEEP_ALIVE:{
> +			u8 array[2];
> +			array[0] = 0xff;
> +			array[1] = *((u8 *)val);
> +			rtl92c_fill_h2c_cmd(hw, H2C_92C_KEEP_ALIVE_CTRL, 2,
> +					    array);
> +			break;
> +		}
>   	default:
>   		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
>   			 "switch case not processed\n");
>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kalle Valo Oct. 14, 2015, 11:15 a.m. UTC | #2
> Driver was reporting 'switch case not processed' after association,
> so HW_VAR_KEEP_ALIVE was added and filled similarily to other drivers.
> 
> Positive side effect to this seems to be a bit more stable connection.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index 25db369..34ce064 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -1946,6 +1946,14 @@  void rtl92cu_set_hw_reg(struct ieee80211_hw *hw, u8 variable, u8 *val)
 		rtl_write_word(rtlpriv, REG_RXFLTMAP2, *(u16 *)val);
 		mac->rx_data_filter = *(u16 *)val;
 		break;
+	case HW_VAR_KEEP_ALIVE:{
+			u8 array[2];
+			array[0] = 0xff;
+			array[1] = *((u8 *)val);
+			rtl92c_fill_h2c_cmd(hw, H2C_92C_KEEP_ALIVE_CTRL, 2,
+					    array);
+			break;
+		}
 	default:
 		RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
 			 "switch case not processed\n");