From patchwork Sat Oct 17 10:33:01 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Priestley X-Patchwork-Id: 7421991 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 33926BEEA4 for ; Sat, 17 Oct 2015 10:33:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C1E1F20615 for ; Sat, 17 Oct 2015 10:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 243DB20614 for ; Sat, 17 Oct 2015 10:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752218AbbJQKd3 (ORCPT ); Sat, 17 Oct 2015 06:33:29 -0400 Received: from mail-wi0-f194.google.com ([209.85.212.194]:36588 "EHLO mail-wi0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751472AbbJQKd1 (ORCPT ); Sat, 17 Oct 2015 06:33:27 -0400 Received: by wihh2 with SMTP id h2so6808515wih.3 for ; Sat, 17 Oct 2015 03:33:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5wAf/MJb+fl8MqWDRynQS+fmHn3P+Uzp6PdifL8Om+0=; b=WaRhztNNbTGSf6xw4kvEebMbvbuNiuJM8PJxLFiS7NQkSSBzD4q9AGhSjEk099jDS6 ipqee5YPs1kG3ZVH7tVqYrVwAhNWFlB8alduHjHibCRyEucw7d8Z3j5tscXPRUuiwzOT vzegGLWRYg9Fk2JxN2qVH3JBgkRbnl/F+kdQLn9yrtlsLSlR895Re+/knTZDUKcf/+s+ 7PppCGAVVeraHPaTCa5dvLpfkdjU7JpfrEODt1fJBhuMQIqETCkU/oj0Xx2YofotaW5s 0p81qSQ7YEcPzhtSChUW1gN9NhAEEk6GhI6H1wlptN2J/Q+TOCIn+rAhW4oLXbF2uzhP U2og== X-Received: by 10.180.103.199 with SMTP id fy7mr9894513wib.85.1445078005917; Sat, 17 Oct 2015 03:33:25 -0700 (PDT) Received: from tipsey.3.home (188.30.104.3.threembb.co.uk. [188.30.104.3]) by smtp.gmail.com with ESMTPSA id fz2sm6645803wic.2.2015.10.17.03.33.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Oct 2015 03:33:25 -0700 (PDT) From: Malcolm Priestley To: gregkh@linuxfoundation.org Cc: linux-wireless@vger.kernel.org, Malcolm Priestley Subject: [PATCH 8/9] staging: vt6655: rename pOpts and sOpts to opts. Date: Sat, 17 Oct 2015 11:33:01 +0100 Message-Id: <1445077982-17832-8-git-send-email-tvboxspy@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1445077982-17832-1-git-send-email-tvboxspy@gmail.com> References: <1445077982-17832-1-git-send-email-tvboxspy@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP bring pointers and members into line. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6655/card.c | 8 +-- drivers/staging/vt6655/device.h | 4 +- drivers/staging/vt6655/device_main.c | 108 +++++++++++++++++------------------ 3 files changed, 60 insertions(+), 60 deletions(-) diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 71c9b97..c45e494 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -523,12 +523,12 @@ CARDvSafeResetTx( for (uu = 0; uu < TYPE_MAXTD; uu++) pDevice->iTDUsed[uu] = 0; - for (uu = 0; uu < pDevice->sOpts.tx_descs[0]; uu++) { + for (uu = 0; uu < pDevice->opts.tx_descs[0]; uu++) { pCurrTD = &(pDevice->apTD0Rings[uu]); pCurrTD->td0.owner = OWNED_BY_HOST; /* init all Tx Packet pointer to NULL */ } - for (uu = 0; uu < pDevice->sOpts.tx_descs[1]; uu++) { + for (uu = 0; uu < pDevice->opts.tx_descs[1]; uu++) { pCurrTD = &(pDevice->apTD1Rings[uu]); pCurrTD->td0.owner = OWNED_BY_HOST; /* init all Tx Packet pointer to NULL */ @@ -571,7 +571,7 @@ CARDvSafeResetRx( pDevice->pCurrRD[1] = &(pDevice->aRD1Ring[0]); /* init state, all RD is chip's */ - for (uu = 0; uu < pDevice->sOpts.rx_descs0; uu++) { + for (uu = 0; uu < pDevice->opts.rx_descs0; uu++) { pDesc = &(pDevice->aRD0Ring[uu]); pDesc->rd0.res_count = cpu_to_le16(pDevice->rx_buf_sz); pDesc->rd0.owner = OWNED_BY_NIC; @@ -579,7 +579,7 @@ CARDvSafeResetRx( } /* init state, all RD is chip's */ - for (uu = 0; uu < pDevice->sOpts.rx_descs1; uu++) { + for (uu = 0; uu < pDevice->opts.rx_descs1; uu++) { pDesc = &(pDevice->aRD1Ring[uu]); pDesc->rd0.res_count = cpu_to_le16(pDevice->rx_buf_sz); pDesc->rd0.owner = OWNED_BY_NIC; diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h index 8be3e21..55405e0 100644 --- a/drivers/staging/vt6655/device.h +++ b/drivers/staging/vt6655/device.h @@ -85,7 +85,7 @@ /* BUILD OBJ mode */ -#define AVAIL_TD(p, q) ((p)->sOpts.tx_descs[(q)] - ((p)->iTDUsed[(q)])) +#define AVAIL_TD(p, q) ((p)->opts.tx_descs[(q)] - ((p)->iTDUsed[(q)])) /* 0:11A 1:11B 2:11G */ #define BB_TYPE_11A 0 @@ -159,7 +159,7 @@ struct vnt_private { struct vnt_rx_desc *aRD1Ring; struct vnt_rx_desc *pCurrRD[TYPE_MAXRD]; - struct vnt_options sOpts; + struct vnt_options opts; u32 flags; diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c index d305d7a..fefbf82 100644 --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -168,25 +168,25 @@ static void vt6655_remove(struct pci_dev *pcid) static void device_get_options(struct vnt_private *priv) { - struct vnt_options *pOpts = &priv->sOpts; + struct vnt_options *opts = &priv->opts; - pOpts->rx_descs0 = RX_DESC_DEF0; - pOpts->rx_descs1 = RX_DESC_DEF1; - pOpts->tx_descs[0] = TX_DESC_DEF0; - pOpts->tx_descs[1] = TX_DESC_DEF1; - pOpts->int_works = INT_WORKS_DEF; + opts->rx_descs0 = RX_DESC_DEF0; + opts->rx_descs1 = RX_DESC_DEF1; + opts->tx_descs[0] = TX_DESC_DEF0; + opts->tx_descs[1] = TX_DESC_DEF1; + opts->int_works = INT_WORKS_DEF; - pOpts->short_retry = SHORT_RETRY_DEF; - pOpts->long_retry = LONG_RETRY_DEF; - pOpts->bbp_type = BBP_TYPE_DEF; + opts->short_retry = SHORT_RETRY_DEF; + opts->long_retry = LONG_RETRY_DEF; + opts->bbp_type = BBP_TYPE_DEF; } static void device_set_options(struct vnt_private *priv) { - priv->byShortRetryLimit = priv->sOpts.short_retry; - priv->byLongRetryLimit = priv->sOpts.long_retry; - priv->byBBType = priv->sOpts.bbp_type; + priv->byShortRetryLimit = priv->opts.short_retry; + priv->byLongRetryLimit = priv->opts.long_retry; + priv->byBBType = priv->opts.bbp_type; priv->byPacketType = priv->byBBType; priv->byAutoFBCtrl = AUTO_FB_0; priv->bUpdateBBVGA = true; @@ -452,10 +452,10 @@ static bool device_init_rings(struct vnt_private *priv) /*allocate all RD/TD rings a single pool*/ vir_pool = dma_zalloc_coherent(&priv->pcid->dev, - priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc) + - priv->sOpts.rx_descs1 * sizeof(struct vnt_rx_desc) + - priv->sOpts.tx_descs[0] * sizeof(struct vnt_tx_desc) + - priv->sOpts.tx_descs[1] * sizeof(struct vnt_tx_desc), + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc) + + priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc) + + priv->opts.tx_descs[0] * sizeof(struct vnt_tx_desc) + + priv->opts.tx_descs[1] * sizeof(struct vnt_tx_desc), &priv->pool_dma, GFP_ATOMIC); if (vir_pool == NULL) { dev_err(&priv->pcid->dev, "allocate desc dma memory failed\n"); @@ -464,15 +464,15 @@ static bool device_init_rings(struct vnt_private *priv) priv->aRD0Ring = vir_pool; priv->aRD1Ring = vir_pool + - priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc); + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc); priv->rd0_pool_dma = priv->pool_dma; priv->rd1_pool_dma = priv->rd0_pool_dma + - priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc); + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc); priv->tx0_bufs = dma_zalloc_coherent(&priv->pcid->dev, - priv->sOpts.tx_descs[0] * PKT_BUF_SZ + - priv->sOpts.tx_descs[1] * PKT_BUF_SZ + + priv->opts.tx_descs[0] * PKT_BUF_SZ + + priv->opts.tx_descs[1] * PKT_BUF_SZ + CB_BEACON_BUF_SIZE + CB_MAX_BUF_SIZE, &priv->tx_bufs_dma0, @@ -481,44 +481,44 @@ static bool device_init_rings(struct vnt_private *priv) dev_err(&priv->pcid->dev, "allocate buf dma memory failed\n"); dma_free_coherent(&priv->pcid->dev, - priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc) + - priv->sOpts.rx_descs1 * sizeof(struct vnt_rx_desc) + - priv->sOpts.tx_descs[0] * sizeof(struct vnt_tx_desc) + - priv->sOpts.tx_descs[1] * sizeof(struct vnt_tx_desc), + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc) + + priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc) + + priv->opts.tx_descs[0] * sizeof(struct vnt_tx_desc) + + priv->opts.tx_descs[1] * sizeof(struct vnt_tx_desc), vir_pool, priv->pool_dma); return false; } priv->td0_pool_dma = priv->rd1_pool_dma + - priv->sOpts.rx_descs1 * sizeof(struct vnt_rx_desc); + priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc); priv->td1_pool_dma = priv->td0_pool_dma + - priv->sOpts.tx_descs[0] * sizeof(struct vnt_tx_desc); + priv->opts.tx_descs[0] * sizeof(struct vnt_tx_desc); /* vir_pool: pvoid type */ priv->apTD0Rings = vir_pool - + priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc) - + priv->sOpts.rx_descs1 * sizeof(struct vnt_rx_desc); + + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc) + + priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc); priv->apTD1Rings = vir_pool - + priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc) - + priv->sOpts.rx_descs1 * sizeof(struct vnt_rx_desc) - + priv->sOpts.tx_descs[0] * sizeof(struct vnt_tx_desc); + + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc) + + priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc) + + priv->opts.tx_descs[0] * sizeof(struct vnt_tx_desc); priv->tx1_bufs = priv->tx0_bufs + - priv->sOpts.tx_descs[0] * PKT_BUF_SZ; + priv->opts.tx_descs[0] * PKT_BUF_SZ; priv->tx_beacon_bufs = priv->tx1_bufs + - priv->sOpts.tx_descs[1] * PKT_BUF_SZ; + priv->opts.tx_descs[1] * PKT_BUF_SZ; priv->pbyTmpBuff = priv->tx_beacon_bufs + CB_BEACON_BUF_SIZE; priv->tx_bufs_dma1 = priv->tx_bufs_dma0 + - priv->sOpts.tx_descs[0] * PKT_BUF_SZ; + priv->opts.tx_descs[0] * PKT_BUF_SZ; priv->tx_beacon_dma = priv->tx_bufs_dma1 + - priv->sOpts.tx_descs[1] * PKT_BUF_SZ; + priv->opts.tx_descs[1] * PKT_BUF_SZ; return true; } @@ -526,16 +526,16 @@ static bool device_init_rings(struct vnt_private *priv) static void device_free_rings(struct vnt_private *priv) { dma_free_coherent(&priv->pcid->dev, - priv->sOpts.rx_descs0 * sizeof(struct vnt_rx_desc) + - priv->sOpts.rx_descs1 * sizeof(struct vnt_rx_desc) + - priv->sOpts.tx_descs[0] * sizeof(struct vnt_tx_desc) + - priv->sOpts.tx_descs[1] * sizeof(struct vnt_tx_desc), + priv->opts.rx_descs0 * sizeof(struct vnt_rx_desc) + + priv->opts.rx_descs1 * sizeof(struct vnt_rx_desc) + + priv->opts.tx_descs[0] * sizeof(struct vnt_tx_desc) + + priv->opts.tx_descs[1] * sizeof(struct vnt_tx_desc), priv->aRD0Ring, priv->pool_dma); if (priv->tx0_bufs) dma_free_coherent(&priv->pcid->dev, - priv->sOpts.tx_descs[0] * PKT_BUF_SZ + - priv->sOpts.tx_descs[1] * PKT_BUF_SZ + + priv->opts.tx_descs[0] * PKT_BUF_SZ + + priv->opts.tx_descs[1] * PKT_BUF_SZ + CB_BEACON_BUF_SIZE + CB_MAX_BUF_SIZE, priv->tx0_bufs, priv->tx_bufs_dma0); @@ -548,7 +548,7 @@ static void device_init_rd0_ring(struct vnt_private *priv) struct vnt_rx_desc *desc; /* Init the RD0 ring entries */ - for (i = 0; i < priv->sOpts.rx_descs0; + for (i = 0; i < priv->opts.rx_descs0; i ++, curr += sizeof(struct vnt_rx_desc)) { desc = &priv->aRD0Ring[i]; desc->rd_info = kzalloc(sizeof(*desc->rd_info), GFP_ATOMIC); @@ -556,7 +556,7 @@ static void device_init_rd0_ring(struct vnt_private *priv) if (!device_alloc_rx_buf(priv, desc)) dev_err(&priv->pcid->dev, "can not alloc rx bufs\n"); - desc->next = &(priv->aRD0Ring[(i+1) % priv->sOpts.rx_descs0]); + desc->next = &(priv->aRD0Ring[(i+1) % priv->opts.rx_descs0]); desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_rx_desc)); } @@ -572,7 +572,7 @@ static void device_init_rd1_ring(struct vnt_private *priv) struct vnt_rx_desc *desc; /* Init the RD1 ring entries */ - for (i = 0; i < priv->sOpts.rx_descs1; + for (i = 0; i < priv->opts.rx_descs1; i ++, curr += sizeof(struct vnt_rx_desc)) { desc = &priv->aRD1Ring[i]; desc->rd_info = kzalloc(sizeof(*desc->rd_info), GFP_ATOMIC); @@ -580,7 +580,7 @@ static void device_init_rd1_ring(struct vnt_private *priv) if (!device_alloc_rx_buf(priv, desc)) dev_err(&priv->pcid->dev, "can not alloc rx bufs\n"); - desc->next = &(priv->aRD1Ring[(i+1) % priv->sOpts.rx_descs1]); + desc->next = &(priv->aRD1Ring[(i+1) % priv->opts.rx_descs1]); desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_rx_desc)); } @@ -593,7 +593,7 @@ static void device_free_rd0_ring(struct vnt_private *priv) { int i; - for (i = 0; i < priv->sOpts.rx_descs0; i++) { + for (i = 0; i < priv->opts.rx_descs0; i++) { struct vnt_rx_desc *desc = &(priv->aRD0Ring[i]); struct vnt_rd_info *rd_info = desc->rd_info; @@ -610,7 +610,7 @@ static void device_free_rd1_ring(struct vnt_private *priv) { int i; - for (i = 0; i < priv->sOpts.rx_descs1; i++) { + for (i = 0; i < priv->opts.rx_descs1; i++) { struct vnt_rx_desc *desc = &priv->aRD1Ring[i]; struct vnt_rd_info *rd_info = desc->rd_info; @@ -630,7 +630,7 @@ static void device_init_td0_ring(struct vnt_private *priv) struct vnt_tx_desc *desc; curr = priv->td0_pool_dma; - for (i = 0; i < priv->sOpts.tx_descs[0]; + for (i = 0; i < priv->opts.tx_descs[0]; i++, curr += sizeof(struct vnt_tx_desc)) { desc = &priv->apTD0Rings[i]; desc->td_info = kzalloc(sizeof(*desc->td_info), GFP_ATOMIC); @@ -638,7 +638,7 @@ static void device_init_td0_ring(struct vnt_private *priv) desc->td_info->buf = priv->tx0_bufs + i * PKT_BUF_SZ; desc->td_info->buf_dma = priv->tx_bufs_dma0 + i * PKT_BUF_SZ; - desc->next = &(priv->apTD0Rings[(i+1) % priv->sOpts.tx_descs[0]]); + desc->next = &(priv->apTD0Rings[(i+1) % priv->opts.tx_descs[0]]); desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_tx_desc)); } @@ -655,7 +655,7 @@ static void device_init_td1_ring(struct vnt_private *priv) /* Init the TD ring entries */ curr = priv->td1_pool_dma; - for (i = 0; i < priv->sOpts.tx_descs[1]; + for (i = 0; i < priv->opts.tx_descs[1]; i++, curr += sizeof(struct vnt_tx_desc)) { desc = &priv->apTD1Rings[i]; desc->td_info = kzalloc(sizeof(*desc->td_info), GFP_ATOMIC); @@ -663,7 +663,7 @@ static void device_init_td1_ring(struct vnt_private *priv) desc->td_info->buf = priv->tx1_bufs + i * PKT_BUF_SZ; desc->td_info->buf_dma = priv->tx_bufs_dma1 + i * PKT_BUF_SZ; - desc->next = &(priv->apTD1Rings[(i + 1) % priv->sOpts.tx_descs[1]]); + desc->next = &(priv->apTD1Rings[(i + 1) % priv->opts.tx_descs[1]]); desc->next_desc = cpu_to_le32(curr + sizeof(struct vnt_tx_desc)); } @@ -676,7 +676,7 @@ static void device_free_td0_ring(struct vnt_private *priv) { int i; - for (i = 0; i < priv->sOpts.tx_descs[0]; i++) { + for (i = 0; i < priv->opts.tx_descs[0]; i++) { struct vnt_tx_desc *desc = &priv->apTD0Rings[i]; struct vnt_td_info *td_info = desc->td_info; @@ -689,7 +689,7 @@ static void device_free_td1_ring(struct vnt_private *priv) { int i; - for (i = 0; i < priv->sOpts.tx_descs[1]; i++) { + for (i = 0; i < priv->opts.tx_descs[1]; i++) { struct vnt_tx_desc *desc = &priv->apTD1Rings[i]; struct vnt_td_info *td_info = desc->td_info; @@ -1057,7 +1057,7 @@ static void vnt_interrupt_process(struct vnt_private *priv) MACvReceive0(priv->PortOffset); MACvReceive1(priv->PortOffset); - if (max_count > priv->sOpts.int_works) + if (max_count > priv->opts.int_works) break; }