From patchwork Wed Oct 21 19:07:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: punit vara X-Patchwork-Id: 7459571 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id A1D6B9F30B for ; Wed, 21 Oct 2015 19:08:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C55DE208F6 for ; Wed, 21 Oct 2015 19:07:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1B8D208B8 for ; Wed, 21 Oct 2015 19:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755707AbbJUTHq (ORCPT ); Wed, 21 Oct 2015 15:07:46 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:37699 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755629AbbJUTHo (ORCPT ); Wed, 21 Oct 2015 15:07:44 -0400 Received: by wicfv8 with SMTP id fv8so89341497wic.0; Wed, 21 Oct 2015 12:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=c3BSd3pODxj6/th22GrE/Upp0IVaM0SmTWKsK7GtqpA=; b=hps+4W0dykY90s9U1M5UlZCTP0vByfjSCosY3C4Vpo3n/DaZ1/gtyr/VSEphQ2+Wvp TKmTSI3GbXJE6BMtWhporI+z9q8C8y6XPTSTcLHOzMczn3i1rQm+9pq/XBT29bzSABWr v+R1VMsLn8NgaF/ZkGtqOFv/REsZ3Se5/X3u33DsaQAIx9FaW4LrhlJMgKXKWT1//qE/ B12C70E6n7FD/LwBi6UGMJwBdoKYWvLprc5eHahPO6ws6t9A5IafLWa+UgO3N9eA8a/Q /3WlbC/u8rFW3pR5kVRpeHAyWZIa4VGkiYN2y/XA92dcQN2O368YcESovJ7dkMDWHa/h i2pQ== X-Received: by 10.194.2.243 with SMTP id 19mr12262401wjx.140.1445454463016; Wed, 21 Oct 2015 12:07:43 -0700 (PDT) Received: from localhost.localdomain ([163.47.14.119]) by smtp.gmail.com with ESMTPSA id m9sm8489466wib.13.2015.10.21.12.07.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Oct 2015 12:07:42 -0700 (PDT) From: Punit Vara To: kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jslaby@suse.cz, lkp@intel.com, Punit Vara Subject: [PATCH v2 08/15] net: wireless: simplify return flow for usb_control_msg Date: Thu, 22 Oct 2015 00:37:08 +0530 Message-Id: <1445454428-12331-2-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445454428-12331-1-git-send-email-punitvara@gmail.com> References: <1445454428-12331-1-git-send-email-punitvara@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS, RP_MATCHES_RCVD, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP remove int ret suggested by Jiri Slaby This patch is to the at76c50x-usb.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/at76c50x-usb.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/at76c50x-usb.c b/drivers/net/wireless/at76c50x-usb.c index dab2513..b4aa062 100644 --- a/drivers/net/wireless/at76c50x-usb.c +++ b/drivers/net/wireless/at76c50x-usb.c @@ -543,14 +543,10 @@ static void at76_ledtrig_tx_activity(void) static int at76_remap(struct usb_device *udev) { - int ret; - ret = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a, + return usb_control_msg(udev, usb_sndctrlpipe(udev, 0), 0x0a, USB_TYPE_VENDOR | USB_DIR_OUT | USB_RECIP_INTERFACE, 0, 0, NULL, 0, USB_CTRL_GET_TIMEOUT); - if (ret < 0) - return ret; - return 0; } static int at76_get_op_mode(struct usb_device *udev)