From patchwork Tue Oct 27 19:02:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: punit vara X-Patchwork-Id: 7501511 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 91084BEEA4 for ; Tue, 27 Oct 2015 19:06:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9B47C208CD for ; Tue, 27 Oct 2015 19:06:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5DA92061F for ; Tue, 27 Oct 2015 19:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965347AbbJ0TEG (ORCPT ); Tue, 27 Oct 2015 15:04:06 -0400 Received: from mail-wi0-f193.google.com ([209.85.212.193]:34155 "EHLO mail-wi0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964950AbbJ0TEE (ORCPT ); Tue, 27 Oct 2015 15:04:04 -0400 Received: by wicuk10 with SMTP id uk10so29540184wic.1; Tue, 27 Oct 2015 12:04:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ltGAS3H/MXgzJGUhYf4Rpkv7nCTwEG9aDMqrZWjDe+0=; b=PtOf/vYmbkfA9ZLis5Naylt0dGvwPeTWSv92vetwc7X8ygsd7kdx5sVVZ7W8LKajUG MOu154/RMh3WTLNYkCCYheTQmDhe1rarycTOmivCyCb0sblbhU5mQ58C3YLWbo3zToMR DElyIMcYD8Sep/sR1IyCzHP1dadwfELrJfeRaVktM6YgB9voIQN2D4+6BNNeoQcpRvhu TzeAFAuYLwft5MP2i5fruEIEw2oi8xQMQedXqexajx9UUNCBtExbNjnfhlbbn29h2D1/ k030mNkKxA5PdzfgyvxHCWrvcTaEjbHfEspitDsuqbscpzBvdfWLDg1YM6Nnz1lsQ0o2 9i3A== X-Received: by 10.180.90.203 with SMTP id by11mr26993512wib.49.1445972642926; Tue, 27 Oct 2015 12:04:02 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.144]) by smtp.gmail.com with ESMTPSA id hk5sm46320620wjb.6.2015.10.27.12.03.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 12:04:01 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Punit Vara Subject: [RESEND PATCH 05/10] net: wireless: simplify return flow for zd1201_setconfig16 Date: Wed, 28 Oct 2015 00:32:40 +0530 Message-Id: <1445972565-14963-5-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> References: <1445972565-14963-1-git-send-email-punitvara@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SBL_CSS, RP_MATCHES_RCVD, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c index 6f5c793..d9e67d9 100644 --- a/drivers/net/wireless/zd1201.c +++ b/drivers/net/wireless/zd1201.c @@ -1655,15 +1655,11 @@ static int zd1201_set_maxassoc(struct net_device *dev, struct iw_request_info *info, struct iw_param *rrq, char *extra) { struct zd1201 *zd = netdev_priv(dev); - int err; if (!zd->ap) return -EOPNOTSUPP; - err = zd1201_setconfig16(zd, ZD1201_RID_CNFMAXASSOCSTATIONS, rrq->value); - if (err) - return err; - return 0; + return zd1201_setconfig16(zd, ZD1201_RID_CNFMAXASSOCSTATIONS, rrq->value); } static int zd1201_get_maxassoc(struct net_device *dev,