From patchwork Thu Oct 29 23:17:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaehyun Lim X-Patchwork-Id: 7521941 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6CB0ABEEA4 for ; Thu, 29 Oct 2015 23:18:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9E74B207EC for ; Thu, 29 Oct 2015 23:18:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC2AB207DE for ; Thu, 29 Oct 2015 23:18:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757090AbbJ2XS3 (ORCPT ); Thu, 29 Oct 2015 19:18:29 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34657 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756855AbbJ2XS0 (ORCPT ); Thu, 29 Oct 2015 19:18:26 -0400 Received: by padda3 with SMTP id da3so5889237pad.1 for ; Thu, 29 Oct 2015 16:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NsyQEHJKwTVnowIZsQvv+kCQ2qFZVisFG+bw0yI5k50=; b=jcQDs0AAKX3/t0Py2Web7uCLFrsGxyQMZ2fgIkiPS9gw/lhwJt+XOUhih35KamPqs/ lUcWtM+4edhsXbX8AC+a3ZUgwy+9m/nbeFjJ7u72jYsmt0g+0YwPH+SnphdNgFBH+kSP FSpW5i46kplQMl+jLNudEGbM6ycMqvN2YWaZVnNT3cqNp58TxhuP/tOodCMsJdfUpnZb /HwNmDVflUOGB7ZSN2+e6P8RK9n04z1fZnkW+5BXiOpbrh2T0RM81cTJ/AQWS6c6pSpZ lcBfyIM6LOLlO/yNi7LN2G9uvAcUwwb9+Lgd+r6hUKrwWwEc3lUaBvQ0QdEUHxIqng8p s4xQ== X-Received: by 10.66.119.201 with SMTP id kw9mr4992696pab.64.1446160705629; Thu, 29 Oct 2015 16:18:25 -0700 (PDT) Received: from localhost.localdomain ([218.233.16.2]) by smtp.gmail.com with ESMTPSA id y7sm4292207par.31.2015.10.29.16.18.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Oct 2015 16:18:25 -0700 (PDT) From: Chaehyun Lim To: gregkh@linuxfoundation.org Cc: johnny.kim@atmel.com, austin.shin@atmel.com, chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com, leo.kim@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, Chaehyun Lim Subject: [PATCH V2 11/12] staging: wilc1000: use kmemdup in host_int_add_station Date: Fri, 30 Oct 2015 08:17:47 +0900 Message-Id: <1446160668-10747-11-git-send-email-chaehyun.lim@gmail.com> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1446160668-10747-1-git-send-email-chaehyun.lim@gmail.com> References: <1446160668-10747-1-git-send-email-chaehyun.lim@gmail.com> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch replaces kmalloc followed by memcpy with kmemdup. Signed-off-by: Chaehyun Lim --- V2: add wilc1000 driver name in commit title because driver name is not included at V1. drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 3c5de75..6b804e6 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c @@ -4537,12 +4537,12 @@ int host_int_add_station(struct host_if_drv *hif_drv, memcpy(add_sta_info, sta_param, sizeof(struct add_sta_param)); if (add_sta_info->u8NumRates > 0) { - u8 *rates = kmalloc(add_sta_info->u8NumRates, GFP_KERNEL); - + u8 *rates = kmemdup(sta_param->pu8Rates, + add_sta_info->u8NumRates, + GFP_KERNEL); if (!rates) return -ENOMEM; - memcpy(rates, sta_param->pu8Rates, add_sta_info->u8NumRates); add_sta_info->pu8Rates = rates; }