From patchwork Wed Nov 18 22:51:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve deRosier X-Patchwork-Id: 7653271 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 32D6B9F2E2 for ; Wed, 18 Nov 2015 22:54:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 61003204D1 for ; Wed, 18 Nov 2015 22:54:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9733204E3 for ; Wed, 18 Nov 2015 22:54:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933272AbbKRWyA (ORCPT ); Wed, 18 Nov 2015 17:54:00 -0500 Received: from mail-qk0-f178.google.com ([209.85.220.178]:34832 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbbKRWxw (ORCPT ); Wed, 18 Nov 2015 17:53:52 -0500 Received: by qkao63 with SMTP id o63so19980379qka.2 for ; Wed, 18 Nov 2015 14:53:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=UMqy9/8tQ/O1UcUvRXi8WcMJ4gXIoI35Yfgtlth4jyE=; b=iA3LQvqrufW0h2/WCcNuJqbLNCCEhsTKYnYEGeb0Oz6Cvz5q0CR+ESbzk4LJxwA3sg HnKVeSyUu/CvvjRcWmOGyhiX78I8ZnLZo/D+oPTHNDMIY5dJJ3LjSbq3m5s/v9jrVIh3 E+0pNU2RMXYj/2nWQ7gkG3sMNysv3UFlvmaoEb/0g6PfJGKEBXmY87RJgVRudAfor38n Is2qRBJ2PU3lUQJ/VXSYMiBgKSFL21UPKFRDEFGoHzZNW3b1ADlztN1gNgR8Sv9CWlp9 Bn7P7Qj52OEjN6dbUtGbW7jcSlq8FWvcv7+8gOU8Tr0na0IUxPD02mmhqzdBOSl7beKw QMrw== X-Received: by 10.55.50.149 with SMTP id y143mr4141785qky.86.1447887231237; Wed, 18 Nov 2015 14:53:51 -0800 (PST) Received: from elmer.corp.lairdtech.com (c-50-184-185-234.hsd1.ca.comcast.net. [50.184.185.234]) by smtp.gmail.com with ESMTPSA id o47sm1561880qge.38.2015.11.18.14.53.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 18 Nov 2015 14:53:50 -0800 (PST) From: Steve deRosier X-Google-Original-From: Steve deRosier To: Kalle Valo Cc: ath6kl@lists.infradead.org, linux-wireless@vger.kernel.org, Steve deRosier Subject: [PATCH] ath6kl: Don't print error message when recv is canceled Date: Wed, 18 Nov 2015 14:51:28 -0800 Message-Id: <1447887088-19018-1-git-send-email-steve.derosier@lairdtech.com> X-Mailer: git-send-email 1.9.1 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP An error message ath6kl_htc_rxmsg_pending_handler isn't appropate for when the error is ECANCELED. This could be the result of a perfectly appropriate RX cancel due to shutdown or suspend. This allows the right cleanup to continue, but without an alarming error message in this particular case. Signed-off-by: Steve deRosier --- drivers/net/wireless/ath/ath6kl/htc_mbox.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/htc_mbox.c b/drivers/net/wireless/ath/ath6kl/htc_mbox.c index fffb65b..65c31da 100644 --- a/drivers/net/wireless/ath/ath6kl/htc_mbox.c +++ b/drivers/net/wireless/ath/ath6kl/htc_mbox.c @@ -2222,8 +2222,9 @@ int ath6kl_htc_rxmsg_pending_handler(struct htc_target *target, } if (status) { - ath6kl_err("failed to get pending recv messages: %d\n", - status); + if (status != -ECANCELED) + ath6kl_err("failed to get pending recv messages: %d\n", + status); /* cleanup any packets in sync completion queue */ list_for_each_entry_safe(packets, tmp_pkt, &comp_pktq, list) {